[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

rnk added a comment. Right, so `cantFail` must be an assertions-only check. That's not great. These deserialization APIs have really, really bad ergonomics and could use a lot of improvement if you want to look into that. It would be really nice if, for example, this worked more like dyn_cast.

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468750. augusto2112 marked an inline comment as done. augusto2112 added a comment. Add a map from compile unit id to index in vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://review

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks added a comment. In D136011#3862150 , @labath wrote: > In D136011#3860637 , @dblaikie > wrote: > >> I think the place where this will go wrong is in terms of how lldb renders >> `char` values on non-def

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1270 + +for (auto &cu : m_compile_unit_infos[cu_idx].compile_units_sps) + if (cu->GetID() == dwarf_cu.GetID()) This is technically

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 468738. clayborg added a comment. Added missing file for real this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136207/new/ https://reviews.llvm.org/D136207 Files: lldb/source/Symbol/CompileUnit.cpp

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg added a comment. In D136207#3866729 , @jingham wrote: > Seems reasonable that when resolving the start address of a line entry from > CU A we get back a line entry in CU B, then there's just something wrong in > the debug info. Trying to recov

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 468737. clayborg added a comment. Added missing test case file and clarified comments to be more consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136207/new/ https://reviews.llvm.org/D136207 Files:

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix the problem that it was treating member functions as non-member functions when

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 marked 6 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:644 + if (&comp_unit == extra.get()) + return &m_compile_unit_infos[i]; } aprantl wrote:

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468729. augusto2112 added a comment. Herald added subscribers: ormris, steven_wu, hiraditya. Added test, changed DWARFCompileUnit::BuildAddressRangeTable to not stop looking at oso ranges at offset 0. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

jingham added a comment. Seems reasonable that when resolving the start address of a line entry from CU A we get back a line entry in CU B, then there's just something wrong in the debug info. Trying to recover whatever info is recoverable seems worthwhile: essentially by falling back to a `re

[Lldb-commits] [PATCH] D136207: Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, aadsm, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Prior to t

[Lldb-commits] [PATCH] D136034: [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1e63855b08e: [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper (authored by Walter Erquinigo ). Changed prior to

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG840d861d6e52: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction… (authored by Walter Erquinigo ). Rep

[Lldb-commits] [lldb] 840d861 - [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

Author: Walter Erquinigo Date: 2022-10-18T13:57:53-07:00 New Revision: 840d861d6e524637a96fe9b7f6d2d77091521167 URL: https://github.com/llvm/llvm-project/commit/840d861d6e524637a96fe9b7f6d2d77091521167 DIFF: https://github.com/llvm/llvm-project/commit/840d861d6e524637a96fe9b7f6d2d77091521167.di

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding

This revision was automatically updated to reflect the committed changes. Closed by commit rG566146c03b05: [lldb][trace] Add a basic function call dumpdump [1] - Add the command… (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] f1e6385 - [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper

Author: Walter Erquinigo Date: 2022-10-18T13:57:53-07:00 New Revision: f1e63855b08e366dc9d3bf1d3394a8f5c77ab3a6 URL: https://github.com/llvm/llvm-project/commit/f1e63855b08e366dc9d3bf1d3394a8f5c77ab3a6 DIFF: https://github.com/llvm/llvm-project/commit/f1e63855b08e366dc9d3bf1d3394a8f5c77ab3a6.di

[Lldb-commits] [lldb] 566146c - [lldb][trace] Add a basic function call dumpdump [1] - Add the command scaffolding

Author: Walter Erquinigo Date: 2022-10-18T13:57:52-07:00 New Revision: 566146c03b054db2530f6b5997dfd0cd1a243657 URL: https://github.com/llvm/llvm-project/commit/566146c03b054db2530f6b5997dfd0cd1a243657 DIFF: https://github.com/llvm/llvm-project/commit/566146c03b054db2530f6b5997dfd0cd1a243657.di

[Lldb-commits] [PATCH] D136171: [lldb-tests] Remove dubious standard library flag

fdeazeve added a comment. This linux bot failed: https://lab.llvm.org/buildbot/#/builders/68/builds/41314 I've reverted while I give it a try in a linux VM. Interestingly, the standard library are not being passed correctly according to the log. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] 3dfc39d - Revert "[lldb-tests] Remove dubious standard library flag"

Author: Felipe de Azevedo Piovezan Date: 2022-10-18T13:59:29-04:00 New Revision: 3dfc39db582b57151c889dd0dbf3d841d0e724c4 URL: https://github.com/llvm/llvm-project/commit/3dfc39db582b57151c889dd0dbf3d841d0e724c4 DIFF: https://github.com/llvm/llvm-project/commit/3dfc39db582b57151c889dd0dbf3d841d

[Lldb-commits] [lldb] f477412 - [lldb-tests] Remove dubious standard library flag

Author: Felipe de Azevedo Piovezan Date: 2022-10-18T13:50:31-04:00 New Revision: f477412685fe6bac49d3d080ba91896c28e62116 URL: https://github.com/llvm/llvm-project/commit/f477412685fe6bac49d3d080ba91896c28e62116 DIFF: https://github.com/llvm/llvm-project/commit/f477412685fe6bac49d3d080ba91896c2

[Lldb-commits] [PATCH] D136171: [lldb-tests] Remove dubious standard library flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGf477412685fe: [lldb-tests] Remove dubious standard library flag (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136171/new/ https://re

[Lldb-commits] [PATCH] D136165: [lldb-tests] Add libcxx version check for regex tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG58a25ebb8622: [lldb-tests] Add libcxx version check for regex tests (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136165/new/ https:

[Lldb-commits] [lldb] 58a25eb - [lldb-tests] Add libcxx version check for regex tests

Author: Felipe de Azevedo Piovezan Date: 2022-10-18T13:49:19-04:00 New Revision: 58a25ebb8622ee27034f0c103a9067acda7f6300 URL: https://github.com/llvm/llvm-project/commit/58a25ebb8622ee27034f0c103a9067acda7f6300 DIFF: https://github.com/llvm/llvm-project/commit/58a25ebb8622ee27034f0c103a9067acd

[Lldb-commits] [PATCH] D136178: [lldb-tests] Add compiler version check in TestFunctionStarts

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c1d8e06d4a9: [lldb-tests] Add compiler version check in TestFunctionStarts (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136178/new/

[Lldb-commits] [lldb] 3c1d8e0 - [lldb-tests] Add compiler version check in TestFunctionStarts

Author: Felipe de Azevedo Piovezan Date: 2022-10-18T13:48:26-04:00 New Revision: 3c1d8e06d4a995f8d421ede3cf9240bbddc43441 URL: https://github.com/llvm/llvm-project/commit/3c1d8e06d4a995f8d421ede3cf9240bbddc43441 DIFF: https://github.com/llvm/llvm-project/commit/3c1d8e06d4a995f8d421ede3cf9240bbd

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

zequanwu added a comment. In D136006#3864144 , @labath wrote: > Is this purely a performance optimization, or does it have some impact on > operation (its correctness) as well? E.g. does it prevent duplicate > construction of some types or something lik

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

aprantl added a comment. Could we add a test for this that either uses full-LTO in an API test or some assembler code and and lldb-test test? Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:55 - if (debug_aranges->GetNumRanges() == num_debug_aranges) {

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468593. yinghuitan added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscod

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468592. yinghuitan added a comment. Update message per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468591. yinghuitan added a comment. Use async model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode

[Lldb-commits] [PATCH] D136171: [lldb-tests] Remove dubious standard library flag

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks obviously correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136171/new/ https://reviews.llvm.org/D136171

[Lldb-commits] [PATCH] D136178: [lldb-tests] Add compiler version check in TestFunctionStarts

fdeazeve updated this revision to Diff 468551. fdeazeve added a comment. Fixed typos in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136178/new/ https://reviews.llvm.org/D136178 Files: lldb/test/API/macosx/function-starts/TestFun

[Lldb-commits] [PATCH] D136178: [lldb-tests] Add compiler version check in TestFunctionStarts

fdeazeve created this revision. fdeazeve added reviewers: aprantl, Michael137. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test requires compiling its input program without debug information. T

[Lldb-commits] [PATCH] D136171: [lldb-tests] Remove dubious standard library flag

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test currently sets `USE_LIBSTDCPP = 0`, which is curious given the behavior of `a

[Lldb-commits] [PATCH] D136165: [lldb-tests] Add libcxx version check for regex tests

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Regex requires the c++20 flag, which was not introduced available prior to Clang 11.

[Lldb-commits] [PATCH] D136144: [lldb] Fix m_hwp_regs size for ppc64le

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f59f302e435: [lldb] Fix m_hwp_regs size for ppc64le (PR54520) (authored by nikic). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] 6f59f30 - [lldb] Fix m_hwp_regs size for ppc64le (PR54520)

Author: Nikita Popov Date: 2022-10-18T15:11:21+02:00 New Revision: 6f59f302e4358b4dc869bc298c2b9c06aa716b60 URL: https://github.com/llvm/llvm-project/commit/6f59f302e4358b4dc869bc298c2b9c06aa716b60 DIFF: https://github.com/llvm/llvm-project/commit/6f59f302e4358b4dc869bc298c2b9c06aa716b60.diff

[Lldb-commits] [lldb] b2a5dd1 - [LLDB] Fix the build for ppc64le linux

Author: Martin Storsjö Date: 2022-10-18T11:54:19+03:00 New Revision: b2a5dd12a47a784f09628f1c10ab369c3b2c3c88 URL: https://github.com/llvm/llvm-project/commit/b2a5dd12a47a784f09628f1c10ab369c3b2c3c88 DIFF: https://github.com/llvm/llvm-project/commit/b2a5dd12a47a784f09628f1c10ab369c3b2c3c88.diff

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. I haven't looked into the details. But I feel the feature worth a sentence in ReleaseNotes. (Maybe in the potential-breaking-change section). Also I think it'll be better to have an option `-fenable-discarding-unreachable-decls-in-gmf` to control the behavior. It'll