[Lldb-commits] [PATCH] D136165: [lldb-tests] Add libcxx version check for regex tests

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve created this revision.
fdeazeve added a reviewer: aprantl.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Regex requires the c++20 flag, which was not introduced available prior
to Clang 11.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136165

Files:
  lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py


Index: lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py
===================================================================
--- lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py
+++ lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py
@@ -20,6 +20,7 @@
                 "settings set target.process.thread.step-avoid-regexp 
^ignore::")
 
     @skipIfWindows
+    @skipIf(compiler="clang", compiler_version=['<', '11.0'])
     def test_step_avoid_regex(self):
         """Tests stepping into a function which matches the avoid regex"""
         self.build()
@@ -38,6 +39,7 @@
         self.hit_correct_function("main")
 
     @skipIfWindows
+    @skipIf(compiler="clang", compiler_version=['<', '11.0'])
     @expectedFailureAll(bugnumber="rdar://100645742")
     def test_step_avoid_regex_abi_tagged_template(self):
         """Tests stepping into an ABI tagged function that matches the avoid 
regex"""



Index: lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py
===================================================================
--- lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py
+++ lldb/test/API/functionalities/step-avoids-regexp/TestStepAvoidsRegexp.py
@@ -20,6 +20,7 @@
                 "settings set target.process.thread.step-avoid-regexp ^ignore::")
 
     @skipIfWindows
+    @skipIf(compiler="clang", compiler_version=['<', '11.0'])
     def test_step_avoid_regex(self):
         """Tests stepping into a function which matches the avoid regex"""
         self.build()
@@ -38,6 +39,7 @@
         self.hit_correct_function("main")
 
     @skipIfWindows
+    @skipIf(compiler="clang", compiler_version=['<', '11.0'])
     @expectedFailureAll(bugnumber="rdar://100645742")
     def test_step_avoid_regex_abi_tagged_template(self):
         """Tests stepping into an ABI tagged function that matches the avoid regex"""

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits