fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
The test currently sets `USE_LIBSTDCPP = 0`, which is curious given the behavior of `and` and `or` in Makefiles (the contents of the variables are not important). In particular, this causes the tests to not use the standard libraries appropriately. To capture the actual intent of the test, we're changing this to `USE_LIBCXX=1`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136171 Files: lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile Index: lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile +++ lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile @@ -1,7 +1,5 @@ CXX_SOURCES := main.cpp -USE_LIBSTDCPP := 0 - - +USE_LIBCPP := 1 CXXFLAGS_EXTRAS := -O0 include Makefile.rules
Index: lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile +++ lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile @@ -1,7 +1,5 @@ CXX_SOURCES := main.cpp -USE_LIBSTDCPP := 0 - - +USE_LIBCPP := 1 CXXFLAGS_EXTRAS := -O0 include Makefile.rules
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
