[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

Emmmer added a comment. Currently, `lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp` only handles a few jump instructions, we can refine it further if needed. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:38 + +enum riscv_dwarf_regnums { + dwar

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda added a comment. I think this DefaultUnwindPlan has the same problem that the previous patch did -- this looks like the unwind state on function entry. There is an `ABI::CreateFunctionEntryUnwindPlan()` for the unwind state on the first instruction of a function, but the idea of D

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

shafik added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:39 + CompilerType coro_func_type = ast_ctx.CreateFunctionType( + /*result_type*/ void_type, /*args*/ &void_type, /*num_args*/ 1, + /*is_variadic*/ false, /*qualifiers*/ 0);

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:15 + +class TestCoroutineHandle(TestBase): +def do_test(self, stdlib_type): jingham wrote: > apra

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 455022. avogelsgesang marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.txt lldb/packages/Python/lldbsuite/test/lldbtes

[Lldb-commits] [PATCH] D132514: [lldb] Remove obsolete Android-specific definitions

pirama created this revision. Herald added subscribers: danielkiss, pengfei, krytarowski. Herald added a project: All. pirama requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Bionic's defines the necessary symbols. Remove the specializatio

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

jingham added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:44 + +lldbutil.run_to_source_breakpoint(self, '// Break after co_yield', +lldb.SBFileSpec("main.cpp"

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

jingham added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:15 + +class TestCoroutineHandle(TestBase): +def do_test(self, stdlib_type): aprantl wrote: > Nice test!

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 created this revision. kasper81 added reviewers: DavidSpickett, Emmmer, tzb99. kasper81 added a project: LLDB. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, JDevlieghere, s.egerton, Jim, benna, psnobl, jocewei, P

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454982. Ericson2314 added a comment. Convert `CMAKE_CFG_INTDIR` as @sebastian-ne suggests, also .../bin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: b

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets (WIP)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This all looks great. I am working on a patch that will build on this, but I will be working with a memory image which needs the `CreateMemoryInstance()` ObjectFile interface impl

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang marked an inline comment as done. avogelsgesang added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:44 + +lldbutil.run_to_source_breakpoint(self, '// Break after

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. In D131159#3742370 , @labath wrote: > In D131159#3742364 , @mgorny wrote: > >> In D131159#3742235 , @mstorsjo >> wrote: >> >>> (They're only use

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 454911. avogelsgesang marked 6 inline comments as done. avogelsgesang added a comment. addressed comments from @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.h:1 +//===-- Coroutines.h ---*- C++//-*-===// +// typo: `-*- C++ -*-` Comment at: lldb/source/Plugins/Language

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

mgorny added a comment. Herald added a subscriber: JDevlieghere. In D132395#3742365 , @labath wrote: >> Ideally, we'd remove Write() from the public API. > > That might be a bit too extreme. Although I agree that the "All" version is > what one wants in

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

sebastian-ne added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) Ericson2314 wrote: > sebastian

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 454830. avogelsgesang added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.txt lldb/p

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454829. Ericson2314 added a comment. Redo sed mandating ending on word boundary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: bolt/lib/Target/AArch64/C

[Lldb-commits] [lldb] 03b8f79 - [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

Author: Michał Górny Date: 2022-08-23T15:49:16+02:00 New Revision: 03b8f79048bfc32ade0404df3d3931266a06dc92 URL: https://github.com/llvm/llvm-project/commit/03b8f79048bfc32ade0404df3d3931266a06dc92 DIFF: https://github.com/llvm/llvm-project/commit/03b8f79048bfc32ade0404df3d3931266a06dc92.diff

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

This revision was automatically updated to reflect the committed changes. Closed by commit rG03b8f79048bf: [lldb] [gdb-remote] Use Communication::WriteAll() over Write() (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

labath added a comment. In D131159#3742364 , @mgorny wrote: > In D131159#3742235 , @mstorsjo > wrote: > >> (They're only used in asserts.) I guess we should add void casts to mark the >> variables as used outsid

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > Ideally, we'd remove Write() from the public API. That might be a bit too extreme. Although I agree that the "All" version is what one wants in most cases, there are use cases (and plenty of

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mgorny added a comment. In D131159#3742235 , @mstorsjo wrote: > (They're only used in asserts.) I guess we should add void casts to mark the > variables as used outside of asserts. Actually, there's a dedicated `UNUSED_IF_ASSERT_DISABLED` macro for that

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

labath added inline comments. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) kastiglione wrote: > labath wrote: > > kastiglione wrote: > > > kastiglione wrote: > > > > JDevlieghere wrote: > > > > > kastigl

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. FYI, this patch added some new compilation warnings: [4055/7050] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/windows/MainLoopWindows.cpp.obj llvm-project/lldb/source/Host/windows/MainLoopWindows.cpp:28:9: warning: unused variable 'result' [-W

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 454728. avogelsgesang added a comment. remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.