jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
This all looks great. I am working on a patch that will build on this, but I will be working with a memory image which needs the `CreateMemoryInstance()` ObjectFile interface implemented, and in my case, I'm very much hoping to avoid reading the entire fileset out of memory -- I'd like it if we don't read more than the mach header & load commands from the fileset, so I can query for a single entry by name in the fileset (e.g. "com.apple.kernel"). If the memory ObjectContainerMachOFileset created a memory ObjectFile for that name, that's fine, I'll be reading it from memory soon to get the UUID anyway out of the load commands. (ObjectFileMachO will only read the header + load commands for a memory module, until you touch the symbol table.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132433/new/ https://reviews.llvm.org/D132433 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
