labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
> Ideally, we'd remove Write() from the public API. That might be a bit too extreme. Although I agree that the "All" version is what one wants in most cases, there are use cases (and plenty of historical precedent) for the other version. I could imagine renaming things such that one is discouraged (or at least forced to think) from using automatically the `Write` function. Maybe call it `WriteSome`, `WritePartial`, ... However we'd also need to think about consistency with all our other classes which have `Write` methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132395/new/ https://reviews.llvm.org/D132395 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits