[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:65-69 +// Indeed this is a leak, but it's intentional. "future" obj destructor +// will block on waiting for the worker thread to join. And the worker +// thread might be stuck in b

[Lldb-commits] [lldb] 5a19777 - [LLDB][NFC] Suppress spurious static inspection warnings

Author: Slava Gurevich Date: 2022-08-17T16:12:42-07:00 New Revision: 5a197772ee3077e7bfa2eb3d047d4f36a28b0f39 URL: https://github.com/llvm/llvm-project/commit/5a197772ee3077e7bfa2eb3d047d4f36a28b0f39 DIFF: https://github.com/llvm/llvm-project/commit/5a197772ee3077e7bfa2eb3d047d4f36a28b0f39.diff

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a197772ee30: [LLDB][NFC] Suppress spurious static inspection warnings (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ htt

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

jingham added a comment. In D131996#3728253 , @labath wrote: > In case you have an idea of what's the "typical" number of objects in shared > cluster, then we can tune the integer template parameter (in case we usually > have more than 16 objects, then

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rG71d778f33e86: [LLDB][NativePDB] Switch to use DWARFLocationList. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D130796?vs=452031&id

[Lldb-commits] [lldb] 71d778f - [LLDB][NativePDB] Switch to use DWARFLocationList.

Author: Zequan Wu Date: 2022-08-17T13:37:13-07:00 New Revision: 71d778f33e8615f525f118db351c6541b40199ab URL: https://github.com/llvm/llvm-project/commit/71d778f33e8615f525f118db351c6541b40199ab DIFF: https://github.com/llvm/llvm-project/commit/71d778f33e8615f525f118db351c6541b40199ab.diff LOG

[Lldb-commits] [PATCH] D132062: [lldb] [gdb-remote] Clean up the API of GDBRemoteCommunication

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Make the public & protected fields and methods of GDBRemoteCommunication private if they are no

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

rnk accepted this revision. rnk added a comment. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130796/new/ https://reviews.llvm.org/D130796 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG163319070947: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread (authored by fixathon). Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] 1633190 - [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

Author: Slava Gurevich Date: 2022-08-17T12:20:10-07:00 New Revision: 163319070947a51beed9d3773bf53d3d48120db8 URL: https://github.com/llvm/llvm-project/commit/163319070947a51beed9d3773bf53d3d48120db8 DIFF: https://github.com/llvm/llvm-project/commit/163319070947a51beed9d3773bf53d3d48120db8.diff

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon updated this revision to Diff 453392. fixathon marked an inline comment as done. fixathon added a comment. This revision is now accepted and ready to land. Back out changes for checking the return val of the function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment. Planning to undo checking the return value of FindLineEntryByAddress() since it's causing an issue on some platform, and re-evaluate the underlying issue. Comment at

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon updated this revision to Diff 453348. fixathon added a comment. Change to C++ style comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ https://reviews.llvm.org/D131998 Files: lldb/include/lldb/Core/ThreadSafeValue.h ll

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex; labath wrote: > JDevlieghere wrote: > > I as

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG9525015c1bed: [lldb][tests] Test queue-specific breakpoints (authored by cassanova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://revie

[Lldb-commits] [lldb] 9525015 - [lldb][tests] Test queue-specific breakpoints

Author: Chelsea Cassanova Date: 2022-08-17T12:46:04-04:00 New Revision: 9525015c1bed5563813a440c5e5c871bd3c7eb24 URL: https://github.com/llvm/llvm-project/commit/9525015c1bed5563813a440c5e5c871bd3c7eb24 DIFF: https://github.com/llvm/llvm-project/commit/9525015c1bed5563813a440c5e5c871bd3c7eb24.d

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D131705#3726772 , @clayborg wrote: > In D131705#3726248 , @labath wrote: > >> I have somewhat mixed feelin

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

fdeazeve added a comment. Greendragon is leaking environment configurations across runs. I'll address this in a separate PR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132004/new/ https://reviews.llvm.org/D132004 ___

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG33833c861172: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for… (authored by Michael137). Rep

[Lldb-commits] [lldb] 33833c8 - [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Author: Michael Buch Date: 2022-08-17T15:39:21+01:00 New Revision: 33833c861172b48f317743cf3813af3139302052 URL: https://github.com/llvm/llvm-project/commit/33833c861172b48f317743cf3813af3139302052 DIFF: https://github.com/llvm/llvm-project/commit/33833c861172b48f317743cf3813af3139302052.diff

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Michael137 added a comment. In D132004#3728652 , @fdeazeve wrote: > In D132004#3728394 , @fdeazeve > wrote: > >> This test is now failing even on the "basic" Clang (i.e. tip of trunk) test >> matrix entry: >> >>

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

fdeazeve added a comment. In D132004#3728394 , @fdeazeve wrote: > This test is now failing even on the "basic" Clang (i.e. tip of trunk) test > matrix entry: > > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Michael137 added a comment. Build bot is green for ToT. Should be safe to commit this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132004/new/ https://reviews.llvm.org/D132004 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Michael137 added a comment. In D132004#3728394 , @fdeazeve wrote: > This test is now failing even on the "basic" Clang (i.e. tip of trunk) test > matrix entry: > > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/lo

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

fdeazeve added a comment. This test is now failing even on the "basic" Clang (i.e. tip of trunk) test matrix entry: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/?consoleFull The log above is for the "Test DWARF4" portion of the job Repository:

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Michael137 added a comment. In D132004#3727682 , @aprantl wrote: > This might be a bit aggressive. If it's easy we could add a `if clang > 14` > condition before those last two tests so we don't loose coverage? Fair point, I moved the assertions to a ne

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Michael137 updated this revision to Diff 453250. Michael137 added a comment. - Make XFAIL more specific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132004/new/ https://reviews.llvm.org/D132004 Files: lldb/test/API/lang/cpp/const_static_integr

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

labath accepted this revision. labath added a comment. In case you have an idea of what's the "typical" number of objects in shared cluster, then we can tune the integer template parameter (in case we usually have more than 16 objects, then the inline storage is just wasting space, and we could

[Lldb-commits] [lldb] fe4a582 - [LLDB][ARM] Remove expected failure from AnonTypedef test

Author: David Spickett Date: 2022-08-17T08:52:58Z New Revision: fe4a58214fe850a8fa8c58fec8e8376e7233ecba URL: https://github.com/llvm/llvm-project/commit/fe4a58214fe850a8fa8c58fec8e8376e7233ecba DIFF: https://github.com/llvm/llvm-project/commit/fe4a58214fe850a8fa8c58fec8e8376e7233ecba.diff LOG

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:66 + case 'c': +if (option_arg.getAsInteger(0, m_count) || (m_count < 0)) { m_count = UINT32_MAX; fixathon wrote: > hawkinsw wrote: > > Hope this doesn'

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

labath added a comment. In D131998#3728016 , @fixathon wrote: > In D131998#3727664 , @clayborg > wrote: > >> Can we use C++ comments instead of C comments? > > We can, and I'll make the change. Do you think it wo

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rG88d3c1db4531: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] 88d3c1d - [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Author: Michael Buch Date: 2022-08-17T09:02:43+01:00 New Revision: 88d3c1db453189c3c76b5b83e4d47b2c7f4adf1f URL: https://github.com/llvm/llvm-project/commit/88d3c1db453189c3c76b5b83e4d47b2c7f4adf1f DIFF: https://github.com/llvm/llvm-project/commit/88d3c1db453189c3c76b5b83e4d47b2c7f4adf1f.diff

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

clayborg added a comment. In D131998#3728016 , @fixathon wrote: > In D131998#3727664 , @clayborg > wrote: > >> Can we use C++ comments instead of C comments? > > We can, and I'll make the change. Do you think it

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon reopened this revision. fixathon marked an inline comment as done. fixathon added a comment. This revision is now accepted and ready to land. Thank you, @stella.stamenova , will investigate. Added comments with the initial findings Comment at: lldb/source/Commands/Com