[Lldb-commits] [PATCH] D131783: [LLDB][JIT] Set processor for ARM architecture

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9efe240c47: [LLDB][JIT] Set processor for ARM architecture (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131783/new/ https://review

[Lldb-commits] [lldb] ff9efe2 - [LLDB][JIT] Set processor for ARM architecture

Author: Pavel Kosov Date: 2022-08-17T09:10:21+03:00 New Revision: ff9efe240c4711572d2892f9058fd94a8bd5336e URL: https://github.com/llvm/llvm-project/commit/ff9efe240c4711572d2892f9058fd94a8bd5336e DIFF: https://github.com/llvm/llvm-project/commit/ff9efe240c4711572d2892f9058fd94a8bd5336e.diff L

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon added a comment. In D131998#3727664 , @clayborg wrote: > Can we use C++ comments instead of C comments? We can, and I'll make the change. Do you think it would be a good idea to keep the coverity annotations only as C-style comments (comments f

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 453194. tstellar added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 Files: clang/CMakeLists.txt compiler-rt/CMakeLists.txt lld/CMakeLists

[Lldb-commits] [lldb] 9fc6565 - fold assert-only variable into assert to address non-assert -Wunused-variable

Author: David Blaikie Date: 2022-08-17T04:10:59Z New Revision: 9fc65658f5e5a0af5821f4945d78a9f6b8fd368f URL: https://github.com/llvm/llvm-project/commit/9fc65658f5e5a0af5821f4945d78a9f6b8fd368f DIFF: https://github.com/llvm/llvm-project/commit/9fc65658f5e5a0af5821f4945d78a9f6b8fd368f.diff LOG:

[Lldb-commits] [lldb] 0cbaed3 - Revert "[LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread"

Author: Stella Stamenova Date: 2022-08-16T18:11:28-07:00 New Revision: 0cbaed3e14448de4b9ed32b7f531471bc6d4347f URL: https://github.com/llvm/llvm-project/commit/0cbaed3e14448de4b9ed32b7f531471bc6d4347f DIFF: https://github.com/llvm/llvm-project/commit/0cbaed3e14448de4b9ed32b7f531471bc6d4347f.di

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb706f56133a7: [lldb] Automatically unwrap parameter packs in template argument accessors (authored by JDevlieghere). Hera

[Lldb-commits] [lldb] b706f56 - [lldb] Automatically unwrap parameter packs in template argument accessors

Author: Jonas Devlieghere Date: 2022-08-16T18:10:14-07:00 New Revision: b706f56133a77f9d7c55270ac24ff59e6fce3fa4 URL: https://github.com/llvm/llvm-project/commit/b706f56133a77f9d7c55270ac24ff59e6fce3fa4 DIFF: https://github.com/llvm/llvm-project/commit/b706f56133a77f9d7c55270ac24ff59e6fce3fa4.d

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Thanks for the review Michael. I've addressed all your comments in the version I landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 __

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

aprantl added a comment. This might be a bit aggressive. If it's easy we could add a `if clang > 14` condition before those last two tests so we don't loose coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132004/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

stella.stamenova added a comment. This broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/22557/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131983/new/ https://reviews.llvm.org/D131983

[Lldb-commits] [lldb] 9fd54cf - [LLDB][NativePDB] Add nullptr checking.

Author: Zequan Wu Date: 2022-08-16T17:01:47-07:00 New Revision: 9fd54cf5c9620504c8c16cf885354b6f9d82f638 URL: https://github.com/llvm/llvm-project/commit/9fd54cf5c9620504c8c16cf885354b6f9d82f638 DIFF: https://github.com/llvm/llvm-project/commit/9fd54cf5c9620504c8c16cf885354b6f9d82f638.diff LOG

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Michael137 created this revision. Michael137 added reviewers: aprantl, fdeazeve. Herald added a reviewer: JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test fails for Clang versio

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

clayborg added a comment. Can we use C++ comments instead of C comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ https://reviews.llvm.org/D131998 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon created this revision. fixathon added a reviewer: clayborg. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, a

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) JDevlieghere wrote: > Any reason this should

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) Any reason this should be a separate func

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo inline comment. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex;

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131996/new/ https://reviews.llvm.org/D131996 ___

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

hawkinsw added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:66 + case 'c': +if (option_arg.getAsInteger(0, m_count) || (m_count < 0)) { m_count = UINT32_MAX; Hope this doesn't screw up Phabricator, but I just w

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

This revision was automatically updated to reflect the committed changes. fixathon marked 3 inline comments as done. Closed by commit rG461b41015942: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 461b410 - [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

Author: Slava Gurevich Date: 2022-08-16T15:30:25-07:00 New Revision: 461b410159426fdc6da77e0fb653737e04e0ebe9 URL: https://github.com/llvm/llvm-project/commit/461b410159426fdc6da77e0fb653737e04e0ebe9 DIFF: https://github.com/llvm/llvm-project/commit/461b410159426fdc6da77e0fb653737e04e0ebe9.diff

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectThread.cpp:66 + case 'c': +if (option_arg.getAsInteger(0, m_count) || (m_count < 0)) { m_count =

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:66 + case 'c': +if (option_arg.getAsInteger(0, m_count) || (m_count < 0)) { m_count = UINT32_MAX; hawkinsw wrote: > fixathon wrote: > > If getAsIntege

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fe72001e8d6: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/

[Lldb-commits] [lldb] 1fe7200 - [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

Author: Slava Gurevich Date: 2022-08-16T14:34:50-07:00 New Revision: 1fe72001e8d69cae1975a360fee055c2fd3730f4 URL: https://github.com/llvm/llvm-project/commit/1fe72001e8d69cae1975a360fee055c2fd3730f4 DIFF: https://github.com/llvm/llvm-project/commit/1fe72001e8d69cae1975a360fee055c2fd3730f4.diff

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda, kastiglione, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The m_objects store in ClusterManager holds pointe

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

hawkinsw added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:66 + case 'c': +if (option_arg.getAsInteger(0, m_count) || (m_count < 0)) { m_count = UINT32_MAX; fixathon wrote: > If getAsInteger() fails we trigger

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 453109. fixathon added a comment. Address comments about passing-by-ref for perf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 Files: lldb/source/Plugins/Instrum

[Lldb-commits] [lldb] 50630dc - [lldb] Fix warnings

Author: Kazu Hirata Date: 2022-08-16T12:33:21-07:00 New Revision: 50630dcc4c8ab5de26e153a948577c4cc743b722 URL: https://github.com/llvm/llvm-project/commit/50630dcc4c8ab5de26e153a948577c4cc743b722 DIFF: https://github.com/llvm/llvm-project/commit/50630dcc4c8ab5de26e153a948577c4cc743b722.diff L

[Lldb-commits] [PATCH] D126615: [lldb] Add an integration test for non-stop protocol

emaste added a comment. Looks reasonable to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126615/new/ https://reviews.llvm.org/D126615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

clayborg added a comment. Looks great, maybe fix the pass by value in the callback and this is good? Comment at: lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp:230 +std::function const &callback) { + auto array_sp = std::make_shared();

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

clayborg added inline comments. Comment at: lldb/test/API/python_api/absolute_symbol/TestAbsoluteSymbol.py:28-29 +and this caused problems as the new sections could interfere with +with address resolution. Absolute symbols' values are not addresses +

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

clayborg added a comment. In D131705#3726248 , @labath wrote: > I have somewhat mixed feelings about this. > > On one hand, I was never too happy with how we're creating these funny extra > sections, so I can't say I would be sad to see that go. OTOH, I

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny updated this revision to Diff 453071. mgorny added a comment. Add a test that notifying actually works on top of pending read. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 Files: lldb/include/lldb/Host/MainLoopBase.h lldb/include

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny updated this revision to Diff 453067. mgorny added a comment. Add `m_event_pipe` handler to `m_read_fds` to avoid reinventing the wheel three times. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 Files: lldb/include/lldb/Host/MainLo

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon marked an inline comment as done. fixathon added a comment. All pending suggestions have been resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. In D131160#3726642 , @mgorny wrote: > Ok, I've just realized that the pipe writing solution isn't going to work > when the notification happens from the same thread (as the unittest does > right now). @labath, do you happen to ha

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. Ok, I've just realized that the pipe writing solution isn't going to work when the notification happens from the same thread (as the unittest does right now). @labath, do you happen to have an idea how to solve that reasonably cleanly? CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

ilya-biryukov added a comment. I agree that the change in behaviour is reasonable and have no objections to it. The code should not rely on particular output of `__PRETTY_FUNCTION__`. I just wanted to point out that we still don't match GCC in other cases, not that is was a worthwhile goal to ch

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

labath accepted this revision. labath added a comment. For me this wins on simplicity grounds alone. In D131974#3726475 , @Michael137 wrote: > - Check mangled name and storage class before attaching label I don't think that the storage class check is h

[Lldb-commits] [lldb] 7ebbef2 - [LLDB][NativePDB] Add nullptr checking.

Author: Zequan Wu Date: 2022-08-16T09:59:09-07:00 New Revision: 7ebbef2b303fc1c54950bd9047f79e353ee0129c URL: https://github.com/llvm/llvm-project/commit/7ebbef2b303fc1c54950bd9047f79e353ee0129c DIFF: https://github.com/llvm/llvm-project/commit/7ebbef2b303fc1c54950bd9047f79e353ee0129c.diff LOG

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! This looks like a fine incremental improvement. But we should aim at eventually getting rid of these XFAILs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 updated this revision to Diff 453043. Michael137 added a comment. - Remove libcxx ABI-tag workaround from API test makefile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131974/new/ https://reviews.llvm.org/D131974 Files: lldb/package

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 updated this revision to Diff 453041. Michael137 added a comment. - Check mangled name and storage class before attaching label Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131974/new/ https://reviews.llvm.org/D131974 Files: lldb/sou

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 added a comment. In D131974#3726451 , @labath wrote: > In D131974#3726438 , @Michael137 > wrote: > >> lang/cpp/extern_c/TestExternCSymbols.py > > I think that's because `extern "C"` symbols don't hav

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 added a comment. > Following tests fail with this: > > lang/cpp/extern_c/TestExternCSymbols.py > lang/cpp/namespace/TestNamespaceLookup.py > macosx/rosetta/TestRosetta.py > > Investigating currently... Fixed with latest diff Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

labath added a comment. In D131974#3726438 , @Michael137 wrote: > lang/cpp/extern_c/TestExternCSymbols.py I think that's because `extern "C"` symbols don't have a DW_AT_linkage_name attribute. Generally speaking, I don't think we can assume all debug

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 added a comment. Herald added a subscriber: JDevlieghere. This implements @labath's suggestion from https://reviews.llvm.org/D131335 Following tests fail with this: lang/cpp/extern_c/TestExternCSymbols.py lang/cpp/namespace/TestNamespaceLookup.py macosx/rosetta/TestRosetta.py I

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 created this revision. Michael137 added reviewers: labath, aprantl, jingham. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When resolving symbols during I

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

labath added a comment. In D131539#3712675 , @JDevlieghere wrote: > In D131539#3711835 , @labath wrote: > >> In D131539#3711518 , @JDevlieghere >> wrote: >> >>> In D1315

[Lldb-commits] [PATCH] D131759: [LLDB][RISCV] Make software single stepping work

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc7e9cba24b: [LLDB][RISCV] Make software single stepping work (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 4fc7e9c - [LLDB][RISCV] Make software single stepping work

Author: Emmmer Date: 2022-08-16T23:44:50+08:00 New Revision: 4fc7e9cba24b3f96f274126218a7985f31aa5861 URL: https://github.com/llvm/llvm-project/commit/4fc7e9cba24b3f96f274126218a7985f31aa5861 DIFF: https://github.com/llvm/llvm-project/commit/4fc7e9cba24b3f96f274126218a7985f31aa5861.diff LOG: [

[Lldb-commits] [PATCH] D131946: [LLDB] Handle possible resume thread error

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ed3e75c96d9: [LLDB] Handle possible resume thread error (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] 8ed3e75 - [LLDB] Handle possible resume thread error

Author: Emmmer Date: 2022-08-16T23:43:28+08:00 New Revision: 8ed3e75c96d987e294067e2fe0ab5b02a5bcc89d URL: https://github.com/llvm/llvm-project/commit/8ed3e75c96d987e294067e2fe0ab5b02a5bcc89d DIFF: https://github.com/llvm/llvm-project/commit/8ed3e75c96d987e294067e2fe0ab5b02a5bcc89d.diff LOG: [

[Lldb-commits] [PATCH] D131945: [LLDB] Fix possible nullptr exception

This revision was automatically updated to reflect the committed changes. Closed by commit rG95e2949a5352: [LLDB] Fix possible nullptr exception (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 95e2949 - [LLDB] Fix possible nullptr exception

Author: Emmmer Date: 2022-08-16T23:41:00+08:00 New Revision: 95e2949a5352aea0182ba5295bf9ba46080c261e URL: https://github.com/llvm/llvm-project/commit/95e2949a5352aea0182ba5295bf9ba46080c261e DIFF: https://github.com/llvm/llvm-project/commit/95e2949a5352aea0182ba5295bf9ba46080c261e.diff LOG: [

[Lldb-commits] [PATCH] D131667: [LLDB][RISCV] Fix risc-v target build

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.cpp:54 +NativeRegisterContextLinux::DetermineArchitecture(lldb::tid_t tid) { + return HostInfo::GetArchitecture(); +} DavidSpickett wrote: > On the as

[Lldb-commits] [PATCH] D131335: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/abi_tag_lookup/TestAbiTagLookup.py:14 +@skipIfWindows +@expectedFailureAll(debug_info=["dwarf", "gmodules", "dwo"]) +def test_abi_tag_lookup(self): labath wrote: > This means the tes

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

labath added a subscriber: dsrbecky. labath added a comment. I have somewhat mixed feelings about this. On one hand, I was never too happy with how we're creating these funny extra sections, so I can't say I would be sad to see that go. OTOH, I can't really agree with the assertion that these s

[Lldb-commits] [PATCH] D131335: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. Thanks for taking the time to look at this > I would like to understand what (if any) are the issues with extending the > approach #2 to cover non-member functions as well. For what it's worth, I > don't think #2 is a hack. I might actually say that's "using DWARF as

[Lldb-commits] [PATCH] D131335: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

labath added a comment. In D131335#3722595 , @Michael137 wrote: > As @labath mentioned, we do force clang to preserve the linkage name via > `asm()`, but only for class member functions. This was added in > `675767a5910d2ec77ef8b51c78fe312cf9022896` (h

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

Michael137 accepted this revision. Michael137 added a comment. LGTM Just had some minor stylistic/documentation suggestions Comment at: lldb/source/API/SBType.cpp:576 lldb::TemplateArgumentKind SBType::GetTemplateArgumentKind(uint32_t idx) { LLDB_INSTRUMENT_VA(this, idx)

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

This revision was automatically updated to reflect the committed changes. Closed by commit rG662c1c28813b: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1316

[Lldb-commits] [lldb] 662c1c2 - [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

Author: David Spickett Date: 2022-08-16T08:28:50Z New Revision: 662c1c28813b4dd0cf8775b9acb950ded9705cae URL: https://github.com/llvm/llvm-project/commit/662c1c28813b4dd0cf8775b9acb950ded9705cae DIFF: https://github.com/llvm/llvm-project/commit/662c1c28813b4dd0cf8775b9acb950ded9705cae.diff LOG