labath accepted this revision. labath added a comment. For me this wins on simplicity grounds alone.
In D131974#3726475 <https://reviews.llvm.org/D131974#3726475>, @Michael137 wrote: > - Check mangled name and storage class before attaching label I don't think that the storage class check is helping anything. Non-external functions can have DW_AT_linkage_names and ABI tags (although their usefulness is questionable) as well. Of course, that means that the local (indicated by the `L` in the name) mangled name is not necessarily unique (and that's why I said that going off of the address would be more correct). However, this is not something we can fix by letting clang deduce the name for itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131974/new/ https://reviews.llvm.org/D131974 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
