[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere added inline comments. Comment at: lldb/source/Core/DataFileCache.cpp:23-39 // Prune the cache based off of the LLDB settings each time we create a cache // object. ModuleListProperties &properties = ModuleList::GetGlobalModuleListProperties(); llv

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

clayborg added a comment. Is this new constructor going to be used elsewhere? It would be great to get more description on why this is desired/needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131531/new/ https://reviews.llvm.org/D131531

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

fixathon created this revision. fixathon added a reviewer: jingham. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing a small style nit described in D131294 Rep

[Lldb-commits] [PATCH] D131542: [lldb/crashlog] Add `-V|--version` option

mib created this revision. mib added reviewers: JDevlieghere, aprantl. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new option to the crashlog command to get the the script version.

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

tzb99 added a comment. In D130342#3710299 , @Emmmer wrote: > In D130342#3710122 , @tzb99 wrote: > >> In D130342#3709772 , @Emmmer wrote: >> >>> What is implemented: >>> >>

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

JDevlieghere added a comment. In D131539#3711488 , @kastiglione wrote: > this diff has made me wonder: should we have a `NoDebugInfoTestCase` that can > be used by any test, and would replace assigning to `NO_DEBUG_INFO_TESTCASE`? I was wondering the s

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66f8819c5087: [lldb/crashlog] Refactor the CrashLogParser logic (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mib marked an inline comment as done. Closed by commit rG355be8cf8016: [lldb/crashlog] Skip null image dsym fetching on interactive mode (authored by mib). Changed pri

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41c1a5f9bdc4: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode (authored by mib). Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Remove 'process_path' parsing logic

This revision was automatically updated to reflect the committed changes. Closed by commit rG13aa780f37e1: [lldb/crashlog] Remove 'process_path' parsing logic (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131033/new/ https://revie

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG81cbc294571f: [lldb/crashlog] Update frame regex matcher (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] 66f8819 - [lldb/crashlog] Refactor the CrashLogParser logic

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: 66f8819c5087198a62ba15da4477d59b9e4a1a1d URL: https://github.com/llvm/llvm-project/commit/66f8819c5087198a62ba15da4477d59b9e4a1a1d DIFF: https://github.com/llvm/llvm-project/commit/66f8819c5087198a62ba15da4477d59b9e4a1a1d.

[Lldb-commits] [lldb] 355be8c - [lldb/crashlog] Skip null image dsym fetching on interactive mode

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: 355be8cf801603756520cf5d9b4b5eaf9d1b2e77 URL: https://github.com/llvm/llvm-project/commit/355be8cf801603756520cf5d9b4b5eaf9d1b2e77 DIFF: https://github.com/llvm/llvm-project/commit/355be8cf801603756520cf5d9b4b5eaf9d1b2e77.

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

This revision was automatically updated to reflect the committed changes. Closed by commit rGa07a75180c01: [lldb/crashlog] Surface error using SBCommandReturnObject argument (authored by mib). Changed prior to commit: https://reviews.llvm.org/D129614?vs=449784&id=451346#toc Repository: rG LL

[Lldb-commits] [lldb] 41c1a5f - [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: 41c1a5f9bdc4cb6914e7971f50e4f45aeb11e087 URL: https://github.com/llvm/llvm-project/commit/41c1a5f9bdc4cb6914e7971f50e4f45aeb11e087 DIFF: https://github.com/llvm/llvm-project/commit/41c1a5f9bdc4cb6914e7971f50e4f45aeb11e087.

[Lldb-commits] [lldb] 13aa780 - [lldb/crashlog] Remove 'process_path' parsing logic

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: 13aa780f37e193d8c23a6c5ff98cc4c7febc1f95 URL: https://github.com/llvm/llvm-project/commit/13aa780f37e193d8c23a6c5ff98cc4c7febc1f95 DIFF: https://github.com/llvm/llvm-project/commit/13aa780f37e193d8c23a6c5ff98cc4c7febc1f95.

[Lldb-commits] [lldb] 81cbc29 - [lldb/crashlog] Update frame regex matcher

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: 81cbc294571fbcc609666ee4aeb86fbb68a7ec23 URL: https://github.com/llvm/llvm-project/commit/81cbc294571fbcc609666ee4aeb86fbb68a7ec23 DIFF: https://github.com/llvm/llvm-project/commit/81cbc294571fbcc609666ee4aeb86fbb68a7ec23.

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGa633c5e11b44: [lldb/crashlog] Add '-t|--target' option to interactive mode (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ http

[Lldb-commits] [lldb] a07a751 - [lldb/crashlog] Surface error using SBCommandReturnObject argument

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: a07a75180c01a3f262b02f69ee5722080da74b84 URL: https://github.com/llvm/llvm-project/commit/a07a75180c01a3f262b02f69ee5722080da74b84 DIFF: https://github.com/llvm/llvm-project/commit/a07a75180c01a3f262b02f69ee5722080da74b84.

[Lldb-commits] [lldb] a633c5e - [lldb/crashlog] Add '-t|--target' option to interactive mode

Author: Med Ismail Bennani Date: 2022-08-09T21:01:37-07:00 New Revision: a633c5e11b4443000aa199a2df41eda4e2c6851b URL: https://github.com/llvm/llvm-project/commit/a633c5e11b4443000aa199a2df41eda4e2c6851b DIFF: https://github.com/llvm/llvm-project/commit/a633c5e11b4443000aa199a2df41eda4e2c6851b.

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

kastiglione added a comment. this diff has made me wonder: should we have a `NoDebugInfoTestCase` that can be used by any test, and would replace assigning to `NO_DEBUG_INFO_TESTCASE`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131539/new/ https://reviews.llvm.org/D131539 _

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

JDevlieghere created this revision. JDevlieghere added reviewers: mib, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. I noticed a few Python API tests (`test/API/python_api`) were not marked as `NO_DEBUG_INFO_TESTCASE` causing them to be rerun needlessly

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 created this revision. augusto2112 added reviewers: clayborg, labath, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib added a comment. In D131085#3711104 , @kastiglione wrote: > thanks for having patience with us reviewers, lgtm with one comment about > python versions Thanks for the review :) ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 451306. mib added a comment. Remove walrus (`:=`) operator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_pr

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

shafik accepted this revision. shafik added a comment. LGTM. Thank you for the quick follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 ___ lldb-commits

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

shafik added a comment. In D131472#3709684 , @labath wrote: > Good catch. Lldb should try to be useful even if the debugged program invokes > undefined behavior. Totally agree, for the purposes here there should be no difference for these purposes betw

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks for having patience with us reviewers, lgtm with one comment about python versions Comment at: lldb/examples/python/crashlog.py:421 +def __new__(cls, de

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. In D131159#3709965 , @labath wrote: >> Can @alvinhochun take the patch for a spin? I think you've got more >> realistic usecases of lldb to try it out in. (Do you want me to make a build >> with the patch for you to try out?) @

[Lldb-commits] [lldb] 36a461b - @skipIfAsan for the other long test in TestMemoryRegion.py

Author: Jim Ingham Date: 2022-08-09T14:55:20-07:00 New Revision: 36a461b8c2a2df47a59789e92908a1275aa5fc30 URL: https://github.com/llvm/llvm-project/commit/36a461b8c2a2df47a59789e92908a1275aa5fc30 DIFF: https://github.com/llvm/llvm-project/commit/36a461b8c2a2df47a59789e92908a1275aa5fc30.diff LO

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 451266. mib added a comment. Implement @kastiglione suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripte

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) kastiglione wr

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib added a comment. In D131085#3710597 , @kastiglione wrote: > was the chmod intentional? nop, thanks for catching that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 _

[Lldb-commits] [lldb] 0c86fbb - The memory region tests have been consistently timing on the ASAN

Author: Jim Ingham Date: 2022-08-09T12:52:18-07:00 New Revision: 0c86fbb557a63d2e9cc2e1a82feb38fe11ecbcdd URL: https://github.com/llvm/llvm-project/commit/0c86fbb557a63d2e9cc2e1a82feb38fe11ecbcdd DIFF: https://github.com/llvm/llvm-project/commit/0c86fbb557a63d2e9cc2e1a82feb38fe11ecbcdd.diff LO

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added a comment. was the chmod intentional? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) kastig

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) mib wr

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe01292457fc: Move FormattersMatchCandidate flags to a struct. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D131459?vs=

[Lldb-commits] [lldb] fe01292 - Move FormattersMatchCandidate flags to a struct.

Author: Jorge Gorbe Moya Date: 2022-08-09T10:48:49-07:00 New Revision: fe01292457fc04532c5d2eccc9d0674df4582fa6 URL: https://github.com/llvm/llvm-project/commit/fe01292457fc04532c5d2eccc9d0674df4582fa6 DIFF: https://github.com/llvm/llvm-project/commit/fe01292457fc04532c5d2eccc9d0674df4582fa6.di

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:607 + std::vector param_matches; + for (size_t i = 0; i < alternates.size(); i++) { +ConstString alternate_mangled_name = alternates[i]; Could this be `f

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. I think a week or two of moratorium would be good for sure. I think we can table this discussion for now and I will write a RFC post in discourse when I have time and we can discuss the details there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3710340 , @MaskRay wrote: > In D130689#3710291 , @aaron.ballman > wrote: > >> In D130689#3710281 , @royjacobson >> wrote: >> >>

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

MaskRay added a comment. In D130689#3710291 , @aaron.ballman wrote: > In D130689#3710281 , @royjacobson > wrote: > >> In D130689#3709834 , @thieta wrote: >> >>> In D1306

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogPar

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

Emmmer added a comment. In D130342#3710122 , @tzb99 wrote: > In D130342#3709772 , @Emmmer wrote: > >> What is implemented: >> >> - Use the same register layout as Linux kernel and mock read/write for `x0` >> regi

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3710281 , @royjacobson wrote: > In D130689#3709834 , @thieta wrote: > >> In D130689#3709742 , >> @aaron.ballman wrote: >> >>> O

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. In D130689#3709834 , @thieta wrote: > In D130689#3709742 , @aaron.ballman > wrote: > >> One thing I think would be a definite improvement is to have done an RFC on >> Discourse for t

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. In D131335#3709788 , @labath wrote: > I haven't been able to keep up with all the lldb happenings lately, so it's > possible I have missed something, but can you give a summary (or point me to > one) of what is the problem wi

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg added a comment. In D131437#3709921 , @labath wrote: > Seems reasonable, but could use a test case, though I'm not sure what would > be the best way to approach that. I suppose one could dump the index of one > of these dwo-less files, and then

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) kasti

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

tzb99 added a comment. In D130342#3709772 , @Emmmer wrote: > What is implemented: > > - Use the same register layout as Linux kernel and mock read/write for `x0` > register (the always zero register). > - Take RISC-V `ebreak` instruction as breakpoint tr

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) mib wr

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

labath added a comment. In D131159#3707741 , @mstorsjo wrote: > I don't really have experience with this API - is this pattern (creating and > closing event objects for each poll run) the common way of using this API? Is > there any potential performanc

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

labath added a comment. Seems reasonable, but could use a test case, though I'm not sure what would be the best way to approach that. I suppose one could dump the index of one of these dwo-less files, and then make sure it's contents are right (empty?). The m_dwo_id change also looks like its f

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3709742 , @aaron.ballman wrote: > One thing I think would be a definite improvement is to have done an RFC on > Discourse for these changes so that downstreams have a chance to weigh in on > the impact. The patch was

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

labath added a comment. In D131212#3708426 , @trevorj wrote: >> It does not. You _can_ connect to a remote server if you want to, but you >> don't have to. Many workflows need to select a remote platform to let LLDB >> know how to locate files when doin

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer added a comment. > Cool! There is one thread talking about the RISCV ABI support: > https://reviews.llvm.org/D62732. I tried that ABI in the RISCV file but it > seems like the same issue happened as yours, the breakpoint cannot be > stopped, and the lldb-server cannot show the reasonable

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

labath added a comment. I haven't been able to keep up with all the lldb happenings lately, so it's possible I have missed something, but can you give a summary (or point me to one) of what is the problem with abi tags in lldb. For example, why isn't the DW_AT_linkage_name string sufficient to

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

Emmmer updated this revision to Diff 451140. Emmmer retitled this revision from "[LLDB][RISCV] Add Register Info and Context" to "[LLDB][RISCV] Add register stuff and make breakpoint work". Emmmer edited the summary of this revision. Emmmer added a subscriber: tzb99. Emmmer added a comment. What

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706424 , @aaron.ballman wrote: > In D130689#3706377 , @thieta wrote: > >> In D130689#3706336 , >> @aaron.ballman wrote: >> >>>

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

labath accepted this revision. labath added inline comments. Comment at: lldb/include/lldb/DataFormatters/FormatClasses.h:50 + struct Flags { +bool m_stripped_pointer = false; +bool m_stripped_reference = false; We don't generally use the `m_` prefix on

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

labath accepted this revision. labath added a reviewer: shafik. labath added a comment. Good catch. Lldb should try to be useful even if the debugged program invokes undefined behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ htt

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > thieta wrote: > > g

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

glandium added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) thieta wrote: > glandium wrote: > >

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > You didn't update l

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

glandium added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) You didn't update llvm/cmake/platfo

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

DavidSpickett added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:63-68 - if(NOT LLDB_USE_SYSTEM_SIX) -add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM - COMMAND ${CMAKE_COMMAND} -E copy -"${LLDB_SOURCE_DIR}/third_party/Python/modu

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

DavidSpickett updated this revision to Diff 451067. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 Files: lldb/test

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

DavidSpickett added a comment. https://reviews.llvm.org/D131472 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131460/new/ https://reviews.llvm.org/D131460 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 1438639a2f7eb9e9cba01454d3a9b1b16d179c9a

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

DavidSpickett added a comment. Just looking at the test I think the main thing this removes is checking that we can show an enum as a combination of more than one value plus some extra number (invalid_scoped_enum_val is only one valid name plus extra). Thanks for bringing this to our attention.

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, a nice improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131459/new/ https://reviews.llvm.org/D131459

[Lldb-commits] [lldb] 5146f84 - LLVM_NODISCARD => [[nodiscard]]. NFC

Author: Fangrui Song Date: 2022-08-09T07:16:34Z New Revision: 5146f84fd616084fb63025a3e8a172179137b1ce URL: https://github.com/llvm/llvm-project/commit/5146f84fd616084fb63025a3e8a172179137b1ce DIFF: https://github.com/llvm/llvm-project/commit/5146f84fd616084fb63025a3e8a172179137b1ce.diff LOG: