[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Remove 'process_path' parsing logic

[Med Ismail Bennani via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG13aa780f37e1: [lldb/crashlog] Remove 
'process_path' parsing logic (authored by mib).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131033/new/

https://reviews.llvm.org/D131033

Files:
  lldb/examples/python/crashlog.py
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test


Index: lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test
===================================================================
--- lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test
+++ lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test
@@ -7,12 +7,11 @@
 
 parser = crashlog.JSONCrashLogParser("", "", False)
 
-process_info_json = json.loads('{"pid" : 287, "procName" : "mediaserverd", 
"procPath" : "\/usr\/sbin\/mediaserverd"}')
+process_info_json = json.loads('{"pid" : 287, "procName" : "mediaserverd"}')
 parser.parse_process_info(process_info_json)
 
 assert parser.crashlog.process_id == 287
 assert parser.crashlog.process_identifier == "mediaserverd"
-assert parser.crashlog.process_path == "/usr/sbin/mediaserverd"
 
 crash_reason_json = json.loads('{"type" : "EXC_BAD_ACCESS", "signal" : 
"SIGSEGV", "subtype" : "KERN_INVALID_ADDRESS"}')
 assert parser.parse_crash_reason(crash_reason_json) == "EXC_BAD_ACCESS 
(SIGSEGV) (KERN_INVALID_ADDRESS)"
Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -471,7 +471,6 @@
     def parse_process_info(self, json_data):
         self.crashlog.process_id = json_data['pid']
         self.crashlog.process_identifier = json_data['procName']
-        self.crashlog.process_path = json_data['procPath']
 
     def parse_crash_reason(self, json_exception):
         exception_type = json_exception['type']
@@ -670,8 +669,6 @@
             (self.crashlog.process_name, pid_with_brackets) = line[
                 8:].strip().split(' [')
             self.crashlog.process_id = pid_with_brackets.strip('[]')
-        elif line.startswith('Path:'):
-            self.crashlog.process_path = line[5:].strip()
         elif line.startswith('Identifier:'):
             self.crashlog.process_identifier = line[11:].strip()
         elif line.startswith('Version:'):



Index: lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test
===================================================================
--- lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test
+++ lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test
@@ -7,12 +7,11 @@
 
 parser = crashlog.JSONCrashLogParser("", "", False)
 
-process_info_json = json.loads('{"pid" : 287, "procName" : "mediaserverd", "procPath" : "\/usr\/sbin\/mediaserverd"}')
+process_info_json = json.loads('{"pid" : 287, "procName" : "mediaserverd"}')
 parser.parse_process_info(process_info_json)
 
 assert parser.crashlog.process_id == 287
 assert parser.crashlog.process_identifier == "mediaserverd"
-assert parser.crashlog.process_path == "/usr/sbin/mediaserverd"
 
 crash_reason_json = json.loads('{"type" : "EXC_BAD_ACCESS", "signal" : "SIGSEGV", "subtype" : "KERN_INVALID_ADDRESS"}')
 assert parser.parse_crash_reason(crash_reason_json) == "EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS)"
Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -471,7 +471,6 @@
     def parse_process_info(self, json_data):
         self.crashlog.process_id = json_data['pid']
         self.crashlog.process_identifier = json_data['procName']
-        self.crashlog.process_path = json_data['procPath']
 
     def parse_crash_reason(self, json_exception):
         exception_type = json_exception['type']
@@ -670,8 +669,6 @@
             (self.crashlog.process_name, pid_with_brackets) = line[
                 8:].strip().split(' [')
             self.crashlog.process_id = pid_with_brackets.strip('[]')
-        elif line.startswith('Path:'):
-            self.crashlog.process_path = line[5:].strip()
         elif line.startswith('Identifier:'):
             self.crashlog.process_identifier = line[11:].strip()
         elif line.startswith('Version:'):

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits