[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. To be honest, I'm not sure if "event" is the best name for it. I get it's a WSA name but it's a bit non-obvious to outsiders (I mean, technically everything is an event). Not that I have a better name in mind. Comment at: lldb/include/lldb/Host/MainLoo

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

wallace updated this revision to Diff 450226. wallace added a comment. simplify this diff following @labath's advice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131081/new/ https://reviews.llvm.org/D131081 Files: lldb/source/Plugins/Process/Li

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

trevorj added a comment. @JDevlieghere Sure I can provide more context, let me know if you want me to clarify anything! I'm trying to debug production coredumps on a development machine using a sysroot folder tree that contains the required shared objects required. In gdb, I use this via `set

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

JDevlieghere added a comment. Hey Trevor, Thank you for your patch. Please[[ https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch | include as much context ]] as possible when uploading a patch. It makes it a lot easier for the reviewers to see the surrounding code. Could

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6fb744be7670: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema (authored by Walter Erquinigo

[Lldb-commits] [lldb] 6fb744b - [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

Author: Walter Erquinigo Date: 2022-08-04T17:15:08-07:00 New Revision: 6fb744be76704f075a4edc753916e0e475d10f20 URL: https://github.com/llvm/llvm-project/commit/6fb744be76704f075a4edc753916e0e475d10f20 DIFF: https://github.com/llvm/llvm-project/commit/6fb744be76704f075a4edc753916e0e475d10f20.di

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 450163. persona0220 added a comment. rebasing to the upstream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/in

[Lldb-commits] [lldb] 1d2a62a - Re-submit "[lldb] Filter DIEs based on qualified name where possible"

Author: Alex Langford Date: 2022-08-04T15:52:27-07:00 New Revision: 1d2a62afaf7561e331e2f3daf3937d14225b21bf URL: https://github.com/llvm/llvm-project/commit/1d2a62afaf7561e331e2f3daf3937d14225b21bf DIFF: https://github.com/llvm/llvm-project/commit/1d2a62afaf7561e331e2f3daf3937d14225b21bf.diff

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

trevorj created this revision. Herald added a project: All. trevorj requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Hi! We noticed recently that when using the host platform with an sdk sysroot set, modules are not resolved using a path p

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace accepted this revision. wallace added a comment. nice job! Now you just need to connect it with the collector :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 marked an inline comment as done. persona0220 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:104-108 std::vector tids; for (const JSONProcess &process : bundle_description.processes) for (const JSONThread &threa

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 450144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h lldb/source/Plugins/Trace/intel-

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:306 +- "processes" is provided if and only if "kernel" is not provided. +- If "kernel" is provided, then the "processes" section must be empty and the "cpus" section must b

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 450137. persona0220 marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/Tra

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. almost there! Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:104-108 std::vector tids; for (const JSONProcess &process : bundle_descrip

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM module the inline comment. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:27-29 if image not in self.lo

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. All right! Last call - I am going fix the spelling error and merge this tomorrow EU time unless someone objects. Thanks for all reviews so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 967df65 - Revert "[lldb] Filter DIEs based on qualified name where possible"

Author: Alex Langford Date: 2022-08-04T11:52:30-07:00 New Revision: 967df65a3610f98a3bc0ec0f2303641d7bad176c URL: https://github.com/llvm/llvm-project/commit/967df65a3610f98a3bc0ec0f2303641d7bad176c DIFF: https://github.com/llvm/llvm-project/commit/967df65a3610f98a3bc0ec0f2303641d7bad176c.diff

[Lldb-commits] [lldb] befa77e - [lldb] Filter DIEs based on qualified name where possible

Author: Alex Langford Date: 2022-08-04T11:18:08-07:00 New Revision: befa77e59a7760d8c4fdd177b234e4a59500f61c URL: https://github.com/llvm/llvm-project/commit/befa77e59a7760d8c4fdd177b234e4a59500f61c DIFF: https://github.com/llvm/llvm-project/commit/befa77e59a7760d8c4fdd177b234e4a59500f61c.diff

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rGbefa77e59a77: [lldb] Filter DIEs based on qualified name where possible (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129682/new/ h

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:28 if image not in self.loaded_images: +if image.uuid == uuid.UUID(int=0): +

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/Procfs.cpp:12 #include "lldb/Host/linux/Support.h" + #include "llvm/Support/MemoryBuffer.h" labath wrote: > btw, llvm does not generally put blank lines between include headers. > omi

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1198-1204 +option_parser.add_option( +'--skip-status', +'-s', +dest='skip_status', +action='store_true', +

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib updated this revision to Diff 450053. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/a.out.crash lldb/tes

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. In D130689#3696186 , @thieta wrote: > @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it > can be built with CXX_STANDARD=17 and OSX_DEPLOYMENT_TARGET=10.11. Thanks! We took this opportunity to bump our

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

tzb99 added a comment. In D128250#3698652 , @Emmmer wrote: >> Hello: >> >> Thank you so much for sharing the patch files. One thing I am still curious >> is what the ABISysv file you are using. Would you mind also sharing the >> remaining patches added

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:417 +class CrashLogParser(object): +"Base class and factory." +def __new__(cls, debugger, path, verbose, *args, **kwargs): JDevlieghere wrote: > This is not done (yet) CHA

[Lldb-commits] [lldb] b06da9c - Remove the check for eStateConnected in remote testing sessions.

Author: Jim Ingham Date: 2022-08-04T09:19:55-07:00 New Revision: b06da9c18390f84950e1d8f70ef2bb0efb433075 URL: https://github.com/llvm/llvm-project/commit/b06da9c18390f84950e1d8f70ef2bb0efb433075 DIFF: https://github.com/llvm/llvm-project/commit/b06da9c18390f84950e1d8f70ef2bb0efb433075.diff LO

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/ https://reviews.llvm.org/D124314 ___

[Lldb-commits] [PATCH] D131159: [WIP][lldb] Use WSAEventSelect for MainLoop polling

jingham added a comment. This is a WIP, presumably in the final version there won't be prominent #ifdef _WIN32 in a file in the "Host/common" directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131159/new/ https://reviews.llvm.org/D131159 __

[Lldb-commits] [lldb] bcf6ffb - Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

Author: Chelsea Cassanova Date: 2022-08-04T11:47:06-04:00 New Revision: bcf6ffb87ec67ba41daeaab905b2c57a50568aa0 URL: https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0 DIFF: https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0.d

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

labath added a comment. It's not clear to me why you're insisting on `call_once`, when c++ guarantees that the function-local statics will only be initialized once (atomically). And with the new version, we don't even need the lambda.. Comment at: lldb/source/Plugins/Process/

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

labath added a comment. Ok, I was able to concoct D131159 and D131160 this morning. They need some more cleanup, but I tried them on windows, and it worked. The general idea is to add a platform-neutral way to wait on "events

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath created this revision. labath added a reviewer: mgorny. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131160 Files: lldb/includ

[Lldb-commits] [PATCH] D131159: [WIP][lldb] Use WSAEventSelect for MainLoop polling

labath created this revision. labath added a reviewer: mgorny. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131159 Files: lldb/source

[Lldb-commits] [lldb] b8985ba - [lldb] Fix arm breakages from D130985

Author: Pavel Labath Date: 2022-08-04T13:55:35+02:00 New Revision: b8985ba0adb5fd881bb301fbc79370b86396e658 URL: https://github.com/llvm/llvm-project/commit/b8985ba0adb5fd881bb301fbc79370b86396e658 DIFF: https://github.com/llvm/llvm-project/commit/b8985ba0adb5fd881bb301fbc79370b86396e658.diff

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath added a comment. In D130985#3699095 , @omjavaid wrote: > This broke LLDB AArch64 buildbot: > https://lab.llvm.org/buildbot/#/builders/96/builds/27004 I see it. Looking now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

omjavaid added a comment. This broke LLDB AArch64 buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27004 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 __

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon added a comment. In D130939#3698800 , @DavidSpickett wrote: > Thanks for these fixes! I'll fix up the 0 packets sent behaviour when I find > some spare time. Sounds great. Thanks for the review and suggestions! Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

DavidSpickett added a comment. Thanks for these fixes! I'll fix up the 0 packets sent behaviour when I find some spare time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130939/new/ https://reviews.llvm.org/D130939 __