[Lldb-commits] [PATCH] D131159: [WIP][lldb] Use WSAEventSelect for MainLoop polling

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added a reviewer: mgorny.
Herald added a project: All.
labath requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131159

Files:
  lldb/source/Host/common/MainLoop.cpp


Index: lldb/source/Host/common/MainLoop.cpp
===================================================================
--- lldb/source/Host/common/MainLoop.cpp
+++ lldb/source/Host/common/MainLoop.cpp
@@ -69,6 +69,67 @@
 }
 #endif
 
+#ifdef _WIN32
+class MainLoop::RunImpl {
+public:
+  RunImpl(MainLoop &loop);
+  ~RunImpl();
+
+  Status Poll();
+
+  void ProcessEvents();
+
+private:
+  MainLoop &loop;
+  llvm::Optional<size_t> signaled_event;
+};
+
+MainLoop::RunImpl::RunImpl(MainLoop &loop) : loop(loop) {
+}
+
+MainLoop::RunImpl::~RunImpl() {
+}
+
+Status MainLoop::RunImpl::Poll() {
+  std::vector<WSAEVENT> read_events;
+  read_events.reserve(loop.m_read_fds.size());
+  for(auto &fd : loop.m_read_fds) {
+    WSAEVENT event = WSACreateEvent();
+    assert(event != WSA_INVALID_EVENT);
+
+    int result = WSAEventSelect(fd.first, event, FD_READ | FD_ACCEPT | 
FD_CLOSE);
+    assert(result == 0);
+
+    read_events.push_back(event);
+  }
+
+  DWORD result = WSAWaitForMultipleEvents(read_events.size(),
+      read_events.data(), FALSE, WSA_INFINITE, FALSE);
+
+  for(auto &fd : loop.m_read_fds) {
+    int result = WSAEventSelect(fd.first, WSA_INVALID_EVENT, 0);
+    assert(result == 0);
+  }
+
+  for (auto &event: read_events) {
+    BOOL result = WSACloseEvent(event);
+    assert(result == TRUE);
+  }
+
+  if (result >= WSA_WAIT_EVENT_0 && result < WSA_WAIT_EVENT_0 + 
read_events.size()) {
+    signaled_event = result - WSA_WAIT_EVENT_0;
+    return Status();
+  }
+  return Status("WSAWaitForMultipleEvents failed");
+}
+
+void MainLoop::RunImpl::ProcessEvents() {
+  assert(signaled_event);
+  auto &fd_info = *std::next(loop.m_read_fds.begin(), *signaled_event);
+
+  loop.ProcessReadObject(fd_info.first);
+}
+#else
 class MainLoop::RunImpl {
 public:
   RunImpl(MainLoop &loop);
@@ -254,6 +315,7 @@
   }
 }
 #endif
+#endif
 
 MainLoop::MainLoop() : m_terminate_request(false) {
 #if HAVE_SYS_EVENT_H



Index: lldb/source/Host/common/MainLoop.cpp
===================================================================
--- lldb/source/Host/common/MainLoop.cpp
+++ lldb/source/Host/common/MainLoop.cpp
@@ -69,6 +69,67 @@
 }
 #endif
 
+#ifdef _WIN32
+class MainLoop::RunImpl {
+public:
+  RunImpl(MainLoop &loop);
+  ~RunImpl();
+
+  Status Poll();
+
+  void ProcessEvents();
+
+private:
+  MainLoop &loop;
+  llvm::Optional<size_t> signaled_event;
+};
+
+MainLoop::RunImpl::RunImpl(MainLoop &loop) : loop(loop) {
+}
+
+MainLoop::RunImpl::~RunImpl() {
+}
+
+Status MainLoop::RunImpl::Poll() {
+  std::vector<WSAEVENT> read_events;
+  read_events.reserve(loop.m_read_fds.size());
+  for(auto &fd : loop.m_read_fds) {
+    WSAEVENT event = WSACreateEvent();
+    assert(event != WSA_INVALID_EVENT);
+
+    int result = WSAEventSelect(fd.first, event, FD_READ | FD_ACCEPT | FD_CLOSE);
+    assert(result == 0);
+
+    read_events.push_back(event);
+  }
+
+  DWORD result = WSAWaitForMultipleEvents(read_events.size(),
+      read_events.data(), FALSE, WSA_INFINITE, FALSE);
+
+  for(auto &fd : loop.m_read_fds) {
+    int result = WSAEventSelect(fd.first, WSA_INVALID_EVENT, 0);
+    assert(result == 0);
+  }
+
+  for (auto &event: read_events) {
+    BOOL result = WSACloseEvent(event);
+    assert(result == TRUE);
+  }
+
+  if (result >= WSA_WAIT_EVENT_0 && result < WSA_WAIT_EVENT_0 + read_events.size()) {
+    signaled_event = result - WSA_WAIT_EVENT_0;
+    return Status();
+  }
+  return Status("WSAWaitForMultipleEvents failed");
+}
+
+void MainLoop::RunImpl::ProcessEvents() {
+  assert(signaled_event);
+  auto &fd_info = *std::next(loop.m_read_fds.begin(), *signaled_event);
+
+  loop.ProcessReadObject(fd_info.first);
+}
+#else
 class MainLoop::RunImpl {
 public:
   RunImpl(MainLoop &loop);
@@ -254,6 +315,7 @@
   }
 }
 #endif
+#endif
 
 MainLoop::MainLoop() : m_terminate_request(false) {
 #if HAVE_SYS_EVENT_H

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits