[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

[Trevor Joynson via Phabricator via lldb-commits]

trevorj created this revision.
Herald added a project: All.
trevorj requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Hi!  We noticed recently that when using the host platform with an sdk sysroot 
set, modules are not resolved using a path prefixed by the set sysroot path.

If I'm just doing something wrong let me know too :)

Thanks!


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131212

Files:
  lldb/source/Target/Platform.cpp


Index: lldb/source/Target/Platform.cpp
===================================================================
--- lldb/source/Target/Platform.cpp
+++ lldb/source/Target/Platform.cpp
@@ -201,11 +201,6 @@
     const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
     const FileSpecList *module_search_paths_ptr,
     llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules, bool *did_create_ptr) {
-  if (IsHost())
-    return ModuleList::GetSharedModule(module_spec, module_sp,
-                                       module_search_paths_ptr, old_modules,
-                                       did_create_ptr, false);
-
   // Module resolver lambda.
   auto resolver = [&](const ModuleSpec &spec) {
     Status error(eErrorTypeGeneric);



Index: lldb/source/Target/Platform.cpp
===================================================================
--- lldb/source/Target/Platform.cpp
+++ lldb/source/Target/Platform.cpp
@@ -201,11 +201,6 @@
     const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
     const FileSpecList *module_search_paths_ptr,
     llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules, bool *did_create_ptr) {
-  if (IsHost())
-    return ModuleList::GetSharedModule(module_spec, module_sp,
-                                       module_search_paths_ptr, old_modules,
-                                       did_create_ptr, false);
-
   // Module resolver lambda.
   auto resolver = [&](const ModuleSpec &spec) {
     Status error(eErrorTypeGeneric);

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits