[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rtrieu added inline comments. Comment at: clang/lib/AST/QualTypeNames.cpp:455 + if (const auto *UT = QT->getAs()) { +return getFullyQualifiedType(UT->getUnderlyingType(), Ctx, + WithGlobalNsPrefix); Moving this down here means

[Lldb-commits] [PATCH] D130686: [LLDB][RISCV] Add DWARF Registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf47355864770: [LLDB][RISCV] Add DWARF Registers (authored by Emmmer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130686/new/ https://reviews.llvm.org/D13

[Lldb-commits] [lldb] f473558 - [LLDB][RISCV] Add DWARF Registers

Author: Emmmer Date: 2022-07-30T12:05:55+08:00 New Revision: f473558647705a042de9d5ec96c23a21f2005bb1 URL: https://github.com/llvm/llvm-project/commit/f473558647705a042de9d5ec96c23a21f2005bb1 DIFF: https://github.com/llvm/llvm-project/commit/f473558647705a042de9d5ec96c23a21f2005bb1.diff LOG: [

[Lldb-commits] [PATCH] D130795: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

shafik added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_x86.cpp:67 + return static_cast(size == 8 ? 0x2 : size - 1) + << (18 + 4 * wp_index); } So we know that `wp_index` is never greater than 11?

[Lldb-commits] [PATCH] D130813: Add ability for lldb to load binaries in a process/corefile given only a load address & no dynamic loader

jasonmolenda created this revision. jasonmolenda added reviewers: labath, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I'm adding support for a firmware type environment, with

[Lldb-commits] [PATCH] D130805: Support a new kernel section in LLDB’s trace bundle schema

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a new "kernel" section with following schema. "kernel": {

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 added a comment. @aprantl do you mean dumping this with `lldb-test`? I'm not seeing a way to do this. If you're thinking about `symbols` that reads the symbol file not the symbol table. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D130802: [LLDB][NFC] Fix memory/resource leak in FifoFiles

fixathon added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:53-54 Expected FifoFileIO::ReadJSON(std::chrono::milliseconds timeout) { // We use a pointer for this future, because otherwise its normal destructor // would wait for the getline to end, rend

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

aprantl added a comment. It sounds like it should be possible to test this with `lldb-test`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 ___ lldb-commits ma

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 created this revision. augusto2112 added reviewers: jingham, labath, aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It may be useful to search symbol table entries by mangled in

[Lldb-commits] [PATCH] D130802: [LLDB][NFC] Fix memory/resource leak in FifoFiles

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:53-54 Expected FifoFileIO::ReadJSON(std::chrono::milliseconds timeout) { // We use a pointer for this f

[Lldb-commits] [PATCH] D130802: [LLDB][NFC] Fix memory/resource leak in FifoFiles

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The original code is creating a future object on the hea

[Lldb-commits] [PATCH] D130795: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7c961cc6ba7: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] f7c961c - [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

Author: Slava Gurevich Date: 2022-07-29T13:31:17-07:00 New Revision: f7c961cc6ba71c9d1fb845807e31b3a278d13c2f URL: https://github.com/llvm/llvm-project/commit/f7c961cc6ba71c9d1fb845807e31b3a278d13c2f DIFF: https://github.com/llvm/llvm-project/commit/f7c961cc6ba71c9d1fb845807e31b3a278d13c2f.diff

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny updated this revision to Diff 448707. mgorny marked an inline comment as done. mgorny added a comment. Thanks for the suggestions. I have to admit I don't necessarily like the `InterruptRead()` approach but given that the alternative involves major changes to how we read packets, I suppos

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before, NativePDB uses scoped range as a workaround for value range, that causes problems (e.g. a variable's value can o

[Lldb-commits] [PATCH] D130795: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing potential int ov

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

Meinersbur added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); This file is imported from the upstream project (https://repo.or.cz/isl.git/blob/295cf91923295ca694e9e4

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. In D130689#3686760 , @h-vetinari wrote: > My point boils down to: "written using standard C++17 > code" does not sound at all like "core language, no stdlib", but very much > like "core+stdlib". We're allowing C++17 library

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

h-vetinari added a comment. My point boils down to: "written using standard C++17 code" does not sound at all like "core language, no stdlib", but very much like "core+stdlib". This is also the first time this split becomes relevant AFAIK, because for moving to C++14, the stdlib was ready basic

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686723 , @h-vetinari wrote: > I don't think the standard library can be called a vendor-specific extension, > and so I think this still could/should be made clearer (even though the > status links below would show up

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

h-vetinari added a comment. From the text you quoted: > LLVM subprojects are written using standard C++17 code and avoid unnecessary vendor-specific extensions. I don't think the standard library can be called a vendor-specific extension, and so I think this still could/should be made clearer

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686718 , @thieta wrote: > In D130689#3684399 , @h-vetinari > wrote: > >> It may be worth calling out that this is about C++17 core language and not >> the standard library? >>

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684399 , @h-vetinari wrote: > It may be worth calling out that this is about C++17 core language and not > the standard library? > > libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing > vari

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686397 , @thakis wrote: > It'd be nice if this was landed opt-in behind some cmake variable at first, > so that folks could try it out on their bots and see how well things work. You can already test this with `-DCMAK