shafik added inline comments.
================ Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_x86.cpp:67 + return static_cast<uint64_t>(size == 8 ? 0x2 : size - 1) + << (18 + 4 * wp_index); } ---------------- So we know that `wp_index` is never greater than 11? ================ Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_x86.cpp:77 // wp.: 3333222211110000xxxxxxEE33221100 return GetBothEnableBitMask(wp_index) | (0xF << (16 + 4 * wp_index)); } ---------------- You did not update `0xF` to `0xFULL` like you did the constants above. Was that on purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130795/new/ https://reviews.llvm.org/D130795 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
