[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 431597. llunak added a comment. Added documentation for StringMap::hash(), including an explicit comment saying that the implementation is not guaranteed to be stable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3532822 , @dblaikie wrote: > If we want a structure that can use a stable hash Not for D124704 . It doesn't make sense to require a stable hash algorithm for an internal cache file. Al

[Lldb-commits] [PATCH] D126267: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding

wallace created this revision. wallace added a reviewer: jj10306. Herald added subscribers: mgrang, mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Add the logic that parses all cpu context swi

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Target.h:1421 +protected: + struct DummySignalValues { +LazyBool pass = eLazyBoolCalculate; We should make UnixSignals::Signal a public class and then just save a std::vector of those insi

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces

JDevlieghere added a comment. Test? :-) Comment at: lldb/examples/python/crashlog.py:567-570 +frame_regex = re.compile(r'^([0-9]+)' r'\s'# id +r'+(.+?)'r'\s+' # img_name +r'(0x

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. For an exception crashlog, the thread backtracesaren't usually very helpful and instead, developper

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

jingham created this revision. jingham added reviewers: JDevlieghere, labath, chaoren, clayborg, kastiglione. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. One of the weaknesses of the signal handling

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

dblaikie added a comment. In D122974#3481269 , @llunak wrote: > In D122974#3480686 , @dblaikie > wrote: > >> In D122974#3424654 , @JDevlieghere >> wrote: >> >>> > > ...

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1d490319a9e: Fix lldb-vscode frame test failure (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126225/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] a1d4903 - Fix lldb-vscode frame test failure

Author: Jeffrey Tan Date: 2022-05-23T14:04:37-07:00 New Revision: a1d490319a9e2196786f6504e0c447ee0a1dad71 URL: https://github.com/llvm/llvm-project/commit/a1d490319a9e2196786f6504e0c447ee0a1dad71 DIFF: https://github.com/llvm/llvm-project/commit/a1d490319a9e2196786f6504e0c447ee0a1dad71.diff L

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

jgorbe created this revision. jgorbe added reviewers: labath, JDevlieghere. Herald added a subscriber: pengfei. Herald added a project: All. jgorbe requested review of this revision. Herald added a project: LLDB. I've noticed (what looked like) deadlocking behavior while running some Python code t

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Since this "optimized" value isn't part of the actual JSON schema for the stack frames, and since we aren't using it in the IDE, best to remove this until it is either in the protocol defi

[Lldb-commits] [PATCH] D126103: Remove `friend` classes from TypeCategoryMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0a61c2ce2af: Remove `friend` classes from TypeCategoryMap (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126103/new/ https://reviews.l

[Lldb-commits] [lldb] f0a61c2 - Remove `friend` classes from TypeCategoryMap

Author: Jorge Gorbe Moya Date: 2022-05-23T11:31:53-07:00 New Revision: f0a61c2ce2afec200967c59d45181c7a9fbe2c3f URL: https://github.com/llvm/llvm-project/commit/f0a61c2ce2afec200967c59d45181c7a9fbe2c3f DIFF: https://github.com/llvm/llvm-project/commit/f0a61c2ce2afec200967c59d45181c7a9fbe2c3f.di

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

This revision was automatically updated to reflect the committed changes. Closed by commit rG760298adc264: [lldb] Specify aguments of `image list` (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.l

[Lldb-commits] [lldb] 760298a - [lldb] Specify aguments of `image list`

Author: Dave Lee Date: 2022-05-23T11:00:48-07:00 New Revision: 760298adc264f9c1029d93ab38711c131e19a2f4 URL: https://github.com/llvm/llvm-project/commit/760298adc264f9c1029d93ab38711c131e19a2f4 DIFF: https://github.com/llvm/llvm-project/commit/760298adc264f9c1029d93ab38711c131e19a2f4.diff LOG:

[Lldb-commits] [PATCH] D126078: [lldb] Improve formatting of dlopen error messages (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0da230ff4439: [lldb] Improve formatting of dlopen error messages (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126078/new/

[Lldb-commits] [lldb] 0da230f - [lldb] Improve formatting of dlopen error messages (NFC)

Author: Dave Lee Date: 2022-05-23T10:57:40-07:00 New Revision: 0da230ff44399f74dc9bf05c8f212e7fc22079fa URL: https://github.com/llvm/llvm-project/commit/0da230ff44399f74dc9bf05c8f212e7fc22079fa DIFF: https://github.com/llvm/llvm-project/commit/0da230ff44399f74dc9bf05c8f212e7fc22079fa.diff LOG:

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added a comment. @DavidSpickett Thank you for the review! I hope that this 2nd version of the patch addresses your helpful comments! Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 ___

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw updated this revision to Diff 431427. hawkinsw added a comment. Updating based on DavidSpickett helpful feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 Files: lldb/test/API/functiona

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() hawkinsw

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() DavidSpic

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previous patch (https://reviews.llvm.org/D12601

[Lldb-commits] [lldb] 0fe220a - Show error message for optimized variables

Author: Jeffrey Tan Date: 2022-05-23T10:04:58-07:00 New Revision: 0fe220a33179723b7b366c2b398bac3c3b4216ec URL: https://github.com/llvm/llvm-project/commit/0fe220a33179723b7b366c2b398bac3c3b4216ec DIFF: https://github.com/llvm/llvm-project/commit/0fe220a33179723b7b366c2b398bac3c3b4216ec.diff L

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fe220a33179: Show error message for optimized variables (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c1f77e160a: Add [opt] suffix to optimized stack frame in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126013/new/ h

[Lldb-commits] [lldb] 46c1f77 - Add [opt] suffix to optimized stack frame in lldb-vscode

Author: Jeffrey Tan Date: 2022-05-23T10:03:13-07:00 New Revision: 46c1f77e160a63726e312c0550157ee451bacd46 URL: https://github.com/llvm/llvm-project/commit/46c1f77e160a63726e312c0550157ee451bacd46 DIFF: https://github.com/llvm/llvm-project/commit/46c1f77e160a63726e312c0550157ee451bacd46.diff L

[Lldb-commits] [lldb] c30a8c8 - [lldb] Fix should_skip_simulator_test decorator

Author: Jonas Devlieghere Date: 2022-05-23T09:33:51-07:00 New Revision: c30a8c80837608ccb190aecb84a723ca00dd87df URL: https://github.com/llvm/llvm-project/commit/c30a8c80837608ccb190aecb84a723ca00dd87df DIFF: https://github.com/llvm/llvm-project/commit/c30a8c80837608ccb190aecb84a723ca00dd87df.d

[Lldb-commits] [PATCH] D126217: [lldb] Improve TestAppleSimulatorOSType.py error message

JDevlieghere created this revision. JDevlieghere added reviewers: augusto2112, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Show a more informative error message when we fail to parse the simctl output. It was inspired by https://reviews.llvm.org/D109336 w

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() Davi

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address