yinghuitan created this revision.
yinghuitan added reviewers: clayborg, labath, jingham, kusmour, aadsm.
Herald added a project: All.
yinghuitan requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Previous patch (https://reviews.llvm.org/D126013) added a new "optimized"
attribute to DAP stack frame this caused some tests, like
lldb-vscode/coreFile/TestVSCode_coreFile.py
to fail because the tests explicitly check for all attributes.
To fix the test failure I decided to remove this attribute.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D126225
Files:
lldb/tools/lldb-vscode/JSONUtils.cpp
Index: lldb/tools/lldb-vscode/JSONUtils.cpp
===================================================================
--- lldb/tools/lldb-vscode/JSONUtils.cpp
+++ lldb/tools/lldb-vscode/JSONUtils.cpp
@@ -765,7 +765,6 @@
if (is_optimized)
frame_name += " [opt]";
EmplaceSafeString(object, "name", frame_name);
- object.try_emplace("optimized", is_optimized);
int64_t disasm_line = 0;
object.try_emplace("source", CreateSource(frame, disasm_line));
Index: lldb/tools/lldb-vscode/JSONUtils.cpp
===================================================================
--- lldb/tools/lldb-vscode/JSONUtils.cpp
+++ lldb/tools/lldb-vscode/JSONUtils.cpp
@@ -765,7 +765,6 @@
if (is_optimized)
frame_name += " [opt]";
EmplaceSafeString(object, "name", frame_name);
- object.try_emplace("optimized", is_optimized);
int64_t disasm_line = 0;
object.try_emplace("source", CreateSource(frame, disasm_line));
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
