[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2be791e32af3: Insert crashing stack frame when call to null func ptr (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] 2be791e - Insert crashing stack frame when call to null func ptr

Author: Jason Molenda Date: 2022-05-05T17:55:22-07:00 New Revision: 2be791e32af33b7ef735bb180a8a91ee501d0560 URL: https://github.com/llvm/llvm-project/commit/2be791e32af33b7ef735bb180a8a91ee501d0560 DIFF: https://github.com/llvm/llvm-project/commit/2be791e32af33b7ef735bb180a8a91ee501d0560.diff

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

jasonmolenda updated this revision to Diff 427501. jasonmolenda added a comment. update to incorporate dave's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125042/new/ https://reviews.llvm.org/D125042 Files: lldb/examples/python/cra

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. In D124731#3494609 , @jingham wrote: > This seems like a reasonable fallback, and the implementation looks fine. > You need to add a test case setting an address breakpoint in the executable > and making sure that works. Should

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

jasonmolenda added inline comments. Comment at: lldb/examples/python/crashlog.py:520 + +# on arm64 systems, if jump through a null function pointer, +# we end up at address 0 and the crash reporter unwinder kastiglione wrote: > (minor) I

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

mib accepted this revision. mib added a comment. LGTM! Thanks J! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125042/new/ https://reviews.llvm.org/D125042 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

mib added a comment. In D125042#3495488 , @mib wrote: > In D125042#3495479 , @jasonmolenda > wrote: > >> In D125042#3495475 , @JDevlieghere >> wrote: >> >>> Does that me

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks for fixing these, especially the `lr` technique! Comment at: lldb/examples/python/crashlog.py:520 + +# on arm64 systems, if jump through a null f

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

mib added a comment. In D125042#3495479 , @jasonmolenda wrote: > In D125042#3495475 , @JDevlieghere > wrote: > >> Does that mean that the interactive crashlogs (`crashlog -i`) do this >> correctly? > > I didn't

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

jasonmolenda added a comment. In D125042#3495475 , @JDevlieghere wrote: > Does that mean that the interactive crashlogs (`crashlog -i`) do this > correctly? I didn't look at that when I wrote the patch; asked @mib and it sounded like he was going to d

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

JDevlieghere added a comment. Does that mean that the interactive crashlogs (`crashlog -i`) do this correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125042/new/ https://reviews.llvm.org/D125042 _

[Lldb-commits] [PATCH] D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

wallace created this revision. wallace added a reviewer: jj10306. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. IntelPTCollector is very big and has 3 classes in it.

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda added inline comments. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:90 // check if m_current_pc is valid if (unwind_plan_sp->PlanValidAtAddress(m_current_pc)) { // yes - current offset can be used as is clayborg wrote: > Don't

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

clayborg added inline comments. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:90 // check if m_current_pc is valid if (unwind_plan_sp->PlanValidAtAddress(m_current_pc)) { // yes - current offset can be used as is Don't we want to subtract 1

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 427449. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utility/TraceGDBRemot

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

wallace updated this revision to Diff 427448. wallace added a comment. add better error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124962/new/ https://reviews.llvm.org/D124962 Files: lldb/include/lldb/Host/common/NativeProcessProtoco

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb6388e4a0050: Decr return pc mid-stack when picking UnwindPlan row (authored by jasonmolenda). Repository: rG LLVM Gith

[Lldb-commits] [lldb] b6388e4 - Decr return pc mid-stack when picking UnwindPlan row

Author: Jason Molenda Date: 2022-05-05T14:18:21-07:00 New Revision: b6388e4a0050fa248f774f5dacfa3e566e8daef1 URL: https://github.com/llvm/llvm-project/commit/b6388e4a0050fa248f774f5dacfa3e566e8daef1 DIFF: https://github.com/llvm/llvm-project/commit/b6388e4a0050fa248f774f5dacfa3e566e8daef1.diff

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

jasonmolenda created this revision. jasonmolenda added a reviewer: kastiglione. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. A common

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda updated this revision to Diff 427441. jasonmolenda added a comment. Accidentally included an unrelated change in the last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124957/new/ https://reviews.llvm.org/D124957 Files: lldb

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda added inline comments. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:642-643 m_full_unwind_plan_sp = GetFullUnwindPlanForFrame(); int valid_offset = -1; if (IsUnwindPlanValidForCurrentPC(m_full_unwind_plan_sp, valid_offset)) { + active_

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda updated this revision to Diff 427437. jasonmolenda added a comment. Update to address Greg's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124957/new/ https://reviews.llvm.org/D124957 Files: lldb/examples/python/crashlog.p

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

clayborg added inline comments. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:642-643 m_full_unwind_plan_sp = GetFullUnwindPlanForFrame(); int valid_offset = -1; if (IsUnwindPlanValidForCurrentPC(m_full_unwind_plan_sp, valid_offset)) { + active_row

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda added inline comments. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:642-643 m_full_unwind_plan_sp = GetFullUnwindPlanForFrame(); int valid_offset = -1; if (IsUnwindPlanValidForCurrentPC(m_full_unwind_plan_sp, valid_offset)) { + active_

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Inline comments point out where can can get rid of the second parameter to IsUnwindPlanValidForCurrentPC() as no one uses it anymore. Comment at: lldb/source/T

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3136f022b3: Fix debugserver translation check (authored by aperez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124814/new/ https://reviews.llvm.org/D12

[Lldb-commits] [lldb] eb3136f - Fix debugserver translation check

Author: Alexandre Perez Date: 2022-05-05T11:31:23-07:00 New Revision: eb3136f022b3e5061fe790e7886f4bb592d8a1d1 URL: https://github.com/llvm/llvm-project/commit/eb3136f022b3e5061fe790e7886f4bb592d8a1d1 DIFF: https://github.com/llvm/llvm-project/commit/eb3136f022b3e5061fe790e7886f4bb592d8a1d1.dif

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This seems like a reasonable fallback, and the implementation looks fine. You need to add a test case setting an address breakpoint in the executable and making sure that works. Sh

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Utility/ConstString.cpp:177-183 uint8_t hash(const llvm::StringRef &s) const { -uint32_t h = llvm::djbHash(s); +return ha

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. This looks reasonable to me, but I'm not sure if there's anything special about the executable module that would result in us doing the wrong thing. I'm sure Jim or Pavel will know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. (Followup from 40c13720a4b9

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGf416e57339bd: [lldb] Fix ppc64 detection in lldb (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D124760?vs=427119&id=427225#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] f416e57 - [lldb] Fix ppc64 detection in lldb

Author: serge-sans-paille Date: 2022-05-05T09:22:02+02:00 New Revision: f416e57339bd3315834e6c14d6476e63ccb363ff URL: https://github.com/llvm/llvm-project/commit/f416e57339bd3315834e6c14d6476e63ccb363ff DIFF: https://github.com/llvm/llvm-project/commit/f416e57339bd3315834e6c14d6476e63ccb363ff.d