hawkinsw added a comment. In D124731#3494609 <https://reviews.llvm.org/D124731#3494609>, @jingham wrote:
> This seems like a reasonable fallback, and the implementation looks fine. > You need to add a test case setting an address breakpoint in the executable > and making sure that works. Should be easy, set a line breakpoint in the > main executable, get the resolved address and set an address breakpoint with > that and make sure that breakpoint got a location. > You should also add some words to the "break set" command help saying that > this is the fallback behavior. Thank you for the feedback! I will make those changes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
