[Lldb-commits] [lldb] 990d0c7 - [lldb] Print diagnostic prefixes (error, warning) in color

Author: Jonas Devlieghere Date: 2022-04-12T20:28:29-07:00 New Revision: 990d0c71090836fb117e72c262d6d19b76f346cc URL: https://github.com/llvm/llvm-project/commit/990d0c71090836fb117e72c262d6d19b76f346cc DIFF: https://github.com/llvm/llvm-project/commit/990d0c71090836fb117e72c262d6d19b76f346cc.d

[Lldb-commits] [lldb] a3d69a1 - [lldb] Re-enable TestStepNoDebug.py on AS

Author: Jonas Devlieghere Date: 2022-04-12T20:28:29-07:00 New Revision: a3d69a193a638a3aadf365cd628d8212b3d0d7d3 URL: https://github.com/llvm/llvm-project/commit/a3d69a193a638a3aadf365cd628d8212b3d0d7d3 DIFF: https://github.com/llvm/llvm-project/commit/a3d69a193a638a3aadf365cd628d8212b3d0d7d3.d

[Lldb-commits] [PATCH] D104629: [lldb] Escape semicolons for all shells

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07a722c574d1: [lldb] Escape semicolons for all shells (authored by teemperor, committed by JDevlieghere). Herald added a subscriber: lldb-commits. He

[Lldb-commits] [lldb] 07a722c - [lldb] Escape semicolons for all shells

Author: Raphael Isemann Date: 2022-04-12T18:13:55-07:00 New Revision: 07a722c574d1260ea63f1c7b7eb235df19af8f69 URL: https://github.com/llvm/llvm-project/commit/07a722c574d1260ea63f1c7b7eb235df19af8f69 DIFF: https://github.com/llvm/llvm-project/commit/07a722c574d1260ea63f1c7b7eb235df19af8f69.dif

[Lldb-commits] [lldb] bdf3e7e - [trace][intelpt] Add task timer classes

Author: Walter Erquinigo Date: 2022-04-12T13:08:03-07:00 New Revision: bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9 URL: https://github.com/llvm/llvm-project/commit/bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9 DIFF: https://github.com/llvm/llvm-project/commit/bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9.di

[Lldb-commits] [lldb] 44103c9 - [trace][intelpt] Remove code smell when printing the raw trace size

Author: Walter Erquinigo Date: 2022-04-12T13:08:03-07:00 New Revision: 44103c96fa6b00e7824319de1b10ce26781e3852 URL: https://github.com/llvm/llvm-project/commit/44103c96fa6b00e7824319de1b10ce26781e3852 DIFF: https://github.com/llvm/llvm-project/commit/44103c96fa6b00e7824319de1b10ce26781e3852.di

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:243 + /// Total amount of time spent decoding. + std::chrono::milliseconds m_total_decoding_time{0}; }; jj10306 wrote: > nit: Do you need an explicit initialization?

[Lldb-commits] [lldb] a66ff23 - [lldb] Re-enable fixed on-device tests

Author: Jonas Devlieghere Date: 2022-04-12T11:39:25-07:00 New Revision: a66ff2316ea815fb17c47b4cef8194f4cf51b490 URL: https://github.com/llvm/llvm-project/commit/a66ff2316ea815fb17c47b4cef8194f4cf51b490 DIFF: https://github.com/llvm/llvm-project/commit/a66ff2316ea815fb17c47b4cef8194f4cf51b490.d

[Lldb-commits] [PATCH] D123616: [debugserver ] Un-conditionalize use of libcompression

JDevlieghere updated this revision to Diff 422262. JDevlieghere retitled this revision from "[debugserver] Add HAVE_LIBCOMPRESSION guards" to "[debugserver ] Un-conditionalize use of libcompression". JDevlieghere edited the summary of this revision. Herald added a subscriber: mgorny. CHANGES SINC

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

jasonmolenda added a comment. Sounds good. I think it's test-and-use for lldb, and debugserver ended up structure the same way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123616/new/ https://reviews.llvm.org/D123616 ___ lldb-commits maili

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

JDevlieghere added a comment. That also works for me, but then let's remove the corresponding logic in CMake as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123616/new/ https://reviews.llvm.org/D123616 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

jasonmolenda added a comment. fwiw, commit 681f6c2f552fb9b57380f4bfd453e1fc9b6a099e Author: Jason Molenda Date: Tue Dec 18 22:21:48 2018 + Un-conditionalize use of libcompression. debugserver only builds on Darwin systems and libcompression has been in the OS for over

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I think we only support building debugserver on macOS systems that have libcompression. Was there a configuration where this resulted in an error? lldb needs to test for libcompr

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. The current debugserver CMake allows it to be built with or without libcompression. It conditionally links against libcompression if it's a

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:243 + /// Total amount of time spent decoding. + std::chrono::milliseconds m_total_decoding_time{0}; }; nit: Do you need an explicit initialization? ===

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Thanks for clarifying. The friendship declaration in SymbolFile is required not only for `SetCompileUnitAtIndex` but also for other protected virtual methods in `SymbolFile` like `CalculateNumCompileUnits` and `ParseCompileUnitAtIndex` which are pure virtual and requ

[Lldb-commits] [lldb] 4542841 - [lldb] Adjust libc++ string formatter for changes in D122598

Author: Pavel Labath Date: 2022-04-12T15:44:16+02:00 New Revision: 45428412fd7c9900d3d6ac9803aa7dcf6adfa6fe URL: https://github.com/llvm/llvm-project/commit/45428412fd7c9900d3d6ac9803aa7dcf6adfa6fe DIFF: https://github.com/llvm/llvm-project/commit/45428412fd7c9900d3d6ac9803aa7dcf6adfa6fe.diff

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rG0231a90bc438: [lldb][AArch64] Automatically add all extensions to disassembler (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] 0231a90 - [lldb][AArch64] Automatically add all extensions to disassembler

Author: David Spickett Date: 2022-04-12T12:31:43Z New Revision: 0231a90bc438f728c81087520d8d5d85101ed05b URL: https://github.com/llvm/llvm-project/commit/0231a90bc438f728c81087520d8d5d85101ed05b DIFF: https://github.com/llvm/llvm-project/commit/0231a90bc438f728c81087520d8d5d85101ed05b.diff LOG

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

DavidSpickett updated this revision to Diff 422191. DavidSpickett added a comment. Use llvm::join. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123582/new/ https://reviews.llvm.org/D123582 Files: lldb/source/Plugins/Disassembler/LLVMC/Disassemb

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is great. Thanks for doing that. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1190 +features_str += +std::accumulate(features.beg

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Interpreter/Options.cpp:457 - if (!options.empty()) { -// We have some required options with no arguments + if (required_options.size()) { str

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett updated this revision to Diff 422164. DavidSpickett added a comment. !empty instead of size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123502/new/ https://reviews.llvm.org/D123502 Files: lldb/source/Interpreter/Options.cpp Inde

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

DavidSpickett added a reviewer: labath. DavidSpickett added a subscriber: labath. DavidSpickett added a comment. @labath This addresses (most of) what you asked about in https://reviews.llvm.org/D121999. The architecture revision is still manual but given how lax llvm is about allowing any exten

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This means we don't have to remember to update this code as much. Thi

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. In D123020#3442738 , @llunak wrote: > Based on that 'introduce' comment I expect the part that you're not aware of > is that all 4 of those simple commits I pushed directly changed code that had > been written by me. So I still t

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added a comment. I am trying to get rid of the friendship declaration and the forwarding of protected methods. I have no issue with making `GetCompileUnitAtIndex` virtual -- that is pretty much a necessity for this feature (*). However, `SetCompileUnitAtIndex` seems like an internal impl

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping @dblaikie ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists