labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is great. Thanks for doing that.
================
Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1190
+ features_str +=
+ std::accumulate(features.begin(), features.end(), features_str,
+ [](std::string features, llvm::StringRef feature) {
----------------
If you use `features_str` as the initial accumulator value, then I'd expect you
shouldn't need to use += on the line above. Otherwise, you'd get the `+v9.3a`
bit twice.
But I'd just say `features_str += llvm::join(features, ",");` instead...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123582/new/
https://reviews.llvm.org/D123582
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
