[Lldb-commits] [lldb] ca68038 - Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON""

Author: Fangrui Song Date: 2022-04-08T23:40:18-07:00 New Revision: ca68038d12a23fa7ebb2b1ccbda93c321635e6bf URL: https://github.com/llvm/llvm-project/commit/ca68038d12a23fa7ebb2b1ccbda93c321635e6bf DIFF: https://github.com/llvm/llvm-project/commit/ca68038d12a23fa7ebb2b1ccbda93c321635e6bf.diff

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

JDevlieghere closed this revision. JDevlieghere added a comment. Closed by 833882b32701ce3713c9dd9afdedf1126db691f0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123421/new/ htt

[Lldb-commits] [lldb] 833882b - Adapt the ObjC stepping algorithm to deal with "selector-stubs" in clang.

Author: Jim Ingham Date: 2022-04-08T17:45:16-07:00 New Revision: 833882b32701ce3713c9dd9afdedf1126db691f0 URL: https://github.com/llvm/llvm-project/commit/833882b32701ce3713c9dd9afdedf1126db691f0 DIFF: https://github.com/llvm/llvm-project/commit/833882b32701ce3713c9dd9afdedf1126db691f0.diff LO

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jim. This LGTM. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:637-643 // Also we will use the

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

jingham marked 6 inline comments as done. jingham added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:1012-1015 +if (log) { + LLDB_LOG(log, "Resolving call for class - {0} and selector - {1}

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

jingham added a comment. I also made one functional change. Some code was checking `!m_lookup_implementation_function_code.empty()` to see if we had found an implementation function. That won't work if I put the common prefix into this ivar in the constructor, so I change that to leave the mem

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

jingham updated this revision to Diff 421651. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123421/new/ https://reviews.llvm.org/D123421 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCR

[Lldb-commits] [lldb] 0bc9372 - Skip test on earlier clang versions

Author: Adrian Prantl Date: 2022-04-08T15:40:57-07:00 New Revision: 0bc9372fa74ad0cd4789b4485bade86570909718 URL: https://github.com/llvm/llvm-project/commit/0bc9372fa74ad0cd4789b4485bade86570909718 DIFF: https://github.com/llvm/llvm-project/commit/0bc9372fa74ad0cd4789b4485bade86570909718.diff

[Lldb-commits] [PATCH] D123426: [lldb] Don't report progress in the REPL

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Don't report progress events in the REPL. Most of the progress events are very debugger specific which are very useful when you're debugging, but

[Lldb-commits] [lldb] de2ddc8 - [lldb] XFAIL tests that aren't passing remotely

Author: Jonas Devlieghere Date: 2022-04-08T15:02:26-07:00 New Revision: de2ddc8f3146bd87152ea86b533541039541efe1 URL: https://github.com/llvm/llvm-project/commit/de2ddc8f3146bd87152ea86b533541039541efe1 DIFF: https://github.com/llvm/llvm-project/commit/de2ddc8f3146bd87152ea86b533541039541efe1.d

[Lldb-commits] [lldb] 065e3c9 - [lldb] Skip more tests that don't make sense to run remotely

Author: Jonas Devlieghere Date: 2022-04-08T15:02:22-07:00 New Revision: 065e3c9a8e55aacf06eb069d8916597ce13b36b5 URL: https://github.com/llvm/llvm-project/commit/065e3c9a8e55aacf06eb069d8916597ce13b36b5 DIFF: https://github.com/llvm/llvm-project/commit/065e3c9a8e55aacf06eb069d8916597ce13b36b5.d

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:52-53 +return_struct.impl_addr = +class_getMethodImplementation_stret (return_struct.class_addr, +

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

jingham updated this revision to Diff 421638. jingham added a comment. -U on the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123421/new/ https://reviews.llvm.org/D123421 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRunt

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Clang is adding a feature to ObjC code generation, where instead of calling objc_msg

[Lldb-commits] [PATCH] D123415: [lldb] Fix crash when a type has no definition

siggi-alpheus created this revision. siggi-alpheus added reviewers: labath, jasonmolenda. siggi-alpheus added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. siggi-alpheus requested review of this revision. Herald added a subscriber: lldb-commits. See issue 5

[Lldb-commits] [lldb] 66b829a - [lldb] Skip a bunch of tests that shouldn't run remotely

Author: Jonas Devlieghere Date: 2022-04-08T10:46:34-07:00 New Revision: 66b829ac7b6864f4546771668739d80fa34a7e17 URL: https://github.com/llvm/llvm-project/commit/66b829ac7b6864f4546771668739d80fa34a7e17 DIFF: https://github.com/llvm/llvm-project/commit/66b829ac7b6864f4546771668739d80fa34a7e17.d

[Lldb-commits] [lldb] 257f984 - [lldb] Fix TestQuoting when run remotely

Author: Jonas Devlieghere Date: 2022-04-08T10:46:34-07:00 New Revision: 257f98466222c1fba3d3f6c0afa5e93793d14109 URL: https://github.com/llvm/llvm-project/commit/257f98466222c1fba3d3f6c0afa5e93793d14109 DIFF: https://github.com/llvm/llvm-project/commit/257f98466222c1fba3d3f6c0afa5e93793d14109.d

[Lldb-commits] [lldb] af2ea18 - [lldb] Import Foundation in TestConflictingDefinition.py

Author: Jonas Devlieghere Date: 2022-04-08T10:46:34-07:00 New Revision: af2ea183f5e3301406724bba116a7e200f108b79 URL: https://github.com/llvm/llvm-project/commit/af2ea183f5e3301406724bba116a7e200f108b79 DIFF: https://github.com/llvm/llvm-project/commit/af2ea183f5e3301406724bba116a7e200f108b79.d

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

JDevlieghere added a comment. In D123401#3439560 , @labath wrote: > I think this is actually a wider problem. I also ran into this recently (with > triples), but didn't have time to create a patch yet. I don't think that > `None` as the "actual" value

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

labath added a comment. I think this is actually a wider problem. I also ran into this recently (with triples), but didn't have time to create a patch yet. I don't think that `None` as the "actual" value should ever be considered a match (except when the pattern is `None`, I guess), regardless

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Good catch! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123401/new/ https://reviews.llvm.org/D123401 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. Currently a NO_DEBUG_INFO_TESTCASE will return None as it's debug info type, causing the decorator to consider it a match. If such a test case

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett planned changes to this revision. DavidSpickett added a comment. Cool. I will apply this to existing code first, in another change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 __

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

omjavaid added a comment. Thanks for good detailed explanation. I think from the code readability point of view, we may use FixAddress function which i believe already exists in ABI and if not then introduce FixAnyAddress may be. We can put all the comments about PAC/TBI code vs data address bi

[Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size

jj10306 added a comment. Looks good. Any reason not to have `GetRawTraceSize()` at the `Trace` interface level instead of being specific to `TraceIntelPT`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123358/new/ https://reviews.llvm.org/D123358

[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

zrthxn added a comment. Example of improvement in memory usage thread #1: tid = 42805 Raw trace size: 4096 KiB Total number of instructions: 94 Total approximate memory usage: 4394.58 KiB Average memory usage per instruction: 5.00 bytes where previously the same trace took

[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Grouping instructions with the same high 48 bits and storing prefixes. Simple looku

[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

labath added a comment. The reason for the funny `/*override*/` thingy in the mock classes is that it is impossible (in the gmock version that we use) to add the override keyword to the methods overridden by the MOCK macros. Then, having override keywords on hand-written methods triggered `-Win