omjavaid added a comment.

Thanks for good detailed explanation. I think from the code readability point 
of view, we may use FixAddress function which i believe already exists in ABI 
and if not then introduce FixAnyAddress may be. We can put all the comments 
about PAC/TBI code vs data address bits there in AArch64 ABI code instead of 
putting a comment about code/data address everytime we use FixDataAddress in 
generic code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118794/new/

https://reviews.llvm.org/D118794

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to