[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

yrouban added a comment. Sorry, I have a typo in diff number. My commit relates to https://reviews.llvm.org/D81449. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81499/new/ https://reviews.llvm.org/D81499 _

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. looks good thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 __

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. LGTM Thanks! for your patience Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112824/new/ https://reviews.llvm.org/D112824 _

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

nickdesaulniers added a comment. In D117928#3264795 , @labath wrote: > If this is a problem with PTRACE_SETREGSET(NT_FPREGSET), then we might be > able to work around it by using PTRACE_POKEUSER instead. But it'd definitely > be good to confirm this, so

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 ___ lldb-commits maili

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

jingham added a comment. In D117707#3270323 , @mgorny wrote: > Remove the unnecessary API part. In the end, you will want some SB API exposing this information so users can do something with it. I think returning the SBValue for the Thread is the right

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

mgorny updated this revision to Diff 402992. mgorny added a comment. Update following changes in `GetSiginfoType()` — notably stop relying on the `SBPlatform` API and update for new prototype. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118055/new/ https://reviews.llvm.org/D118055 F

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402991. mgorny added a comment. Remove the unnecessary API part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/include/lldb/Target/Platform.h lldb/source/Plugins/Platform/FreeBSD/PlatformF

[Lldb-commits] [lldb] 2a1b7aa - [lldb] Fix ProcessKDPLog for the logging refactor

Author: Pavel Labath Date: 2022-01-25T20:51:19+01:00 New Revision: 2a1b7aa016c0f4b5598806205bdfbab1ea2d92c4 URL: https://github.com/llvm/llvm-project/commit/2a1b7aa016c0f4b5598806205bdfbab1ea2d92c4 DIFF: https://github.com/llvm/llvm-project/commit/2a1b7aa016c0f4b5598806205bdfbab1ea2d92c4.diff

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny added a comment. Hmm, I think I've exposed it via SBPlatform because originally I planned on writing the tests in Python. However, it ended up being tested through unittests after all, so I think I can remove that part. Lemme try. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402979. mgorny marked an inline comment as done. mgorny added a comment. Implemented the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i ll

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:672 + + assert(target_sp); + return SBType(); labath wrote: > ?? Sorry, debug leftover ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

jingham added a comment. In D117707#3269214 , @labath wrote: > Adding Alex for the plugin dependency aspect. I don't think this dep is wrong > (it's pretty hard to pretend we don't at least have a C language), but he may > want to say something about th

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

jingham added a comment. The GetSiginfoType API seems awkward to me. It requires I get the data itself from some other source and then cast it to this type myself. I'm assuming in the fullness of time, there will be a GetSiginfoData call, and then I have to put the two together? The only rea

[Lldb-commits] [lldb] c2cd7cc - [lldb] Only include mach headers on Darwin

Author: Jonas Devlieghere Date: 2022-01-25T09:58:47-08:00 New Revision: c2cd7cc63c5084cea943a7cfa7e1d7e5c62a34b2 URL: https://github.com/llvm/llvm-project/commit/c2cd7cc63c5084cea943a7cfa7e1d7e5c62a34b2 DIFF: https://github.com/llvm/llvm-project/commit/c2cd7cc63c5084cea943a7cfa7e1d7e5c62a34b2.d

[Lldb-commits] [lldb] d7e183b - [lldb] Use new dyld SPIs to query the shared cache local symbols

Author: Jonas Devlieghere Date: 2022-01-25T09:36:48-08:00 New Revision: d7e183b225ecddeef2a28a59c1addb8e1825ffc6 URL: https://github.com/llvm/llvm-project/commit/d7e183b225ecddeef2a28a59c1addb8e1825ffc6 DIFF: https://github.com/llvm/llvm-project/commit/d7e183b225ecddeef2a28a59c1addb8e1825ffc6.d

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

mgorny updated this revision to Diff 402933. mgorny added a comment. I've forgotten that the architecture is inferred from target here. Added i386 test for completeness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118055/new/ https://reviews.llvm.org/D118055 Files: lldb/bindings/i

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

mgorny updated this revision to Diff 402927. mgorny marked an inline comment as done. mgorny added a comment. Add a common test function. Document the raw data. Include trapno check on FreeBSD. That said, it just occurred to me that I need to add some packet indicating the architecture. CHANG

[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.

clayborg abandoned this revision. clayborg added a comment. Abandoning after discussing on the mailing list in lieu of Pavel's patch: https://reviews.llvm.org/D117490 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117382/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Alright, this is the last bit (except for D101070 which evidently caused the issues), looking good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c16647c3676: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D117639: [cmake] Make include(GNUInstallDirs) always below project(..)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf31ff1b29bc: [cmake] Make include(GNUInstallDirs) always below project(..) (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117639/n

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 402234. Ericson2314 added a comment. Trim down, now that many parts have been landed already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-ex

[Lldb-commits] [PATCH] D117639: [cmake] Make include(GNUInstallDirs) always below project(..)

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117639/new/ https://reviews.llvm.org/D117639 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D117639: [cmake] Make include(GNUInstallDirs) always below project(..)

beanz accepted this revision. beanz added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117639/new/ https://reviews.llvm.org/D117639 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D117639: [cmake] Make include(GNUInstallDirs) always below project(..)

arichardson accepted this revision. arichardson added a comment. This LGTM, but please wait for someone else to review before committing it. Comment at: lldb/CMakeLists.txt:21 +if(LLDB_BUILT_STANDALONE) include(LLDBStandalone) Could keep this in the first

[Lldb-commits] [PATCH] D117639: [cmake] Make include(GNUInstallDirs) always below project(..)

Ericson2314 updated this revision to Diff 401402. Ericson2314 edited the summary of this revision. Ericson2314 added a comment. Rebase after D117617 landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117639/new/

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

Ericson2314 added a comment. In D117639#3254065 , @arichardson wrote: > I believe `LLVM_LIBDIR_SUFFIX` was added as a workaround for not being able > to use GNUInstallDirs (which will automatically detect the right suffixed > e.g. for SuSE) in rG46fed3

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

Ericson2314 updated this revision to Diff 401103. Ericson2314 added a comment. Herald added subscribers: Sanitizers, JDevlieghere. Herald added a project: Sanitizers. Don't forget compiler-rt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117639/new/

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

Ericson2314 updated this revision to Diff 401296. Ericson2314 added a comment. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox,

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

arichardson added a comment. I can't see anywhere where the GNUInstallDirs variables are used before project(), so can't we just move the includes further down? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117639/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

arichardson added a comment. I believe `LLVM_LIBDIR_SUFFIX` was added as a workaround for not being able to use GNUInstallDirs (which will automatically detect the right suffixed e.g. for SuSE) in rG46fed3b475ddd92d02d9b72d0d77c5a939f132d1

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

arichardson added a comment. I see AddLLVM already includes GNUInstallDirs, can we add the LLVM_LIBDIR_SUFFIX check to that file and avoid including GNUInstallDirs explicitly in all the projects? The standalone builds will pull in GNUInstallDirs via AddLLVM, and the non-standalone builds should

[Lldb-commits] [PATCH] D117639: [cmake] Avoid warning or extra suffix for CMAKE_INSTALL_LIBDIR

Ericson2314 created this revision. Ericson2314 added reviewers: arichardson, compnerd, phosek, beanz. Herald added subscribers: libcxx-commits, mgorny. Herald added a reviewer: bollu. Herald added a reviewer: ldionne. Herald added projects: libunwind, Flang. Herald added a reviewer: libunwind. Eric

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

arichardson added inline comments. Comment at: llvm/CMakeLists.txt:5 +include(GNUInstallDirs) + arichardson wrote: > This seems to be causing the following warning for me: > > ``` > CMake Warning (dev) at > /opt/clion-2021.2/bin/cmake/linux/share/cmake-3.20/M

[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.

labath added a comment. D117490 is pretty much what I had in mind. It needs a bit of a cleanup, and doesn't actually change any interface (that'd be better done as a separate patch anyway), but all the major functionality is already there. Repository: rG L

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

arichardson added inline comments. Comment at: llvm/CMakeLists.txt:5 +include(GNUInstallDirs) + This seems to be causing the following warning for me: ``` CMake Warning (dev) at /opt/clion-2021.2/bin/cmake/linux/share/cmake-3.20/Modules/GNUInstallDirs.cmake:2

[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.

labath added a comment. It is definitely an improvement, but I can't help but wonder, since we're going to be touching every GetLog line with this, if we couldn't go even further. The various LLDB_LOG have helped a lot, but one of the things that still bothers me is the verbosity of the GetLog

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Found two more `include(GNUInstallDirs)` I should include which will hopefully fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. OK I split out D117417 , D117418 , D117419 , and D117420 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 400253. Ericson2314 added a comment. Try again, with more `include(GNUInstallDirs)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMake

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Will try to break up the pathc further for better troubleshooting, but keeping this open to track progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a678f807200: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.

JDevlieghere added a comment. Nice improvement! Comment at: lldb/include/lldb/Utility/LLDBLog.h:1 +//===-- Logging.h ---*- C++ -*-===// +// LLDBLog.h Comment at: lldb/include/lldb/Utility/LLDBLog.h

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

vitalybuka added a comment. It breaks multiple bots. https://lab.llvm.org/buildbot/#/builders/37/builds/9960 https://lab.llvm.org/buildbot/#/builders/77/builds/13245 https://lab.llvm.org/buildbot/#/builders/169/builds/5409 https://lab.llvm.org/buildbot/#/builders/105/builds/19941 Can you please f

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Sorry about that. I think the issue was just one more `include(GNUInstallDirs)` for compiler-rt for the standalone build, but I am going to bed so just reverted for now to try again later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGefeb50197091: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson231

[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.

clayborg created this revision. clayborg added reviewers: jingham, labath, JDevlieghere, wallace. Herald added subscribers: atanasyan, jrtc27, kbarton, sbc100, mgorny, nemanjai, sdardis, emaste. Herald added a reviewer: shafik. Herald added a reviewer: shafik. clayborg requested review of this rev

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:85 +set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}${CMAKE_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}") +set(POLLY_CONFIG_LIBRARY_DIRS "${POLLY_INSTALL_

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked 10 inline comments as done. Ericson2314 added a comment. The approval on this patch is quite old, but nothing much interesting has happened in it since then --- if anything, it has gotten more trivial as I created patches "under" it and landed them which cleared the way for th

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398857. Ericson2314 added a comment. Fix conflicts, one more thing for openmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399020. Ericson2314 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt clang-tools-extra/clang-doc/

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399883. Ericson2314 added a comment. Rebase after landing the polly change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399096. Ericson2314 added a comment. Retrigger CI now that deps are fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett updated this revision to Diff 402898. DavidSpickett added a comment. Since output of GetMemoryRegions will be sorted and not overlap, switch the checks to asserts and don't sort the input regions. Updated the testing to reflect that and added some comment diagrams showing what regio

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

labath added a reviewer: bulbazord. labath added a comment. Adding Alex for the plugin dependency aspect. I don't think this dep is wrong (it's pretty hard to pretend we don't at least have a C language), but he may want to say something about this. The patch itself is somewhat repetitive, but

[Lldb-commits] [lldb] 6b67e89 - [lldb] Fix windows build for D117490

Author: Pavel Labath Date: 2022-01-25T13:51:53+01:00 New Revision: 6b67e89b45c1e84a5ddac23f8c9c8c3961577bda URL: https://github.com/llvm/llvm-project/commit/6b67e89b45c1e84a5ddac23f8c9c8c3961577bda DIFF: https://github.com/llvm/llvm-project/commit/6b67e89b45c1e84a5ddac23f8c9c8c3961577bda.diff

[Lldb-commits] [lldb] 345d85e - [lldb] Fix mac build for D117490

Author: Pavel Labath Date: 2022-01-25T13:42:24+01:00 New Revision: 345d85e1240801999ed321eb13a39048a9aa1a06 URL: https://github.com/llvm/llvm-project/commit/345d85e1240801999ed321eb13a39048a9aa1a06 DIFF: https://github.com/llvm/llvm-project/commit/345d85e1240801999ed321eb13a39048a9aa1a06.diff

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

labath added a comment. I'm sorry. I should have that fixed right very quickly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

labath added a comment. Thanks for tracking this down. I'm looking forward to seeing how the kernel issue gets resolved. > In D117928#3266895 , @labath wrote: > >> If you want, I can try to create a patch for this, though it might take me a >> couple of

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

thakis added a comment. And even less on windows: http://45.33.8.238/win/53319/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits maili

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

thakis added a comment. And e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

thakis added a comment. Looks like this doesn't build on Mac: http://45.33.8.238/macm1/26315/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

labath added a comment. Seems reasonable to me. Jim, do you have any thoughts on this? Comment at: lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:494 + +def test_siginfo_linux(self): +class MyResponder(MockGDBServerResponder): --

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f08db66db93: [lldb] Make logging machinery type-safe (authored by labath). Changed prior to commit: https://reviews.llvm.org/D117490?vs=402636&id

[Lldb-commits] [lldb] ce69035 - [lldb/test] Use abspath when searching for lldb.exe

Author: Pavel Labath Date: 2022-01-25T12:13:49+01:00 New Revision: ce6903595b7161f881b62834c55b3099853cabd5 URL: https://github.com/llvm/llvm-project/commit/ce6903595b7161f881b62834c55b3099853cabd5 DIFF: https://github.com/llvm/llvm-project/commit/ce6903595b7161f881b62834c55b3099853cabd5.diff

[Lldb-commits] [lldb] 0f08db6 - [lldb] Make logging machinery type-safe

Author: Pavel Labath Date: 2022-01-25T12:13:49+01:00 New Revision: 0f08db66db93b42ff26caca2159bd548436184ae URL: https://github.com/llvm/llvm-project/commit/0f08db66db93b42ff26caca2159bd548436184ae DIFF: https://github.com/llvm/llvm-project/commit/0f08db66db93b42ff26caca2159bd548436184ae.diff