jingham added a comment.

The GetSiginfoType API seems awkward to me.  It requires I get the data itself 
from some other source and then cast it to this type myself.  I'm assuming in 
the fullness of time, there will be a GetSiginfoData call, and then I have to 
put the two together?  The only reason I can see to have separate "GetType" and 
"GetData" calls is if there's some useful way to get the data blob that doesn't 
go through lldb.

After all, if we had:

SBValue SBThread::GetSiginfoValue();

API you can still get the type and data back out of the SBValue if you needed 
them.   But I am pretty sure most uses will be to query the values of its child 
members, which makes the value returning API more convenient.

At the lldb_private layer, it's fine to separate the two, but when you go to 
present this to the outside world through commands or API's we try to keep the 
API set more compact.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117707/new/

https://reviews.llvm.org/D117707

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to