labath added a comment.

Seems reasonable to me. Jim, do you have any thoughts on this?



================
Comment at: 
lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:494
+
+    def test_siginfo_linux(self):
+        class MyResponder(MockGDBServerResponder):
----------------
I'd probably factor the out the common parts into a helper fn, as these two 
tests only differ in constants.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118055/new/

https://reviews.llvm.org/D118055

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to