[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

labath added a comment. In D111981#3071414 , @dblaikie wrote: > Oh, mostly my point was "the output changes after I explicitly run `ninja > cxx`" so it looks like the dependency didn't fully address the build > consistency issue, regardless of what the

[Lldb-commits] [lldb] 957a5e9 - [lldb] Fix nullptr dereference in AppleObjCRuntimeV2

Author: Jonas Devlieghere Date: 2021-10-18T23:30:31-07:00 New Revision: 957a5e987444d3193575d6ad8afe6c75da00d794 URL: https://github.com/llvm/llvm-project/commit/957a5e987444d3193575d6ad8afe6c75da00d794 DIFF: https://github.com/llvm/llvm-project/commit/957a5e987444d3193575d6ad8afe6c75da00d794.d

[Lldb-commits] [PATCH] D112045: [lldb/API] Fix SBLaunchInfo::SetScriptedProcessDictionary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112045/new/ https://reviews.llvm.org/D112045 ___

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the ScriptedProcess test to use a stack-only skinny corefile as a backing store. The corefile is saved as a

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the `ScriptedThread` initializer in couple of ways: - It replaces the `SBTarget` parameter by a `SBProcess`

[Lldb-commits] [PATCH] D112045: [lldb/API] Fix SBLaunchInfo::SetScriptedProcessDictionary

mib updated this revision to Diff 380560. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112045/new/ https://reviews.llvm.org/D112045 Files: lldb/source/API/SBLaunchInfo.cpp Index: lldb/source/API/SBLaunchInfo.cpp

[Lldb-commits] [PATCH] D112045: [lldb/API] Fix SBLaunchInfo::SetScriptedProcessDictionary

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. The previous implementation of `SBLaunchInfo::SetScriptedProcessDictionary` didn't actually parse the SBStructuredData's JSON an

[Lldb-commits] [PATCH] D112034: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112034/new/ https://reviews.llvm.org/D112034 ___ lldb-commits mailing list

[Lldb-commits] [lldb] f24532a - Follow-on to fix a test from c5011aed9c297d6ddd8ee4f77453b215aa27554a.

Author: Jim Ingham Date: 2021-10-18T16:53:32-07:00 New Revision: f24532ae91d540bcc2a6a5f29f89c8ea42907ef3 URL: https://github.com/llvm/llvm-project/commit/f24532ae91d540bcc2a6a5f29f89c8ea42907ef3 DIFF: https://github.com/llvm/llvm-project/commit/f24532ae91d540bcc2a6a5f29f89c8ea42907ef3.diff LO

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc5011aed9c29: Add a "command container" hierarchy to allow users to add container nodes. (authored by jingham). Changed p

[Lldb-commits] [lldb] c5011ae - Add a "command container" hierarchy to allow users to add container nodes.

Author: Jim Ingham Date: 2021-10-18T15:29:24-07:00 New Revision: c5011aed9c297d6ddd8ee4f77453b215aa27554a URL: https://github.com/llvm/llvm-project/commit/c5011aed9c297d6ddd8ee4f77453b215aa27554a DIFF: https://github.com/llvm/llvm-project/commit/c5011aed9c297d6ddd8ee4f77453b215aa27554a.diff LO

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111686/new/ https://reviews.llvm.org/D111686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

clayborg added a comment. I am ok with this. Jason Molenda or someone at Apple should probably give it the final stamp as I am no longer with Apple and don't have enough knowledge to say if this work around is still needed by older devices. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D112034: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12

vsk created this revision. vsk added reviewers: JDevlieghere, kastiglione, kledzik. vsk requested review of this revision. In macOS 12, dyld switched to using chained fixups. As a result, all symbols are bound at launch and there are no lazy pointers any more. Since we wish to import/dlopen() a dy

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

dblaikie added a comment. Yeah, applying that patch gets the expected `cannot open shared object file` issue for `libc++.so.1`: == FAIL: test_with_run_command_dwo (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

dblaikie added a comment. In D111981#3071378 , @teemperor wrote: > In D111981#3071349 , @dblaikie > wrote: > >> So this'll add the right test dependency, if the libcxx project is enabled >> in the build? (& if t

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

teemperor added a comment. In D111981#3071349 , @dblaikie wrote: > So this'll add the right test dependency, if the libcxx project is enabled in > the build? (& if the build hasn't enabled libcxx, the tests will run, but > against the system compiler -

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

dblaikie added a comment. So this'll add the right test dependency, if the libcxx project is enabled in the build? (& if the build hasn't enabled libcxx, the tests will run, but against the system compiler - and if that system compiler happens to default to libc++ ( https://github.com/llvm/llv

[Lldb-commits] [PATCH] D111963: [lldb] [lldb-server] Refactor ConnectToRemote()

This revision was automatically updated to reflect the committed changes. Closed by commit rGa229a4aa6418: [lldb] [lldb-server] Refactor ConnectToRemote() (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D111963?vs=380244&id=380504#toc Repos

[Lldb-commits] [lldb] a229a4a - [lldb] [lldb-server] Refactor ConnectToRemote()

Author: Michał Górny Date: 2021-10-18T22:05:01+02:00 New Revision: a229a4aa6418bf34678a32f368324ae2c47051b7 URL: https://github.com/llvm/llvm-project/commit/a229a4aa6418bf34678a32f368324ae2c47051b7 DIFF: https://github.com/llvm/llvm-project/commit/a229a4aa6418bf34678a32f368324ae2c47051b7.diff

[Lldb-commits] [lldb] 62293e7 - Revert "[lldb] [lldb-server] Refactor ConnectToRemote()"

Author: Michał Górny Date: 2021-10-18T22:04:36+02:00 New Revision: 62293e7d33ff0344b767ac66188981774c8b5197 URL: https://github.com/llvm/llvm-project/commit/62293e7d33ff0344b767ac66188981774c8b5197 DIFF: https://github.com/llvm/llvm-project/commit/62293e7d33ff0344b767ac66188981774c8b5197.diff

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

mgorny added a comment. In D111964#3069414 , @labath wrote: > What's the test strategy for this? Still thinking about it. I'm mostly PoC-ing this while other changes are waiting. >> This is not fully functional yet, as lldb-server >> crashes when attem

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

mgorny updated this revision to Diff 380502. mgorny retitled this revision from "[lldb] [lldb-server] Support listening on serial://" to "[lldb] [lldb-server] Allow any protocol supported by lldb". mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

rnk accepted this revision. rnk added a comment. lgtm This flag seems reasonable. Microsoft's UnDecorateName API has quite a few of these kinds of things: https://docs.microsoft.com/en-us/windows/win32/api/dbghelp/nf-dbghelp-undecoratesymbolname I don't think it makes sense to implement them al

[Lldb-commits] [PATCH] D111990: [lldb/test] Remove quote/unquote steps from the make invocations

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks for cleaning that up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111990/new/ https://reviews.llvm.org/D111990 _

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111981/new/ https://reviews.llvm.org/D111981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] 1ff367d - Fix Linux error in TestBreakInLoadedDylib.py.

Author: Jim Ingham Date: 2021-10-18T11:30:31-07:00 New Revision: 1ff367dbb02d90b3ef1c2de36b60b658aeeeac7e URL: https://github.com/llvm/llvm-project/commit/1ff367dbb02d90b3ef1c2de36b60b658aeeeac7e DIFF: https://github.com/llvm/llvm-project/commit/1ff367dbb02d90b3ef1c2de36b60b658aeeeac7e.diff LO

[Lldb-commits] [PATCH] D111920: Test untested variants of BreakpointCreateBySourceRegex

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a2e9c5db692: Add tests for the other variants of BreakpointCreateBySourceRegex. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111920/

[Lldb-commits] [lldb] 9a2e9c5 - Add tests for the other variants of BreakpointCreateBySourceRegex.

Author: Jim Ingham Date: 2021-10-18T10:59:04-07:00 New Revision: 9a2e9c5db692a010dd87a36907ba9d86bc54ac53 URL: https://github.com/llvm/llvm-project/commit/9a2e9c5db692a010dd87a36907ba9d86bc54ac53 DIFF: https://github.com/llvm/llvm-project/commit/9a2e9c5db692a010dd87a36907ba9d86bc54ac53.diff LO

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

jingham added a comment. In D111965#3069568 , @DavidSpickett wrote: > I've seen commands print that they are an alias automatically: > > (lldb) help rbreak > Sets a breakpoint or set of breakpoints in the executable. > > Syntax: rbreak > >

Re: [Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

If you have the breakpoint ID, you can find the SB Breakpoint and just ask it directly what it's hit count or location hit count are, and you don't have to scrub text output. Jim > On Oct 18, 2021, at 2:55 AM, Nikolay Chokoev via Phabricator > wrote: > > georgiev added a comment. > > What

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

mgorny updated this revision to Diff 380453. mgorny retitled this revision from "[lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm* [WIP]" to "[lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*". mgorny added a comment. Major refactoring of the generator function. C

[Lldb-commits] [lldb] 8568ca7 - Use llvm::erase_if (NFC)

Author: Kazu Hirata Date: 2021-10-18T09:33:42-07:00 New Revision: 8568ca789ec105ed96196d82c861116540433b89 URL: https://github.com/llvm/llvm-project/commit/8568ca789ec105ed96196d82c861116540433b89 DIFF: https://github.com/llvm/llvm-project/commit/8568ca789ec105ed96196d82c861116540433b89.diff L

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

lassefolger updated this revision to Diff 380435. lassefolger added a comment. rebased after NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://reviews.llvm.org/D111715 Files: lldb/source/Core/Mangled.cpp llvm/include/llvm/D

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG366fb539485a: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] 366fb53 - [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

Author: Raphael Isemann Date: 2021-10-18T15:59:34+02:00 New Revision: 366fb539485a9753e4a8167fe5140bf4fb00a098 URL: https://github.com/llvm/llvm-project/commit/366fb539485a9753e4a8167fe5140bf4fb00a098 DIFF: https://github.com/llvm/llvm-project/commit/366fb539485a9753e4a8167fe5140bf4fb00a098.dif

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

labath updated this revision to Diff 380372. labath added a comment. Adjust for TestStandardUnwind removal (the patch fixes it sufficiently to make it litter the source tree with build artifacts). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11198

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm* [WIP]

labath added a comment. I think I like this. Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:261 +assert(subreg->base_index); +uint32_t base_index = subreg->base_index.getValue(); +assert(base_index < regs.size()); llvm::Optional gives you this a

[Lldb-commits] [lldb] 1ef6bd9 - [lldb] Delete TestStandardUnwind

Author: Pavel Labath Date: 2021-10-18T15:22:10+02:00 New Revision: 1ef6bd9b1bffb3f0314840ad95cd554366fdbda7 URL: https://github.com/llvm/llvm-project/commit/1ef6bd9b1bffb3f0314840ad95cd554366fdbda7 DIFF: https://github.com/llvm/llvm-project/commit/1ef6bd9b1bffb3f0314840ad95cd554366fdbda7.diff

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm* [WIP]

mgorny updated this revision to Diff 380366. mgorny marked an inline comment as done. mgorny retitled this revision from "[lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*" to "[lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm* [WIP]". mgorny added a comment. WIP alt

[Lldb-commits] [PATCH] D111990: [lldb/test] Remove quote/unquote steps from the make invocations

labath created this revision. labath added reviewers: teemperor, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. None of the commands we run really rely on shell features. Running them with shell=False, simplifies the code as there is no need for elaborate quo

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

labath created this revision. labath added reviewers: teemperor, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. We had two sets of build methods, whose bodies were largely identical. This makes any kind of modification in their vicinity repetitive and error-p

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela requested changes to this revision. tammela added a comment. This revision now requires changes to proceed. @siger-young Are these still relevant to the code that was landed recently? For this one, please wait @JDevlieghere's review. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

mgorny marked an inline comment as done. mgorny added a comment. I'm not sure what exactly you're proposing and whether your proposal would work but I think it's a step in the right direction. Let's start by reiterating what we need: 1. A way to iterate over all subregisters of given `RegKind`,

[Lldb-commits] [lldb] b37efed - [lldb] Fix PDB/compilands.test for a3939e1

Author: Pavel Labath Date: 2021-10-18T14:11:47+02:00 New Revision: b37efed957ed0a0193d80020aefd55cb587dfc1f URL: https://github.com/llvm/llvm-project/commit/b37efed957ed0a0193d80020aefd55cb587dfc1f DIFF: https://github.com/llvm/llvm-project/commit/b37efed957ed0a0193d80020aefd55cb587dfc1f.diff

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

teemperor added a comment. In D111715#3068412 , @thakis wrote: > I don't have an opinion on this change and I don't mind the demangler change, > but isn't the type information helpful? The mangled itanium name doesn't > include type information which is

[Lldb-commits] [lldb] d8bc7e4 - [lldb] [lldb-server] Refactor ConnectToRemote()

Author: Michał Górny Date: 2021-10-18T12:17:43+02:00 New Revision: d8bc7e40ce1cdd8c1a3fac7937ce1ea85c262728 URL: https://github.com/llvm/llvm-project/commit/d8bc7e40ce1cdd8c1a3fac7937ce1ea85c262728 DIFF: https://github.com/llvm/llvm-project/commit/d8bc7e40ce1cdd8c1a3fac7937ce1ea85c262728.diff

[Lldb-commits] [lldb] ee691fb - [lldb][NFC] clang format change

Author: Lasse Folger Date: 2021-10-18T12:00:32+02:00 New Revision: ee691fbc3de36ca0c720e1699565be34f192e058 URL: https://github.com/llvm/llvm-project/commit/ee691fbc3de36ca0c720e1699565be34f192e058 DIFF: https://github.com/llvm/llvm-project/commit/ee691fbc3de36ca0c720e1699565be34f192e058.diff

[Lldb-commits] [PATCH] D111934: [NFC] clang format change

This revision was automatically updated to reflect the committed changes. Closed by commit rGee691fbc3de3: [lldb][NFC] clang format change (authored by lassefolger, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111934/new/ https

[Lldb-commits] [lldb] d914aa4 - [lldb] Fix SymbolFilePDBTests for a3939e1

Author: Pavel Labath Date: 2021-10-18T11:59:01+02:00 New Revision: d914aa4ead2aabda2c9e2cf343d30ba8171e4ce2 URL: https://github.com/llvm/llvm-project/commit/d914aa4ead2aabda2c9e2cf343d30ba8171e4ce2 DIFF: https://github.com/llvm/llvm-project/commit/d914aa4ead2aabda2c9e2cf343d30ba8171e4ce2.diff

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

georgiev added a comment. What about the case when we have a logical BP with more than one location? the locations may have different hit count. In particular we have a test like: patterns=[ "1\.1: .+ unresolved, hit count = 0 +Options: disabled", "1\.2: .+ resolved,( hardware,)? hit count =

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

mgorny updated this revision to Diff 380318. mgorny added a comment. Simplify the internal setting logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111890/new/ https://reviews.llvm.org/D111890 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/common/Terminal.cpp lldb/

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:21 public: + struct Data; + labath wrote: > Move this into the protected section If I do that, I can't use it from `TerminalState`. CHANGES SI

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

DavidSpickett added a comment. I've seen commands print that they are an alias automatically: (lldb) help rbreak Sets a breakpoint or set of breakpoints in the executable. Syntax: rbreak <...> 'rbreak' is an abbreviation for 'breakpoint set -r %1' Is this not the case for reg

[Lldb-commits] [PATCH] D111908: [lldb] [Utility] Remove Status::WasInterrupted() along with its only use

This revision was automatically updated to reflect the committed changes. Closed by commit rG239b4d62b6c0: [lldb] [Utility] Remove Status::WasInterrupted() along with its only use (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 239b4d6 - [lldb] [Utility] Remove Status::WasInterrupted() along with its only use

Author: Michał Górny Date: 2021-10-18T10:50:25+02:00 New Revision: 239b4d62b6c07f27b1763a090f82c9f92ce06b8c URL: https://github.com/llvm/llvm-project/commit/239b4d62b6c07f27b1763a090f82c9f92ce06b8c DIFF: https://github.com/llvm/llvm-project/commit/239b4d62b6c07f27b1763a090f82c9f92ce06b8c.diff

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko updated this revision to Diff 380298. serhiy.redko added a comment. - return error in case debug configuration contains incompatible fields with 'launchCommands'/'attachCommands' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94997/new/ https://reviews.llvm.org/D94997 File

[Lldb-commits] [PATCH] D111877: [lldb] Return StringRef from PluginInterface::GetPluginName

labath added a comment. I hope we don't have to go through this renaming any time soon. I think that any plugin that does not want to return a constant string here could just store it in a std::string internally. I actually found exactly one plugin (PlatformAppleSimulator) which does that alrea

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Support listening on serial://

labath added a comment. What's the test strategy for this? > This is not fully functional yet, as lldb-server > crashes when attempting to send long packets (e.g. target.xml contents). I am guessing you'll also want to disable QStartNoAckMode for these connections (?) Commen

[Lldb-commits] [PATCH] D111963: [lldb] [lldb-server] Refactor ConnectToRemote()

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:218 "(connection status: %d)\n", - connection_url, static_cast(connection_result

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

labath added a comment. This will create an lldb-server that crashes as soon as it tries to debug something. Maybe it would be better to disable the binary completely (in cmake) for unsupported architectures instead? Comment at: lldb/source/Plugins/Process/Linux/NativeRegiste

[Lldb-commits] [PATCH] D111908: [lldb] [Utility] Remove Status::WasInterrupted() along with its only use

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, random signals should cause a retry (they probably do already) and I think user interrupts should be handled differently (at a higher level). CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

labath added a comment. I like the solution with multiple value_regs. However, I am wondering if instead of the various piecemeal maps we couldn't just have one uber-map to rule them all. I'm imagining something like enum (class?) RegKind { GPR, FPR, XMM, ...}; struct RegData { size_t i