labath added a comment. I think I like this.
================ Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:261 + assert(subreg->base_index); + uint32_t base_index = subreg->base_index.getValue(); + assert(base_index < regs.size()); ---------------- llvm::Optional gives you this assert for free. ================ Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:321 + llvm::SmallDenseSet<llvm::StringRef, 64> subreg_name_set; + std::array<llvm::SmallVector<RegData *, 16>, RegKindCount> subreg_by_kind; + ---------------- It would be nice to have some comment explaining the purpose of this variable (I guess its there to ensure matching register order). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108937/new/ https://reviews.llvm.org/D108937 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
