labath added a comment.
What's the test strategy for this?
> This is not fully functional yet, as lldb-server
> crashes when attempting to send long packets (e.g. target.xml contents).
I am guessing you'll also want to disable QStartNoAckMode for these connections
(?)
================
Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:231
- if (reverse_connect) {
+ bool is_serial = host_and_port.startswith("serial://");
+ if (reverse_connect || is_serial) {
----------------
Maybe we should have this accept any lldb "URL", and have the host:port support
be a special case of "legacy" connection strings?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111964/new/
https://reviews.llvm.org/D111964
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
