[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

jingham added inline comments. Comment at: lldb/source/Commands/CommandCompletions.cpp:802 + // The only arguments constitute a command path, however, there might be + // options interspersed among the options, and we need to skip those. Do that + // by copying the args vect

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

jingham added a comment. The other slightly awkward choice I made was to have all the commands that take command paths (e.g. "command script add" and "command multiword add") take them with each component of the path as a separate argument. We have an argument type for commands, but the problem

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

jingham added a comment. I also didn't mirror "command script list" - I'm not sure how useful that is and anyway, that's an orthogonal piece of work, and this patch is big enough already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110298/new/

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

jingham added a comment. Note, I didn't do anything on the SB API side. We don't have a way to add commands of any sort through the API's, so we would have to do all that work along with adding multiword support, which is certainly fodder for a separate patch. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

jingham created this revision. jingham added reviewers: clayborg, JDevlieghere. Herald added subscribers: dang, mgorny. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. One of the ways that we organize all the functionality provided

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

augusto2112 added a comment. In D109908#3004789 , @teemperor wrote: > Could you add a test for that? The usual test fixit in Clang is `.`/`->` > mixup, e.g. > > (lldb) expr struct Foo { int i; }; Foo *f; f.i ; > unknown_identifier_for_fatal_error >

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

augusto2112 updated this revision to Diff 374338. augusto2112 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109908/new/ https://reviews.llvm.org/D109908 Files: lldb/source/Commands/CommandObjectExpression.cpp lldb/tes

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43552651319e: [lldb] Remove IRExecutionUnit::CollectFallbackNames (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 4355265 - [lldb] Remove IRExecutionUnit::CollectFallbackNames

Author: Alex Langford Date: 2021-09-22T11:01:15-07:00 New Revision: 43552651319e1c39c09ce0f61b588813414cebda URL: https://github.com/llvm/llvm-project/commit/43552651319e1c39c09ce0f61b588813414cebda DIFF: https://github.com/llvm/llvm-project/commit/43552651319e1c39c09ce0f61b588813414cebda.diff

[Lldb-commits] [PATCH] D110269: Fix LLDB build on old Linux kernels

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110269/new/ https://reviews.llvm.org/D110269 _

[Lldb-commits] [PATCH] D110269: Fix LLDB build on old Linux kernels

calebzulawski created this revision. calebzulawski added a reviewer: wallace. calebzulawski added a project: LLDB. Herald added a subscriber: JDevlieghere. calebzulawski requested review of this revision. Herald added a subscriber: lldb-commits. Usage of aux_size is guarded against elsewhere in th

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay marked 3 inline comments as done. emrekultursay added a comment. PTAL. The test now passes on Linux, MacOS, and Windows. Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26 + // dlopen the 'liblib_b.so' shared library. + void* h = dlopen(solib, RTLD_LAZ

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374237. emrekultursay edited the summary of this revision. emrekultursay added a comment. Make test also run on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted marked an inline comment as done. ted added a comment. Prints were there for my debugging. They don't serve a purpose, so I've removed them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.org/D109937 __

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted updated this revision to Diff 374233. ted added a comment. Remove unneeded prints from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.org/D109937 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCom

[Lldb-commits] [lldb] 9689c1b - [lldb] JITLoaderGDB tests can use lli in ORC greedy mode

Author: Stefan Gränitz Date: 2021-09-22T14:46:19+02:00 New Revision: 9689c1b7bb77d65e8acc9a13e5e416803d38b02f URL: https://github.com/llvm/llvm-project/commit/9689c1b7bb77d65e8acc9a13e5e416803d38b02f DIFF: https://github.com/llvm/llvm-project/commit/9689c1b7bb77d65e8acc9a13e5e416803d38b02f.diff

[Lldb-commits] [lldb] 9f34f75 - [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

Author: Martin Storsjö Date: 2021-09-22T14:11:41+03:00 New Revision: 9f34f75ff8f49b0efca6e20d916527a2c432d8b4 URL: https://github.com/llvm/llvm-project/commit/9f34f75ff8f49b0efca6e20d916527a2c432d8b4 DIFF: https://github.com/llvm/llvm-project/commit/9f34f75ff8f49b0efca6e20d916527a2c432d8b4.diff

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f34f75ff8f4: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on… (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

mstorsjo added a comment. In D109777#3014644 , @labath wrote: > Sorry about the delay. I think this is fine, though I would like to encourage > (*wink, wing, nudge, nudge*) someone to finish the lldb-server migration. > We're in a pretty bad situation,

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry about the delay. I think this is fine, though I would like to encourage (*wink, wing, nudge, nudge*) someone to finish the lldb-server migration. We're in a pretty bad situation, when it

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

labath added a comment. The SymbolFile/PDB tests are supposed to specifically test the (non-native) pdb plugin, so disabling them in this mode makes perfect sense to me. (though someone interested in pdb support may want to take a look at them to see whether they are failing just because they a

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:89-90 static bool ShouldUseNativeReader() { #if defined(_WIN32) +#if LLVM_ENABLE_DIA_SDK llvm::StringRef use_native = ::getenv("LLDB_USE_NATIVE_PDB_READER"); What'

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath added a comment. The test looks mostly fine. I made some comments on how to make it compatible with windows. I'm not sure if it would be enough to make it run there, but I think it has a fair chance. I might just let it run and then disable it if it turns out to be failing. ==

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestThreadInfoTrailingComma.py:24-25 +process = self.connect(target) +print(process.GetThread