jingham added a comment.

The other slightly awkward choice I made was to have all the commands that take 
command paths (e.g. "command script add" and "command multiword add") take them 
with each component of the path as a separate argument. We have an argument 
type for commands, but the problem with that is then you'd have to make the 
path a single word, i.e.:

(lldb) command script add "foo bar baz"

which would I think be annoying.  It made writing the completer a little 
trickier, but I think it's worth it to be able to write:

(lldb) command script add foo bar baz

If we ever need to write a command that has arguments that are some command 
paths and some other types of arguments, we'd have to have single argument 
paths, but I think it would be better to use options to avoid having to do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110298/new/

https://reviews.llvm.org/D110298

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to