[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

clayborg added a comment. We will need to add tests for this as well to ensure it doesn't regress. Tests should be added to: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py I would add a new test function into the TestVSCode_variables class: @skipIfWindows @skipIfRemote

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:531 +void Variables::Clear() { + locals.Clear(); Comment at: lldb/tool

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 355439. siger-young added a comment. Rebase two commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281 Files: lldb/docs/conf.py lldb/docs/index.rst lldb/d

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355437. yinghuitan added a comment. rebase to latest master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files: lldb/tools/lldb-vscode/VSCode.cpp lldb/tools

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355436. yinghuitan marked an inline comment as done. yinghuitan added a comment. Rerun linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files: lldb/tools/l

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355435. yinghuitan marked 37 inline comments as done. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files:

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young updated this revision to Diff 355429. siger-young added a comment. Fix some linting and add extra tests for Lua scripted watchpoints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 Files: l

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young updated this revision to Diff 355428. siger-young added a comment. This patch mainly adds two extra tests for Lua scripted watchpoints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 Files:

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Mostly LLDB and LLVM coding guideline conventions that need to be followed. Many comments and code suggestions. But there are some code changes like having unique IDs for temp va

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, wallace. Herald added a subscriber: jfb. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VScode now sends a "scopes" DAP request immediately after any expres

[Lldb-commits] [lldb] 43f6dad - Fix buildbot compile error for https://reviews.llvm.org/D105160.

Author: Greg Clayton Date: 2021-06-29T18:03:25-07:00 New Revision: 43f6dad2344247976d5777f56a1fc29e39c6c717 URL: https://github.com/llvm/llvm-project/commit/43f6dad2344247976d5777f56a1fc29e39c6c717 DIFF: https://github.com/llvm/llvm-project/commit/43f6dad2344247976d5777f56a1fc29e39c6c717.diff

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8164d0276b9: Create synthetic symbol names on demand to improve memory consumption and… (authored by clayborg). Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] c8164d0 - Create synthetic symbol names on demand to improve memory consumption and startup times.

Author: Greg Clayton Date: 2021-06-29T17:44:33-07:00 New Revision: c8164d0276b97679e80db01adc860271ab4a5d11 URL: https://github.com/llvm/llvm-project/commit/c8164d0276b97679e80db01adc860271ab4a5d11 DIFF: https://github.com/llvm/llvm-project/commit/c8164d0276b97679e80db01adc860271ab4a5d11.diff

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

tammela added a comment. Clang format complained a bit, please fix those. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test:15 +# CHECK: val=nil +# CHECK: Process {{[0-9]+}} exited More tests cases would be nice Repository: rG LLVM

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Crossing fingers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105160/new/ https://reviews.llvm.org/D105160 _

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

stella.stamenova added a comment. In D105160#2848805 , @clayborg wrote: > @stella.stamenova all test suite failures should be fixed now. This is a redo > on https://reviews.llvm.org/D104488 which was reverted in less that a day... @clayborg : Thanks! We

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg added a comment. @stella.stamenova all test suite failures should be fixed now. This is a redo on https://reviews.llvm.org/D104488 which was reverted in less that a day... Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2829 +/*section_sp=

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, jingham, wallace. Herald added subscribers: kristof.beyls, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This fix was create

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:22 """ Test that qMemTags packets are parsed correctly and/or rejected. """ self.build() Missing isAArch64MTE check here

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord abandoned this revision. bulbazord added a comment. Not going with this change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103210/new/ https://reviews.llvm.org/D103210 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D104407: Improve path remapping in cross-debugging scenarios

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21e013303bb7: Improve path remapping in cross-debugging scenarios (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: ht

[Lldb-commits] [lldb] 21e0133 - Improve path remapping in cross-debugging scenarios

Author: Adrian Prantl Date: 2021-06-29T15:27:01-07:00 New Revision: 21e013303bb7d0dbb9106283af0fb966fe45af42 URL: https://github.com/llvm/llvm-project/commit/21e013303bb7d0dbb9106283af0fb966fe45af42 DIFF: https://github.com/llvm/llvm-project/commit/21e013303bb7d0dbb9106283af0fb966fe45af42.diff

[Lldb-commits] [PATCH] D104724: Modernize Module::RemapFile to return an Optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e1b11fac7a: Modernize Module::RemapFile to return an Optional (NFC) (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Git

[Lldb-commits] [lldb] a0e1b11 - Modernize Module::RemapFile to return an Optional (NFC)

Author: Adrian Prantl Date: 2021-06-29T15:19:31-07:00 New Revision: a0e1b11fac7a1599faec21d13fae45c8571de02c URL: https://github.com/llvm/llvm-project/commit/a0e1b11fac7a1599faec21d13fae45c8571de02c DIFF: https://github.com/llvm/llvm-project/commit/a0e1b11fac7a1599faec21d13fae45c8571de02c.diff

[Lldb-commits] [lldb] 302b1b9 - Express PathMappingList::FindFile() in terms of PathMappingList::RemapPath()

Author: Adrian Prantl Date: 2021-06-29T15:14:31-07:00 New Revision: 302b1b97180907011aae610b9f51d4b9186c9821 URL: https://github.com/llvm/llvm-project/commit/302b1b97180907011aae610b9f51d4b9186c9821 DIFF: https://github.com/llvm/llvm-project/commit/302b1b97180907011aae610b9f51d4b9186c9821.diff

[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG302b1b971809: Express PathMappingList::FindFile() in terms of PathMappingList::RemapPath() (authored by aprantl). Herald added a project: LLDB. Chan

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa346372200e7: Change PathMappingList::FindFile to return an optional result (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prior

[Lldb-commits] [lldb] a346372 - Change PathMappingList::FindFile to return an optional result (NFC)

Author: Adrian Prantl Date: 2021-06-29T15:10:46-07:00 New Revision: a346372200e7b2b99631bd90691678d5ca03fdd1 URL: https://github.com/llvm/llvm-project/commit/a346372200e7b2b99631bd90691678d5ca03fdd1 DIFF: https://github.com/llvm/llvm-project/commit/a346372200e7b2b99631bd90691678d5ca03fdd1.diff

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. - Scrolling was temporarily removed from the patch. It was causing issues with fields that change in size. I will reimplement it as contextual scrolling directly. - Action buttons weren't moved to the window border as d

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 355364. OmarEmaraDev added a comment. This revision is now accepted and ready to land. - Rewrite internal field navigation. - Rewrite form window drawing. Form delegate no longer have drawing routines. - Add global error messages. - Add action bar. Form d

[Lldb-commits] [lldb] c8a9c78 - [lldb] Fix debug_loc.s which was broken after https://reviews.llvm.org/D103502

Author: Stella Stamenova Date: 2021-06-29T13:54:48-07:00 New Revision: c8a9c78e170e3b972041b301a50d0456afe83d10 URL: https://github.com/llvm/llvm-project/commit/c8a9c78e170e3b972041b301a50d0456afe83d10 DIFF: https://github.com/llvm/llvm-project/commit/c8a9c78e170e3b972041b301a50d0456afe83d10.di

[Lldb-commits] [lldb] 9952d59 - [lldb] Fix globals-bss.cpp which was broken in https://reviews.llvm.org/D105055

Author: Stella Stamenova Date: 2021-06-29T13:39:18-07:00 New Revision: 9952d591ccc49cbcbf9c89d5191e6111c44703a6 URL: https://github.com/llvm/llvm-project/commit/9952d591ccc49cbcbf9c89d5191e6111c44703a6 DIFF: https://github.com/llvm/llvm-project/commit/9952d591ccc49cbcbf9c89d5191e6111c44703a6.di

[Lldb-commits] [lldb] bb2cfca - Revert D104488 and friends since it broke the windows bot

Author: Stella Stamenova Date: 2021-06-29T12:58:55-07:00 New Revision: bb2cfca2f3237d7f722e95d4cab9f3d71f728c9c URL: https://github.com/llvm/llvm-project/commit/bb2cfca2f3237d7f722e95d4cab9f3d71f728c9c DIFF: https://github.com/llvm/llvm-project/commit/bb2cfca2f3237d7f722e95d4cab9f3d71f728c9c.di

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil updated this revision to Diff 355333. jankratochvil added a comment. This revision is now accepted and ready to land. Unfortunately `AddRecognizer` requires both or none `module` and `symbols` as regexes. And we cannot make `module` a regex as `GetFileSpec().FileEquals` would not w

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:115 +regex += it->GetStringRef(); + } + // Strip the trailing @VER symbol version. jankratochv

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:115 +regex += it->GetStringRef(); + } + // Strip the trailing @VER symbol version. There would be nice `llvm::join`. But it wants `Elem.size()` while `ConstString

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil updated this revision to Diff 355327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 Files: lldb/source/Target/AssertFrameRecognizer.cpp Index: lldb/source/Target/AssertFrameRecognizer.cp

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

mib added a comment. Another possibility could be to add a `bool is_regex` to the `SymbolLocation` struct and set it to `true` for Linux, then in `RegisterAssertFrameRecognizer` if that flag is set, build a `RegularExpression` out of the every symbol string in the struct and call the `FrameRec

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

fweimer added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:48 location.symbols.push_back(ConstString("gsignal")); +location.symbols.push_back(ConstString("pthread_kill@GLIBC_2.2.5")); break; The symbol version is archite

[Lldb-commits] [PATCH] D105136: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71be4db05bbd: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock (authored by JDevlieghere). Herald added a project: LLDB

[Lldb-commits] [lldb] 71be4db - [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock

Author: Jonas Devlieghere Date: 2021-06-29T10:58:35-07:00 New Revision: 71be4db05bbdcc8a9bbe01f54cf273b530327ec7 URL: https://github.com/llvm/llvm-project/commit/71be4db05bbdcc8a9bbe01f54cf273b530327ec7 DIFF: https://github.com/llvm/llvm-project/commit/71be4db05bbdcc8a9bbe01f54cf273b530327ec7.d

[Lldb-commits] [PATCH] D105136: [lldb Look for the mangled objc_copyRealizedClassList_nolock symbol name

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105136/new/ https://reviews.llvm.org/D105136 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D105136: [lldb Look for the mangled objc_copyRealizedClassList_nolock symbol name

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. When we check if the `objc_copyRealizedClassList_nolock` we need to check for the mangled symbol rather than than the unmangled one as we did for the locking objc_copyReali

[Lldb-commits] [PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaba37187fda: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] aaba371 - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-29T13:26:23-04:00 New Revision: aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709 URL: https://github.com/llvm/llvm-project/commit/aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709 DIFF: https://github.com/llvm/llvm-project/commit/aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709.diff

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil created this revision. jankratochvil added reviewers: teemperor, mib. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. While on regular Linux system (Fedora 34 GA, not updated): * thread #1, name = '1',

[Lldb-commits] [lldb] c000323 - [lldb] Skip TestPairFromStdModule for now

Author: Raphael Isemann Date: 2021-06-29T19:01:11+02:00 New Revision: c00032321a6ae26f9c8056d024e262abf342631e URL: https://github.com/llvm/llvm-project/commit/c00032321a6ae26f9c8056d024e262abf342631e DIFF: https://github.com/llvm/llvm-project/commit/c00032321a6ae26f9c8056d024e262abf342631e.dif

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

stella.stamenova added a comment. This broke the windows lldb bot and the follow up changes did not fix it: https://lab.llvm.org/buildbot/#/builders/83/builds/7748 Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ htt

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

omjavaid added a comment. This rev has caused multiple test failure on LLDB Arm/AArch64 buildbots. https://lab.llvm.org/buildbot/#/builders/17/builds/8504 https://lab.llvm.org/buildbot/#/builders/96/builds/9110 https://lab.llvm.org/buildbot/#/builders/96/builds/9111 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6b64612bd92: [lldb/Interpreter] Fix session-save-on-quit when using ^D (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe1874dd2dd9: [lldb/Interpreter] Add setting to set session transcript save directory (authored by mib). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [lldb] d6b6461 - [lldb/Interpreter] Fix session-save-on-quit when using ^D

Author: Med Ismail Bennani Date: 2021-06-29T10:54:29+02:00 New Revision: d6b64612bd92cda8b53ef348fb578983124c600f URL: https://github.com/llvm/llvm-project/commit/d6b64612bd92cda8b53ef348fb578983124c600f DIFF: https://github.com/llvm/llvm-project/commit/d6b64612bd92cda8b53ef348fb578983124c600f.

[Lldb-commits] [lldb] fe1874d - [lldb/Interpreter] Add setting to set session transcript save directory

Author: Med Ismail Bennani Date: 2021-06-29T10:54:29+02:00 New Revision: fe1874dd2dd99c9811db515a2957e2a42f9f6868 URL: https://github.com/llvm/llvm-project/commit/fe1874dd2dd99c9811db515a2957e2a42f9f6868 DIFF: https://github.com/llvm/llvm-project/commit/fe1874dd2dd99c9811db515a2957e2a42f9f6868.