clayborg added a comment.
@stella.stamenova all test suite failures should be fixed now. This is a redo
on https://reviews.llvm.org/D104488 which was reverted in less that a day...
================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2829
+ /*section_sp=*/section_sp,
+ /*offset=*/0,
+ /*size=*/0, // FDE can span multiple symbols so don't use its size.
----------------
This is a bug that I tried to fix by putting "entry_point_addr.GetOffset()"
instead of zero here. Restoring to zero to make sure that:
lldb-shell :: SymbolFile/dissassemble-entry-point.s
lldb-unit ::
ObjectFile/ELF/./ObjectFileELFTests.exe/ObjectFileELFTest.GetSymtab_NoSymEntryPointArmThumbAddressClass
don't fail. I will fix this bug in another patch.
================
Comment at: lldb/test/Shell/ObjectFile/ELF/eh_frame-symbols.yaml:6-7
# CHECK: [ 0] 1 SourceFile 0x0000000000000000
0x0000000000000000 0x00000004 -
-# CHECK: [ 1] 2 SX Code 0x0000000000201180
0x0000000000000010 0x00000000 ___lldb_unnamed_symbol1$${{.*}}
-# CHECK: [ 2] 3 SX Code 0x0000000000201190
0x0000000000000006 0x00000000 ___lldb_unnamed_symbol2$${{.*}}
+# CHECK: [ 1] 2 SX Code 0x0000000000201180
0x0000000000000010 0x00000000 ___lldb_unnamed_symbol{{[0-9]*}}
+# CHECK: [ 2] 3 SX Code 0x0000000000201190
0x0000000000000006 0x00000000 ___lldb_unnamed_symbol{{[0-9]*}}
----------------
This fixes the following previously failing test:
lldb-shell :: ObjectFile/ELF/eh_frame-symbols.yaml
================
Comment at: lldb/test/Shell/SymbolFile/Breakpad/symtab.test:8
# CHECK: Index UserID DSX Type File Address/Value Load Address
Size Flags Name
-# CHECK: [ 0] 0 SX Code 0x0000000000400000
0x00000000000000b0 0x00000000 ___lldb_unnamed_symbol{{[0-9]*}}$$symtab.out
+# CHECK: [ 0] 0 SX Code 0x0000000000400000
0x00000000000000b0 0x00000000 ___lldb_unnamed_symbol{{[0-9]*}}
# CHECK: [ 1] 0 X Code 0x00000000004000b0
0x000000000000000c 0x00000000 f1_func
----------------
This fixes the following previously failing test:
lldb-shell :: SymbolFile/Breakpad/symtab.test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105160/new/
https://reviews.llvm.org/D105160
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
