mib accepted this revision. mib added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:115 + regex += it->GetStringRef(); + } + // Strip the trailing @VER symbol version. ---------------- jankratochvil wrote: > There would be nice `llvm::join`. But it wants `Elem.size()` while > `ConstString` here provides `Elem.GetLength()`. I did not try to extend > `StringExtras.h`. > That's unfortunate indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
