[Lldb-commits] [lldb] 3dcbfa2 - [debugserver] Fix more compiler warnings on arm64

Author: Jonas Devlieghere Date: 2021-03-03T23:12:12-08:00 New Revision: 3dcbfa27d432e3fddb61c5ad32534ce2bc1836e1 URL: https://github.com/llvm/llvm-project/commit/3dcbfa27d432e3fddb61c5ad32534ce2bc1836e1 DIFF: https://github.com/llvm/llvm-project/commit/3dcbfa27d432e3fddb61c5ad32534ce2bc1836e1.d

[Lldb-commits] [PATCH] D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h:12 +#include + We generally include system headers after project headers. Comment at: lldb/include/lldb/Interpreter/OptionGroupPyt

[Lldb-commits] [PATCH] D95100: [lldb/Commands] Fix short option collision for `process launch`

mib closed this revision. mib added a comment. Landed in 103ad3f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95100/new/ https://reviews.llvm.org/D95100

[Lldb-commits] [PATCH] D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required

mib updated this revision to Diff 328020. mib added a comment. Fix header guard length. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97910/new/ https://reviews.llvm.org/D97910 Files: lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.

[Lldb-commits] [PATCH] D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required

mib created this revision. mib added reviewers: JDevlieghere, teemperor. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. When using `OptionGroupPythonClassWithDict` options in an `OptionGroup` with other `Options`, it can happen that the c

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG266bb78f7d13: LanguageRuntime for 0th frame unwind, simplify get

[Lldb-commits] [lldb] 266bb78 - LanguageRuntime for 0th frame unwind, simplify getting pc-for-symbolication

Author: Jason Molenda Date: 2021-03-03T19:29:40-08:00 New Revision: 266bb78f7d133a344992c5bfca61ef11ee152cb0 URL: https://github.com/llvm/llvm-project/commit/266bb78f7d133a344992c5bfca61ef11ee152cb0 DIFF: https://github.com/llvm/llvm-project/commit/266bb78f7d133a344992c5bfca61ef11ee152cb0.diff

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

jasonmolenda added inline comments. Comment at: lldb/source/Target/StackFrame.cpp:217-226 + Address lookup_addr(GetFrameCodeAddress()); + if (!lookup_addr.IsValid()) +return lookup_addr; + if (m_behaves_like_zeroth_frame) +return lookup_addr; + + addr_t offset = looku

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

clayborg added inline comments. Comment at: lldb/source/Target/RegisterContext.cpp:162 + if (!BehavesLikeZerothFrame()) +pc--; + const bool allow_section_end = true; jasonmolenda wrote: > clayborg wrote: > > Can we decrement the PC by the minimum instructio

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

jasonmolenda added inline comments. Comment at: lldb/source/Target/RegisterContext.cpp:162 + if (!BehavesLikeZerothFrame()) +pc--; + const bool allow_section_end = true; clayborg wrote: > Can we decrement the PC by the minimum instruction size? If we can ge

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 327945. clayborg added a comment. Fix typo in headerdoc comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 Files: lldb/include/lldb/API/SBDebugger.h lldb/inc

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Target/RegisterContext.cpp:162 + if (!BehavesLikeZerothFrame()) +pc--; + const bool allow_section_end = true;

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

jasonmolenda updated this revision to Diff 327930. jasonmolenda added a comment. Rewrite patch to expose "get pc for symbolication" APIs instead of "behaves like zeroth frame" APIs so that we don't have different parts of lldb decrementing the pc for symbolication. Doing a final round of tests

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. This version should address all comments and issue that I am aware of. Now the callbacks are registered with each debugger and the Progress class no longer has any global state. The Progress class calls a static method on the debugger which allows the Debugger class to

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 327871. clayborg added a comment. Update fixes: - make progress callback and baton members of a lldb_private::Debugger object to allow each debugger to have their own callbacks. - switch to have std::string title and clients use llvm::formatv() to create t

Re: [Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

Something went very wrong on the patch upload. This does NOT look like the patch I intended! DO NOT REVIEW THIS UNTIL I CAN UPLOAD THE RIGHT PATCH! -- Caroline cmt...@google.com On Tue, Mar 2, 2021 at 10:53 AM Shoaib Meenai via Phabricator < revi...@reviews.llvm.org> wrote: > smeenai added a

[Lldb-commits] [PATCH] D97760: [lldb][NFC] Delete unused AddressResolverName

This revision was automatically updated to reflect the committed changes. Closed by commit rG820a8466097c: [lldb][NFC] Delete unused AddressResolverName (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 820a846 - [lldb][NFC] Delete unused AddressResolverName

Author: Raphael Isemann Date: 2021-03-03T13:30:02+01:00 New Revision: 820a8466097cd9336c81a14bcbe773807fbf96e4 URL: https://github.com/llvm/llvm-project/commit/820a8466097cd9336c81a14bcbe773807fbf96e4 DIFF: https://github.com/llvm/llvm-project/commit/820a8466097cd9336c81a14bcbe773807fbf96e4.dif

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:19 +@skipUnlessPlatform(["linux"]) +@skipUnlessAArch64MTELinuxCompiler +def test_qmemtags_pac

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; omjavaid wrote: > ptrace request is a success if number of tag

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.cpp:36 + if (machine != llvm::Triple::aarch64 && machine != llvm::Triple::aarch64_be && + machine != llvm::Triple::aarch64_32) { +return nullptr; -

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

omjavaid added inline comments. Comment at: lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.cpp:36 + if (machine != llvm::Triple::aarch64 && machine != llvm::Triple::aarch64_be && + machine != llvm::Triple::aarch64_32) { +return nullptr; D

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b47bd32f9df: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2) (authored by werat). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 3b47bd3 - [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

Author: Andy Yankovsky Date: 2021-03-03T10:27:35+01:00 New Revision: 3b47bd32f9df4a57db98db5f35e680c7bd9fde3e URL: https://github.com/llvm/llvm-project/commit/3b47bd32f9df4a57db98db5f35e680c7bd9fde3e DIFF: https://github.com/llvm/llvm-project/commit/3b47bd32f9df4a57db98db5f35e680c7bd9fde3e.diff