clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/source/Target/RegisterContext.cpp:162 + if (!BehavesLikeZerothFrame()) + pc--; + const bool allow_section_end = true; ---------------- Can we decrement the PC by the minimum instruction size? If we can get an ArchSpec we can call: ``` uint32_t ArchSpec::GetMinimumOpcodeByteSize() const; ``` ================ Comment at: lldb/source/Target/StackFrame.cpp:217-226 + Address lookup_addr(GetFrameCodeAddress()); + if (!lookup_addr.IsValid()) + return lookup_addr; + if (m_behaves_like_zeroth_frame) + return lookup_addr; + + addr_t offset = lookup_addr.GetOffset(); ---------------- Should we be using the "bool RegisterContext::GetPCForSymbolication(Address &address)" function here to avoid having more than one place that is subtracting from the PC value? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97644/new/ https://reviews.llvm.org/D97644 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
