JDevlieghere added inline comments.
================ Comment at: lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h:12 +#include <bitset> + ---------------- We generally include system headers after project headers. ================ Comment at: lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h:68 OptionDefinition m_option_definition[4]; + std::bitset<4> m_required_options; }; ---------------- I don't mind the bitset but we have a `Flags` utility that seems like a good fit for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97910/new/ https://reviews.llvm.org/D97910 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
