[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

omjavaid added a comment. In D96548#2573245 , @mgorny wrote: > In D96548#2572770 , @omjavaid wrote: > >> I am wondering Whats the need for version checks? you are excluding hardware >> breakpoint mangement code fro

[Lldb-commits] [lldb] d82ecb0 - LanguageRuntime can provide an UnwindPlan for special occasions

Author: Jason Molenda Date: 2021-02-18T23:23:15-08:00 New Revision: d82ecb0ac72261189ec3a5dccd3ad55aeafe07b4 URL: https://github.com/llvm/llvm-project/commit/d82ecb0ac72261189ec3a5dccd3ad55aeafe07b4 DIFF: https://github.com/llvm/llvm-project/commit/d82ecb0ac72261189ec3a5dccd3ad55aeafe07b4.diff

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd82ecb0ac722: LanguageRuntime can provide an UnwindPlan for special occasions (authored by jasonmolenda). Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. > I don't think this does what you think it does. The $() doesn't give you the > process id of anything -- it substitutes a string by the result of running > that string as a shell command. So, the PID variable would get the (entire) > stdout of %s.out I'm confused here,

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm updated this revision to Diff 324866. aadsm added a comment. Add api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/source/Plugi

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 324865. aadsm added a comment. revert last amend: added the test to the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/tools/lldb-vscode/lldb-vs

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 324864. aadsm added a comment. Add api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/test/API/fun

[Lldb-commits] [PATCH] D97017: [lldb-server] Exit the DataAvailableCallback loop when `done` or `interrupt` are set

JDevlieghere created this revision. JDevlieghere added reviewers: labath, omjavaid. JDevlieghere requested review of this revision. When looking at `GDBRemoteCommunicationServerLLGS::DataAvailableCallback` I noticed that the `done` and `interrupt` flags are currently being ignored. I assumed the

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik added a comment. Herald added a subscriber: JDevlieghere. Reverted the changes because I missed the clangd test suite and don't know how long it will take to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm

[Lldb-commits] [lldb] 080ba85 - Revert "Fix for Modify TypePrinter to differentiate between anonymous struct and unnamed struct"

Author: Shafik Yaghmour Date: 2021-02-18T18:17:24-08:00 New Revision: 080ba851c61604f9c00117b584191c67cfc468cd URL: https://github.com/llvm/llvm-project/commit/080ba851c61604f9c00117b584191c67cfc468cd DIFF: https://github.com/llvm/llvm-project/commit/080ba851c61604f9c00117b584191c67cfc468cd.dif

[Lldb-commits] [lldb] 1e08193 - Fix for Modify TypePrinter to differentiate between anonymous struct and unnamed struct

Author: Shafik Yaghmour Date: 2021-02-18T17:57:40-08:00 New Revision: 1e0819395657a9306f609849dcd3be9d7fb0c894 URL: https://github.com/llvm/llvm-project/commit/1e0819395657a9306f609849dcd3be9d7fb0c894 DIFF: https://github.com/llvm/llvm-project/commit/1e0819395657a9306f609849dcd3be9d7fb0c894.dif

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

This revision was automatically updated to reflect the committed changes. shafik marked an inline comment as done. Closed by commit rGecb90b55454e: Modify TypePrinter to differentiate between anonymous struct and unnamed struct (authored by shafik). Herald added projects: clang, LLDB. Repository:

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324813. mib added a comment. Test `ScriptedProcess::ReadMemory` Test launching the scripted process from both the command line and from the `SBAPI`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny added a comment. In D96548#2572770 , @omjavaid wrote: > I am wondering Whats the need for version checks? you are excluding hardware > breakpoint mangement code from the build but then that lldb-server executable > may well run on FreeBSD version

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib updated this revision to Diff 324809. mib added a comment. Remove repetitive documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://reviews.llvm.org/D95712 Files: lldb/bindings/python/CMakeLists.txt lldb/examples/p

[Lldb-commits] [lldb] 31fa76f - [lldb] Check that files exists before handing them off to FileCollector

Author: Jonas Devlieghere Date: 2021-02-18T16:16:15-08:00 New Revision: 31fa76fd24adea755e4368674a59385d2c5b0cc7 URL: https://github.com/llvm/llvm-project/commit/31fa76fd24adea755e4368674a59385d2c5b0cc7 DIFF: https://github.com/llvm/llvm-project/commit/31fa76fd24adea755e4368674a59385d2c5b0cc7.d

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2572816 , @dblaikie wrote: > rolls this into one file with two CUs - bit easier to deal with. Then one could not use the `.file` directives and one would need to code also `.debug_line` by hand. > You could remov

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

dblaikie added a comment. In D96778#2572405 , @jankratochvil wrote: > In D96778#2566208 , @dblaikie wrote: > >> I expect it'd be good to have a test case showing the sort of DWARF that DWZ >> produces for cross-CU

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

omjavaid added a comment. This looks fine to me builds ok on AArch64/Linux with no testsuite regressions. I am wondering Whats the need for version checks? you are excluding hardware breakpoint mangement code from the build but then that lldb-server executable may well run on FreeBSD version wh

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2566208 , @dblaikie wrote: > I expect it'd be good to have a test case showing the sort of DWARF that DWZ > produces for cross-CU references of enumerators. Here is a new testcase for the second (`DW_TAG_variable`

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This LGTM. @labath are you fine with landing this and incrementally improving the interface? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://revie

[Lldb-commits] [lldb] 612384f - [lldb] Remove unused code in ScriptInterpreterPython

Author: Jonas Devlieghere Date: 2021-02-18T10:38:54-08:00 New Revision: 612384f6e01194a4689b6663f039145b3d01ddce URL: https://github.com/llvm/llvm-project/commit/612384f6e01194a4689b6663f039145b3d01ddce DIFF: https://github.com/llvm/llvm-project/commit/612384f6e01194a4689b6663f039145b3d01ddce.d

[Lldb-commits] [lldb] 1b8d2ec - [lldb] Un-XFAIL TestFormatters on windows

Author: Pavel Labath Date: 2021-02-18T18:47:20+01:00 New Revision: 1b8d2ec07142d3517c0236064b1b8d281319b02a URL: https://github.com/llvm/llvm-project/commit/1b8d2ec07142d3517c0236064b1b8d281319b02a DIFF: https://github.com/llvm/llvm-project/commit/1b8d2ec07142d3517c0236064b1b8d281319b02a.diff

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

tatyana-krasnukha added a comment. clang-tidy would not be happy;) Comment at: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp:665 +return SetHardwareBreakpoint(addr, size); else return SetSoftwareBreakpoint(addr, size); Redundant `else

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha added a comment. I created D96817 - a demonstrative example of the CRTP-based version of this patch. Please, take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org/D96817 __

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mhorne added a comment. The FreeBSD API usage looks correct to me, but I can't comment on too much more than that. The code could benefit from fewer unnamed constants. I should also note that it is my intention to merge the FreeBSD watchpoint patches into the 13.0 branch, in about a week's time

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

labath added a comment. Yeah, I'm with Greg. Although I would recommend using lit tests in general, I don't think they're a good fit for anything that involves attaching, or other kinds of inter-process synchronization. Once you start dealing with subprocesses you're entering very messy (and un

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG004a264f8c92: [lldb] Fix shared library directory computation on windows (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 004a264 - [lldb] Fix shared library directory computation on windows

Author: Pavel Labath Date: 2021-02-18T15:37:52+01:00 New Revision: 004a264f8c923922ecd34255bcb10f4adaa27ac5 URL: https://github.com/llvm/llvm-project/commit/004a264f8c923922ecd34255bcb10f4adaa27ac5 DIFF: https://github.com/llvm/llvm-project/commit/004a264f8c923922ecd34255bcb10f4adaa27ac5.diff

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324587. mib added a comment. Fix test typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/bindings/python/CMakeLists.txt lldb/include/lldb/Target/Process.

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

DavidSpickett added a comment. Thanks for looking at this, I had the same confusion adding some new commands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96947/new/ https://reviews.llvm.org/D96947 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 324579. mib added a comment. Remove `ScriptedProcessInterface.cpp` from the Interpreter's `CMakeLists.txt` since the file doesn't exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llv

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor added a comment. Also I'm going to clean the existing error messages from redundant newlines in a separate NFC commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96947/new/ https://reviews.llvm.org/D96947 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor added a comment. FWIW, I am very interested in finding out how we can over-engineer this. I do believe there is potential to let tablegen generate the error message strings which then could also check the new lines for us. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96947/n

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96947/new/ https://reviews.llvm.org/D96947 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. The current API for printing errors/warnings/messages from LLDB commands sometimes adds newlines behind the mes

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324564. mib marked 4 inline comments as done. mib added a comment. Address @JDevlieghere feedbacks: - Make test more portable - Add helper function to get the `ScriptedProcessInterface` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib updated this revision to Diff 324562. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://reviews.llvm.org/D95712 Files: lldb/bindings/py

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 324558. mib added a comment. Make `ScriptedProcessInterface` a `unique_ptr` instead of `shared_ptr` in `ScriptInterpreter` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor updated this revision to Diff 324551. teemperor added a comment. - Also clarify error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandO

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. In D96939#2570834 , @teemperor wrote: > In D96939#2570831 , @jasonmolenda > wrote: > >> In D96939#2570830 , @teemperor >> wrote: >> >>> What a

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added a comment. In D96939#2570831 , @jasonmolenda wrote: > In D96939#2570830 , @teemperor wrote: > >> What about: >> >> error: Couldn't recognise core file format of . >> note: If the file is a core

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. In D96939#2570830 , @teemperor wrote: > What about: > > error: Couldn't recognise core file format of . > note: If the file is a core file in a compressed file archive, it first > needs to be manually extracted before it

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added a comment. In D96939#2570810 , @jasonmolenda wrote: > I mean, I'm also fine with suggesting that the file might be compressed, > because this is a REAL common source of an unrecognized core file format. > But also we can more clearly sa

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. I mean, I'm also fine with suggesting that the file might be compressed, because this is a REAL common source of an unrecognized core file format. But also we can more clearly say "Doesn't look like a core file to me" and also noting that compression is something

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract th

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. Thanks for taking time to deal with this annoying error message. Should we just remove the "Unable to find process plug-in for core file" text altogether? It means nothing unless you work on lldb and understand the plugin system. "Unrecognized core file format"

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract the c

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor updated this revision to Diff 324546. teemperor added a comment. - Made `note:` lower case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandObjec

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract th

[Lldb-commits] [lldb] fb1dc77 - [lldb][NFC] Silence missing case warnings in TypeSystemClang::GetTypeBitAlign due to new RISC-V V types

Author: Raphael Isemann Date: 2021-02-18T09:03:18+01:00 New Revision: fb1dc77bfd24c32a5231face77e0bc4323b67c68 URL: https://github.com/llvm/llvm-project/commit/fb1dc77bfd24c32a5231face77e0bc4323b67c68 DIFF: https://github.com/llvm/llvm-project/commit/fb1dc77bfd24c32a5231face77e0bc4323b67c68.dif