mgorny added a comment. In D96548#2572770 <https://reviews.llvm.org/D96548#2572770>, @omjavaid wrote:
> I am wondering Whats the need for version checks? you are excluding hardware > breakpoint mangement code from the build but then that lldb-server executable > may well run on FreeBSD version which actually supports HW breakpoints. Isnt > there a dynamic way of checking support for hardware break/watch points. May > be query hardware debug registers and if it fails just disable hardware > breakpoints for that thread. The code relies on `struct` members that are only present with this version. I'd like to avoid copying implementation details like that into the code. > Moreover, can we shrink class name NativeRegisterContextBreakWatchpoint_arm64 > to may be NativeDebugRegisterContext_arm64. I generally leave naming decisions to @labath ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
