JDevlieghere added inline comments.
================ Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract the core file " ---------------- teemperor wrote: > JDevlieghere wrote: > > For consistency with `warning` and `error`, `Note` should be lowercase. > > > > [begin potential yak shaving] > > It would be nice to extend `CommandReturnObject` with the notion of notes. > > That way they could be colored in the same way that `error` and `warning` > > are. LLVM's `WithColor` already has a dedicated `note` color. > > [end potential yak shaving] > Fixed the typo. > > +1 to the 'note' variation. I'll see if we can make that happen but not as a > dependency of this commit (we anyway already have some other places where > this should be done). Yep, definitely something for a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
