[Lldb-commits] [lldb] c565f09 - [lldb] Don't strip LLDB.framework on install

Author: Jonas Devlieghere Date: 2020-10-20T18:16:36-07:00 New Revision: c565f09f4b0d908f51aaf4a841285f39ef93bc8c URL: https://github.com/llvm/llvm-project/commit/c565f09f4b0d908f51aaf4a841285f39ef93bc8c DIFF: https://github.com/llvm/llvm-project/commit/c565f09f4b0d908f51aaf4a841285f39ef93bc8c.d

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 299527. zequanwu added a comment. elaborate CHECK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files: lldb/source/Plugins/ObjectFile/CMakeLists.txt lldb/source/

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 299525. zequanwu added a comment. - Add `GetArchitecture` method, similar to ObjectFilePECOFF - Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files:

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 299524. wallace added a comment. Herald added a subscriber: dang. Some updates, especially regarding the indexing and dump ordering, which I discussed at lenght with some coworkers: - I've addressed most of the issues, except for the disassembly and the yaml

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked 10 inline comments as done. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:109 + else { +consumeError(decoded_thread.takeError()); +return 0; labath wrote: > wallace wrote: > > labath wrote:

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau added a comment. OK, for now, I've restored the use of uppercase_CMAKE_BUILD_TYPE. It looks like this does get set, and it's just the empty string on my machine because windows. I'd like to see it get removed, but this commit is about fixing the build. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau updated this revision to Diff 299491. ctetreau added a comment. restore use of uppercase_CMAKE_BUILD_TYPE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/ https://reviews.llvm.org/D89807 Files: lldb/cmake/modules/FindPythonAndSw

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2342225 , @jingham wrote: > In D88483#2341538 , @fallkrum wrote: > >> Thanks a lot Jim for explanations, now it makes sense to me. >> Have one more question on class Type. Writing

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau planned changes to this revision. ctetreau added a comment. After experimenting a bit, it seems that if you pass `-DCMAKE_BUILD_TYPE=RELEASE`, then the value of CMAKE_BUILD_TYPE will also be uppercase. This might represent a "good reason" to use the uppercase_CMAKE_BUILD_TYPE version.

[Lldb-commits] [PATCH] D89215: [lldb] Add a page to the documentation with (external) links on how to use LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rGde6f3d1c7133: [lldb] Add a page to the docs with (external) links on how to use LLDB (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [lldb] de6f3d1 - [lldb] Add a page to the docs with (external) links on how to use LLDB

Author: Jonas Devlieghere Date: 2020-10-20T11:43:31-07:00 New Revision: de6f3d1c71332b2c0ba00a2792c02be72b245d22 URL: https://github.com/llvm/llvm-project/commit/de6f3d1c71332b2c0ba00a2792c02be72b245d22 DIFF: https://github.com/llvm/llvm-project/commit/de6f3d1c71332b2c0ba00a2792c02be72b245d22.d

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

JDevlieghere added a comment. In D89807#2342351 , @ctetreau wrote: > The real issue though is that `uppercase_CMAKE_BUILD_TYPE` is not defined at > this point. I could define it, but the case of the possible values of > `CMAKE_BUILD_TYPE` are well define

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. How can I start lldb at specified path so that `target symbols add bar.pdb` could find the pdb path? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 __

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu created this revision. zequanwu added reviewers: labath, amccarth. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. zequanwu requested review of this revision. Herald added a subscriber: JDevlieghere. To allow loading PDB file with `target symbols add` command

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau added a comment. In D89807#2342192 , @JDevlieghere wrote: > What's the motivation for this? This is preventing me from generating the build system: -- SWIG 2 or later is required for Python support in LLDB but could not be found CMake Erro

[Lldb-commits] [lldb] b333d6e - lldb: Migrate to MemoryBufferRef for createFileID (after 51d1d585e5838ea0f02f1271f7543c4e43639969)

Author: Duncan P. N. Exon Smith Date: 2020-10-20T13:52:39-04:00 New Revision: b333d6e129f23d204cd3a44ffb9f3a69dc3e0bc9 URL: https://github.com/llvm/llvm-project/commit/b333d6e129f23d204cd3a44ffb9f3a69dc3e0bc9 DIFF: https://github.com/llvm/llvm-project/commit/b333d6e129f23d204cd3a44ffb9f3a69dc3e

[Lldb-commits] [PATCH] D89215: [lldb] Add a page to the documentation with (external) links on how to use LLDB

JDevlieghere updated this revision to Diff 299408. JDevlieghere added a comment. - Use markdown - Add a little text snippet to the links CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89215/new/ https://reviews.llvm.org/D89215 Files: lldb/docs/index.rst lldb/docs/use/links.md Inde

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. In D88483#2341538 , @fallkrum wrote: > Thanks a lot Jim for explanations, now it makes sense to me. > Have one more question on class Type. Writing API test for the patch defined > 2 functions like this: > > void *func1(int) { >

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

JDevlieghere added a comment. What's the motivation for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/ https://reviews.llvm.org/D89807 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. ctetreau requested review of this revision. Herald added a subscriber: JDevlieghere. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89807 Files: lldb/cmake/modules/Fin

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2341628 , @labath wrote: > I'm afraid I don't understand what you mean. Could you try to be more > specific? > > It's true that currently lldb client uses the register offsets provided by > the server (if they are pres

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2341561 , @labath wrote: > In D89334#2339018 , @JDevlieghere > wrote: > >> In D89334#2334881 , @labath wrote: >> >>> In D89334#233245

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

labath added a comment. In D89283#2340586 , @wallace wrote: > What's left to discuss: > > - I tried to use obj2yaml, but it creates files much larger than the > binaries, so in terms of space, I'd rather keep the binaries. Besides, I > removed ld.so, and

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. I'm afraid I don't understand what you mean. Could you try to be more specific? It's true that currently lldb client uses the register offsets provided by the server (if they are present), and this is a divergence from pure gdb-remote. Were it not for variable-sized regi

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath added a comment. In D89334#2339018 , @JDevlieghere wrote: > In D89334#2334881 , @labath wrote: > >> In D89334#2332452 , @JDevlieghere >> wrote: >> >>> I don't think

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Thanks a lot Jim for explanations, now it makes sense to me. Have one more question on class Type. Writing API test for the patch defined 2 functions like this: void *func1(int) { return NULL; } void *func2(int) { return NULL; } Tried to

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2334664 , @labath wrote: > In D82863#2331892 , @omjavaid wrote: > >> In D82863#2330122 , @labath wrote: >> >>> I started drafting an email

[Lldb-commits] [lldb] c932266 - Add a nul byte to packet str before logging, increase default size.

Author: Jason Molenda Date: 2020-10-20T01:43:31-07:00 New Revision: c932266c8d0414672974eb77786f1d0f122d URL: https://github.com/llvm/llvm-project/commit/c932266c8d0414672974eb77786f1d0f122d DIFF: https://github.com/llvm/llvm-project/commit/c932266c8d0414672974eb77786f1d0f122d.diff