[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace updated this revision to Diff 297373. wallace added a comment. - Moved the thread dumping logic to Trace.h. - Did the small fixes that were requested. - Left a comment regarding the shared_ptr instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace marked 3 inline comments as done. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:61 + const std::vector &targets) { + TraceSP trace_instance(new TraceIntelPT(pt_cpu, targets)); + for (co

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace added inline comments. Comment at: lldb/source/Target/Thread.cpp:1617-1627 +void Thread::DumpTraceInstructions(Stream &s, size_t count, + size_t start_position) const { + if (!GetProcess()->GetTarget().GetTrace()) { +s << "error: no

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea1f49741ec4: [intel pt] Refactor parsing (authored by Walter Erqu

[Lldb-commits] [lldb] ea1f497 - [intel pt] Refactor parsing

Author: Walter Erquinigo Date: 2020-10-09T17:32:04-07:00 New Revision: ea1f49741ec4c0a37796b88f6bb8d09d7ab1e8c3 URL: https://github.com/llvm/llvm-project/commit/ea1f49741ec4c0a37796b88f6bb8d09d7ab1e8c3 DIFF: https://github.com/llvm/llvm-project/commit/ea1f49741ec4c0a37796b88f6bb8d09d7ab1e8c3.di

[Lldb-commits] [PATCH] D89155: [lldb] Minidump: check for .text hash match with directory

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:533 + } if (module_sp) { // We consider the module to be a match i

[Lldb-commits] [PATCH] D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Only `SymbolFileDWARF

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JosephTremoulet requested review of this revision. This allows the Target to update its module list when loading a shared module replaces an equivale

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JosephTremoulet requested review of this revision. Herald added a subscriber: JDevlieghere. The various GetSharedModule methods have an optional out parameter for the old module when a fil

[Lldb-commits] [PATCH] D89155: [lldb] Minidump: check for .text hash match with directory

JosephTremoulet created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JosephTremoulet requested review of this revision. When opening a minidump, we might discover that it reports a UUID for a module that doesn't match

[Lldb-commits] [lldb] 5d50109 - [lldb] Update docs with new buildbot URLs

Author: Jonas Devlieghere Date: 2020-10-09T10:57:39-07:00 New Revision: 5d501096ca1fae74f910411cfeb0491d94c635b7 URL: https://github.com/llvm/llvm-project/commit/5d501096ca1fae74f910411cfeb0491d94c635b7 DIFF: https://github.com/llvm/llvm-project/commit/5d501096ca1fae74f910411cfeb0491d94c635b7.d

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

jankratochvil added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1354 + auto region_it = llvm::find_if(m_mem_region_cache, [](const auto &pair) { +return pair.first.GetExecutable() == MemoryRegionInfo::eYes; + }); Fi

Re: [Lldb-commits] [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hello Andrzej, Please do not update your bots yet. I will explicitly ask later. Feel free to move other reliably green bots of yours to the production buildbot. Thanks Galina On Fri, Oct 9, 2020 at 3:51 AM Andrzej Warzynski wrote: > I switched one of our workers to the main Buildbot and ever

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

DavidSpickett added inline comments. Comment at: lldb/test/API/lang/c/stepping/TestStepAndBreakpoints.py:23 @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr17932') -@expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr14437") @expectedFailureAll

[Lldb-commits] [PATCH] D89121: [lldb/Utility] Introduce UnimplementedError

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I was going to need something like this myself shortly. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89121/new/ https://rev

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1400 +.ToError()) +return std::move(Err); + Is it possible that the page we find is executable but not writeable and is this

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2321370 , @omjavaid wrote: > In D82863#2320342 , @jasonmolenda > wrote: > >> The original g/G packets were designed for little embedded systems where the >> stub had to be very sm

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1350 -Status NativeProcessLinux::AllocateMemory(size_t size, uint32_t permissions, - lldb::addr_t &addr) { -// FIXME implementing this req

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath created this revision. labath added reviewers: clayborg, jankratochvil, mgorny. Herald added subscribers: pengfei, emaste. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. labath requested review of this revision. This patch adds support for the _M and _m gdb-remote pack

[Lldb-commits] [PATCH] D89121: [lldb/Utility] Introduce UnimplementedError

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: LLDB. labath requested review of this revision. This is essentially a replacement for the PacketUnimplementedError previously present in the gdb-remote server code. The

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2320342 , @jasonmolenda wrote: > In D82863#2319568 , @labath wrote: > >> In D82863#2313676 , @jasonmolenda >> wrote: >> >>> (about g pac

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

labath added a comment. I was waiting for the dependant patch to take shape. This looks ok to me -- just one small design question. Comment at: lldb/include/lldb/Target/Target.h:1120 + /// The trace object. It might be undefined. + lldb::TraceSP &GetTrace(); +

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

labath accepted this revision. labath added a comment. Looks good. In D88841#2320410 , @wallace wrote: > - Cannot delete Trace() {}, as there’s a compilation error. Could be because > some constructors have been marked as deleted, so the compiler wants e

[Lldb-commits] [lldb] 0610a25 - [lldb] Delete copy operations on PluginInterface class

Author: Pavel Labath Date: 2020-10-09T10:37:09+02:00 New Revision: 0610a25a85a0a204c994331e1ab275f86010f9ad URL: https://github.com/llvm/llvm-project/commit/0610a25a85a0a204c994331e1ab275f86010f9ad DIFF: https://github.com/llvm/llvm-project/commit/0610a25a85a0a204c994331e1ab275f86010f9ad.diff