[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

mboehme added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:510 +with recording(self, self.TraceOn()) as sbuf: +print(args, kwargs, file=sbuf) + labath wrote: > JDevlieghere wrote: > > This should be > > ``` > >

[Lldb-commits] [lldb] def72b9 - [lldb/Interpreter] Remove redundant argument (NFC)

Author: Jonas Devlieghere Date: 2020-06-02T21:23:19-07:00 New Revision: def72b91950d44a68b8613f25fa1a09926171222 URL: https://github.com/llvm/llvm-project/commit/def72b91950d44a68b8613f25fa1a09926171222 DIFF: https://github.com/llvm/llvm-project/commit/def72b91950d44a68b8613f25fa1a09926171222.d

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

vsk added inline comments. Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:99 + if (!overflow) +overflow |= !llvm::checkedAdd(*signed_sum, SInt(carry_in)); uint64_t result = unsigned_sum; aprantl wrote: > vsk wrote: > > The d

[Lldb-commits] [PATCH] D80345: [DwarfExpression] Support entry values for indirect parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e39379bbbe1: [DwarfExpression] Support entry values for indirect parameters (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D80345?vs=265815&id=266337#toc Repository: rG LLVM Gi

[Lldb-commits] [lldb] 2d2a603 - Remove redundant code (NFC)

Author: Adrian Prantl Date: 2020-06-02T16:55:50-07:00 New Revision: 2d2a603d663328e25774982947e3a8a65e098678 URL: https://github.com/llvm/llvm-project/commit/2d2a603d663328e25774982947e3a8a65e098678 DIFF: https://github.com/llvm/llvm-project/commit/2d2a603d663328e25774982947e3a8a65e098678.diff

[Lldb-commits] [lldb] 393ac21 - [lldb/Test] Pass Make arguments in invocation instead of environment

Author: Jonas Devlieghere Date: 2020-06-02T16:49:58-07:00 New Revision: 393ac216489773e3676ec7d80c3d993f78a29b6a URL: https://github.com/llvm/llvm-project/commit/393ac216489773e3676ec7d80c3d993f78a29b6a DIFF: https://github.com/llvm/llvm-project/commit/393ac216489773e3676ec7d80c3d993f78a29b6a.d

[Lldb-commits] [lldb] 4c53d48 - [lldb/Test] Don't use the env to pass around configuration variables (NFC)

Author: Jonas Devlieghere Date: 2020-06-02T16:49:58-07:00 New Revision: 4c53d4801cbbb1b573e4ef758f93ead12e1f59a2 URL: https://github.com/llvm/llvm-project/commit/4c53d4801cbbb1b573e4ef758f93ead12e1f59a2 DIFF: https://github.com/llvm/llvm-project/commit/4c53d4801cbbb1b573e4ef758f93ead12e1f59a2.d

[Lldb-commits] [lldb] 5138a91 - [lldb/Test] Don't use the env to pass around configuration variables (NFC)

Author: Jonas Devlieghere Date: 2020-06-02T16:11:32-07:00 New Revision: 5138a91ef4f365a3e71eec4cea6b4599dfaabf26 URL: https://github.com/llvm/llvm-project/commit/5138a91ef4f365a3e71eec4cea6b4599dfaabf26 DIFF: https://github.com/llvm/llvm-project/commit/5138a91ef4f365a3e71eec4cea6b4599dfaabf26.d

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

dblaikie added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main vsk wrote: > dblaikie wrote: > >

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

vsk added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main dblaikie wrote: > vsk wrote: > > labat

[Lldb-commits] [PATCH] D81032: [lldb/Test] Don't print 'command invoked'

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere added a project: LLDB. The different tools constructing dotest invocations (lit and lldb-dotest) already print the command invocation so there's no point in duplicating it in the dotest output. My motivation for

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

vsk added a comment. Thanks, this ended up being a lot cleaner than I expected! Comment at: lldb/include/lldb/Symbol/Function.h:332 - /// The address of the call instruction. Usually an invalid address, unless - /// this is a tail call. - lldb::addr_t call_inst_pc; + bool

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

dblaikie added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main vsk wrote: > labath wrote: > > la

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

vsk added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main labath wrote: > labath wrote: > > dbla

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

friss abandoned this revision. friss added a comment. Abandon in favor of D80755 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80807/new/ https://reviews.llvm.org/D80807 _

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

friss added inline comments. Comment at: lldb/source/Utility/UUID.cpp:66-67 uuid_bytes.clear(); while (!p.empty()) { -if (isxdigit(p[0]) && isxdigit(p[1])) { +if (p.size() >= 2 && isxdigit(p[0]) && isxdigit(p[1])) { int hi_nibble = xdigit_to_int(p[0]); --

[Lldb-commits] [lldb] de04375 - [lldb] Skip tests exercising DW_OP_GNU_entry_value with dsymutil

Author: Pavel Labath Date: 2020-06-02T18:31:15+02:00 New Revision: de04375ac59e6e9290b361b3ffcf4558e688e8a9 URL: https://github.com/llvm/llvm-project/commit/de04375ac59e6e9290b361b3ffcf4558e688e8a9 DIFF: https://github.com/llvm/llvm-project/commit/de04375ac59e6e9290b361b3ffcf4558e688e8a9.diff

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2068925 , @labath wrote: > Thanks for the explanation Raphael. This makes more sense now, though I am > still not very clear on the distinction between "completions" and > "suggestions". The fish tutorial mentions com

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. Thanks for the explanation Raphael. This makes more sense now, though I am still not very clear on the distinction between "completions" and "suggestions". The fish tutorial mentions command history -- that's something that's not typically done as a part of tab completio

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. @labath Just to get you into the loop: This is for a GSoC project that is about implementing the autosuggestions similar to what fish shell is providing. It's not really about actually invoking any completion logic (even though that might be an option in the future),

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

labath created this revision. labath added reviewers: vsk, dblaikie. Herald added subscribers: mgrang, aprantl. Herald added a project: LLDB. The way that the support for the GNU dialect of tail call frames was implemented in D80519 meant that the were reporting

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. Thanks for the patch. It's a very interesting feature, but I'm not sure it is actually a good idea. Some tab completions can be very expensive (not to mention they can crash lldb), and so running them after every keypress sounds problematic to me. Editors usually have ve

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 created this revision. gedatsu217 added reviewers: teemperor, JDevlieghere. gedatsu217 added a project: LLDB. Herald added a subscriber: lldb-commits. I implemented autosuggestion if there is one possible suggestion. I set the keybinds for every character. When a character is typed, Ed

[Lldb-commits] [lldb] df06f4f - [lldb] Handle a new clang built-in type

Author: Kadir Cetinkaya Date: 2020-06-02T15:41:33+02:00 New Revision: df06f4ff227bdcbbad01b418199876761f2a1ff0 URL: https://github.com/llvm/llvm-project/commit/df06f4ff227bdcbbad01b418199876761f2a1ff0 DIFF: https://github.com/llvm/llvm-project/commit/df06f4ff227bdcbbad01b418199876761f2a1ff0.dif

[Lldb-commits] [PATCH] D80995: [Scalar] Fix assignment operator for long long.

werat added a comment. In D80995#2068571 , @labath wrote: > Looks good. Given the timings, I am going to assume you are coordinating with > @miko. Thanks! This is very surprising, but we're not coordinating. I've found out about their patch just now. A

[Lldb-commits] [PATCH] D80990: [lldb] Fix sizeof() in Scalar::operator=()

miko abandoned this revision. miko added a comment. Unittest added in https://reviews.llvm.org/D80995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80990/new/ https://reviews.llvm.org/D80990 ___ lldb-

[Lldb-commits] [PATCH] D80995: [Scalar] Fix assignment operator for long long.

labath accepted this revision. labath added a subscriber: miko. labath added a comment. This revision is now accepted and ready to land. Looks good. Given the timings, I am going to assume you are coordinating with @miko. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D80995: [Scalar] Fix assignment operator for long long.

werat created this revision. werat added a reviewer: labath. werat added a project: LLDB. werat added a reviewer: teemperor. Assignment operator `operator=(long long)` currently allocates `sizeof(long)`. On some platforms it works as they have `sizeof(long) == sizeof(long long)`, but on others (

[Lldb-commits] [PATCH] D80990: [lldb] Fix sizeof() in Scalar::operator=()

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you add a unit test for this? See the`ScalarTest.cpp` for the other Scalar tests. Beside that this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D80990: [lldb] Fix sizeof() in Scalar::operator=()

labath added a comment. The fix looks obviously correct, but could you please also add a unit test for this. I guess this would manifest itself as the inability to roundtrip e.g. `std::numeric_limits::max()` to a Scalar and back. It's not required, but if you're interested, it would be nice to

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main ---

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbddd28882644: [lldb/DWARF] Add support for pre-standard GNU call site attributes (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80519/ne

[Lldb-commits] [PATCH] D80990: [lldb] Fix sizeof() in Scalar::operator=()

miko created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Scalar::operator=(long long) the size of the result was calculated using sizeof(long) instead of sizeof(long long). On Windows sizeof(long)==4 but sizeof(long long)==8. Repository: rG LLVM G

[Lldb-commits] [lldb] bddd288 - [lldb/DWARF] Add support for pre-standard GNU call site attributes

Author: Pavel Labath Date: 2020-06-02T12:57:51+02:00 New Revision: bddd2888264492a6deb0d447ee6ac042d3fb44e4 URL: https://github.com/llvm/llvm-project/commit/bddd2888264492a6deb0d447ee6ac042d3fb44e4 DIFF: https://github.com/llvm/llvm-project/commit/bddd2888264492a6deb0d447ee6ac042d3fb44e4.diff

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

labath marked 5 inline comments as done. labath added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main ---

Re: [Lldb-commits] [lldb] cbfae97 - [LLDB] Mark TestCreateDuringInstructionStep as flaky on Linux

On 02/06/2020 11:10, Muhammad Omair Javaid via lldb-commits wrote: > > Author: Muhammad Omair Javaid > Date: 2020-06-02T14:08:28+05:00 > New Revision: cbfae97ca82b11ab2b54562055c49817baa1e26b > > URL: > https://github.com/llvm/llvm-project/commit/cbfae97ca82b11ab2b54562055c49817baa1e26b > DIFF:

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Let's just wait a while to see if Fred has any comments. If you haven't already, you can use that time to get commit access. :) Comment at: lldb/source/Utility/U

[Lldb-commits] [lldb] cbfae97 - [LLDB] Mark TestCreateDuringInstructionStep as flaky on Linux

Author: Muhammad Omair Javaid Date: 2020-06-02T14:08:28+05:00 New Revision: cbfae97ca82b11ab2b54562055c49817baa1e26b URL: https://github.com/llvm/llvm-project/commit/cbfae97ca82b11ab2b54562055c49817baa1e26b DIFF: https://github.com/llvm/llvm-project/commit/cbfae97ca82b11ab2b54562055c49817baa1e2

[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

labath added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:41 +/// Note that this is also used for static member functions of a C++ class. +Function + }; shafik wrote: > I would actually feel better