labath added inline comments.

================
Comment at: 
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:41
+    /// Note that this is also used for static member functions of a C++ class.
+    Function
+  };
----------------
shafik wrote:
> I would actually feel better have a separate enumerator for C++ static member 
> functions and just having it fall-through when used. It would be 
> self-documenting.
If it doesn't complicate the callers (i.e., they always know, or can easily 
find out, whether they are dealing with a static member or a non-member), I 
think that would be great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80793/new/

https://reviews.llvm.org/D80793



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to