JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
JDevlieghere added a project: LLDB.
The different tools constructing dotest invocations (lit and
lldb-dotest) already print the command invocation so there's no point in
duplicating it in the dotest output.
My motivation for removing it is that it doesn't include the
the Python interpreter and every time I accidentally copy it
the command fails with an `ImportError`.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D81032
Files:
lldb/packages/Python/lldbsuite/test/dotest.py
Index: lldb/packages/Python/lldbsuite/test/dotest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/dotest.py
+++ lldb/packages/Python/lldbsuite/test/dotest.py
@@ -49,9 +49,6 @@
from lldbsuite.test_event.event_builder import EventBuilder
from ..support import seven
-def get_dotest_invocation():
- return ' '.join(sys.argv)
-
def is_exe(fpath):
"""Returns true if fpath is an executable."""
@@ -220,7 +217,6 @@
parser = dotest_args.create_parser()
args = parser.parse_args()
except:
- print(get_dotest_invocation())
raise
if args.unset_env_varnames:
@@ -243,10 +239,6 @@
if args.set_inferior_env_vars:
lldbtest_config.inferior_env = ' '.join(args.set_inferior_env_vars)
- # Only print the args if being verbose.
- if args.v:
- print(get_dotest_invocation())
-
if args.h:
do_help = True
@@ -1085,7 +1077,6 @@
"\nSession logs for test failures/errors/unexpected successes"
" will go into directory '%s'\n" %
configuration.sdir_name)
- sys.stderr.write("Command invoked: %s\n" % get_dotest_invocation())
#
# Invoke the default TextTestRunner to run the test suite
Index: lldb/packages/Python/lldbsuite/test/dotest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/dotest.py
+++ lldb/packages/Python/lldbsuite/test/dotest.py
@@ -49,9 +49,6 @@
from lldbsuite.test_event.event_builder import EventBuilder
from ..support import seven
-def get_dotest_invocation():
- return ' '.join(sys.argv)
-
def is_exe(fpath):
"""Returns true if fpath is an executable."""
@@ -220,7 +217,6 @@
parser = dotest_args.create_parser()
args = parser.parse_args()
except:
- print(get_dotest_invocation())
raise
if args.unset_env_varnames:
@@ -243,10 +239,6 @@
if args.set_inferior_env_vars:
lldbtest_config.inferior_env = ' '.join(args.set_inferior_env_vars)
- # Only print the args if being verbose.
- if args.v:
- print(get_dotest_invocation())
-
if args.h:
do_help = True
@@ -1085,7 +1077,6 @@
"\nSession logs for test failures/errors/unexpected successes"
" will go into directory '%s'\n" %
configuration.sdir_name)
- sys.stderr.write("Command invoked: %s\n" % get_dotest_invocation())
#
# Invoke the default TextTestRunner to run the test suite
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
