[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 247786. MrHate added a comment. removed unnecessary assignment in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProcess.cpp lldb/test/API/functionalities/co

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 247785. MrHate added a comment. Update the current execution context, then get signals from the current process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProc

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate added a comment. Thanks for pointing out my misunderstanding on the Unix signals, and fetching the list of valid signals from backend is always a better way indeed. However, getting the current process from the current context `m_exe_ctx` which is got from `m_interpreter` will cause an is

[Lldb-commits] [PATCH] D75496: [lldb][NFC] Remove some commented out code in TypeSystemClang

davide added a comment. @teemperor quite honestly you touched this code enough lately that you can commit such trivial changes without asking for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75496/new/ https://reviews.llvm.org/D75496

[Lldb-commits] [PATCH] D75497: [lldb][NFC] Refactor TestSafeFuncCalls.py

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75497/new/ https://reviews.llvm.org/D75497 _

[Lldb-commits] [PATCH] D75496: [lldb][NFC] Remove some commented out code in TypeSystemClang

davide added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75496/new/ https://reviews.llvm.org/D75496 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 138c7ac - [lldb/GDBRemote] Fix obvious typo in error message.

Author: Fred Riss Date: 2020-03-02T17:53:39-08:00 New Revision: 138c7ac5b60fae9f4b048a268e069f3ed895a098 URL: https://github.com/llvm/llvm-project/commit/138c7ac5b60fae9f4b048a268e069f3ed895a098 DIFF: https://github.com/llvm/llvm-project/commit/138c7ac5b60fae9f4b048a268e069f3ed895a098.diff LOG

[Lldb-commits] [PATCH] D75497: [lldb][NFC] Refactor TestSafeFuncCalls.py

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch inlines all the single-line functions that we only use once in the test and replaces the assertTrue with an assertEquals to improve the erro

[Lldb-commits] [PATCH] D75496: [lldb][NFC] Remove some commented out code in TypeSystemClang

teemperor created this revision. teemperor added a reviewer: LLDB. I don't see why we want to keep that code around. https://reviews.llvm.org/D75496 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp ==

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

This revision was automatically updated to reflect the committed changes. Closed by commit rG20ce8affce85: [lldb/API] NFC: Reformat and simplify SBThread::GetStopDescription() (authored by friss). Changed prior to commit: https://reviews.llvm.org/D74157?vs=243239&id=247770#toc Repository: rG

[Lldb-commits] [lldb] 20ce8af - [lldb/API] NFC: Reformat and simplify SBThread::GetStopDescription()

Author: Fred Riss Date: 2020-03-02T17:43:35-08:00 New Revision: 20ce8affce85ddea069e979a6e79a2c62ca7a0bc URL: https://github.com/llvm/llvm-project/commit/20ce8affce85ddea069e979a6e79a2c62ca7a0bc DIFF: https://github.com/llvm/llvm-project/commit/20ce8affce85ddea069e979a6e79a2c62ca7a0bc.diff LOG

[Lldb-commits] [PATCH] D75493: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Otherwise this code won't run on the Release+Asserts builds we have on the CI. Fixes rdar://problem/59867885 (partly) Repository: rLLDB LLD

[Lldb-commits] [PATCH] D75488: RFC: Preserve the owning module information from DWARF in the synthesized AST

aprantl added a comment. Raphael just pointed out to me that since each DeclContext is also a Decl I don't need the machinery to hide the owning module ID in CompilerDeclContext and can just rely on the owning module ID stored before the Decl. That should make this patch a lot shorter. CHANGE

[Lldb-commits] [PATCH] D75488: RFC: Preserve the owning module information from DWARF in the synthesized AST

aprantl created this revision. aprantl added reviewers: teemperor, shafik, labath. Types that came from a Clang module are nested in DW_TAG_module tags in DWARF. This patch recreates the Clang module hierarchy in LLDB and sets the owning module information accordingly. My primary motivation is t

[Lldb-commits] [lldb] 7ad30f4 - [lldb/Utility] Use emplace_back instead of push_back (NFC)

Author: Jonas Devlieghere Date: 2020-03-02T15:54:00-08:00 New Revision: 7ad30f4249cf70983d9f7e921445f7af9e158d38 URL: https://github.com/llvm/llvm-project/commit/7ad30f4249cf70983d9f7e921445f7af9e158d38 DIFF: https://github.com/llvm/llvm-project/commit/7ad30f4249cf70983d9f7e921445f7af9e158d38.d

Re: [Lldb-commits] [lldb] b6b3fcd - [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

> On Mar 2, 2020, at 15:44, Raphael “Teemperor” Isemann > wrote: > > I was just grepping for unordered data structures (e.g. ’std::set<‘) that use > pointers/pointer-like objects (e.g. CompilerType with its operator<) and then > reading the related code. Not sure if there is a good way to de

Re: [Lldb-commits] [lldb] b6b3fcd - [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

I was just grepping for unordered data structures (e.g. ’std::set<‘) that use pointers/pointer-like objects (e.g. CompilerType with its operator<) and then reading the related code. Not sure if there is a good way to detect this stuff automatically. I guess we could have had a Clang plugin that

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6b3fcdcb8cd: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

JDevlieghere accepted this revision. JDevlieghere added a comment. Seems like a better fit indeed, because we don't need the sequential IDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75481/new/ https://reviews.llvm.org/D75481 ___ lldb-c

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

teemperor updated this revision to Diff 247733. teemperor added a comment. This revision is now accepted and ready to land. - Use SetVector instead. - Remove now unused include to CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75481/new/ https://reviews.llvm.org/D75481 Files: lldb/so

Re: [Lldb-commits] [lldb] b6b3fcd - [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

This is really good. How did you find it, Raphael? I generally use LLVM_REVERSE_ITERATOR but given this wasn’t a container in llvm, I’m curious to hear. — Davide > On Mar 2, 2020, at 15:04, Raphael Isemann via lldb-commits > wrote: > > > Author: Raphael Isemann > Date: 2020-03-02T15:03:45-08

[Lldb-commits] [lldb] b6b3fcd - [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

Author: Raphael Isemann Date: 2020-03-02T15:03:45-08:00 New Revision: b6b3fcdcb8cdfb887e26d27bee03b997d2d65888 URL: https://github.com/llvm/llvm-project/commit/b6b3fcdcb8cdfb887e26d27bee03b997d2d65888 DIFF: https://github.com/llvm/llvm-project/commit/b6b3fcdcb8cdfb887e26d27bee03b997d2d65888.dif

Re: [Lldb-commits] [lldb] c77fc00 - [lldb/Docs] Remove the version from the home page

> On Mar 2, 2020, at 14:48, Jonas Devlieghere wrote: > > If you feel strongly about this and want to change it to zero, be my guest. > :-) > > I personally don't see any value in an additional comment. eddf59ae71a19b3fe872760833365dffc46a3b2e ___

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

teemperor planned changes to this revision. teemperor added a comment. Just realized that this should be `llvm::SetVector` not `UniqueVector` ... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75481/new/ https://reviews.llvm.org/D75481 ___

[Lldb-commits] [lldb] eddf59a - [docs] Use 0 as version placeholder instead of a made up number.

Author: Davide Italiano Date: 2020-03-02T14:55:05-08:00 New Revision: eddf59ae71a19b3fe872760833365dffc46a3b2e URL: https://github.com/llvm/llvm-project/commit/eddf59ae71a19b3fe872760833365dffc46a3b2e DIFF: https://github.com/llvm/llvm-project/commit/eddf59ae71a19b3fe872760833365dffc46a3b2e.dif

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

teemperor created this revision. teemperor added reviewers: JDevlieghere, aprantl. Herald added subscribers: lldb-commits, abidh, mgrang. Herald added a project: LLDB. JDevlieghere accepted this revision. This revision is now accepted and ready to land. teemperor planned changes to this revision. t

Re: [Lldb-commits] [lldb] c77fc00 - [lldb/Docs] Remove the version from the home page

If you feel strongly about this and want to change it to zero, be my guest. :-) I personally don't see any value in an additional comment. On Mon, Mar 2, 2020 at 2:43 PM Davide Italiano wrote: > > > On Mar 2, 2020, at 14:35, Jonas Devlieghere wrote: > > > > On Mon, Mar 2, 2020 at 2:28 PM David

Re: [Lldb-commits] [lldb] c77fc00 - [lldb/Docs] Remove the version from the home page

> On Mar 2, 2020, at 14:35, Jonas Devlieghere wrote: > > > > On Mon, Mar 2, 2020 at 2:28 PM Davide Italiano > wrote: > You might want to consider removing it entirely instead of commenting it, > unless you find some value in keeping something that’s already stale

Re: [Lldb-commits] [lldb] c77fc00 - [lldb/Docs] Remove the version from the home page

On Mon, Mar 2, 2020 at 2:28 PM Davide Italiano wrote: > You might want to consider removing it entirely instead of commenting it, > unless you find some value in keeping something that’s already stale around > for the future (e.g. re-enabling). > If you take a look at the rest of the file you'll

Re: [Lldb-commits] [lldb] c77fc00 - [lldb/Docs] Remove the version from the home page

You might want to consider removing it entirely instead of commenting it, unless you find some value in keeping something that’s already stale around for the future (e.g. re-enabling). — Davide > On Mar 2, 2020, at 14:23, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devli

[Lldb-commits] [lldb] c77fc00 - [lldb/Docs] Remove the version from the home page

Author: Jonas Devlieghere Date: 2020-03-02T14:23:05-08:00 New Revision: c77fc00eec081f3465e3b62708b2e6f8a32da3dd URL: https://github.com/llvm/llvm-project/commit/c77fc00eec081f3465e3b62708b2e6f8a32da3dd DIFF: https://github.com/llvm/llvm-project/commit/c77fc00eec081f3465e3b62708b2e6f8a32da3dd.d

[Lldb-commits] [PATCH] D75330: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG69d2b675562c: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 69d2b67 - [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

Author: Raphael Isemann Date: 2020-03-02T10:57:56-08:00 New Revision: 69d2b675562cfce71882023874b6aead94107f97 URL: https://github.com/llvm/llvm-project/commit/69d2b675562cfce71882023874b6aead94107f97 DIFF: https://github.com/llvm/llvm-project/commit/69d2b675562cfce71882023874b6aead94107f97.dif

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

xiaobai added a comment. I like the idea! The one thing that kind of bothers me about this is you can inadvertently break your build without realizing by disabling a plugin that some enabled plugins depend on. Hopefully one day we'll be able to improve the diagnostics around this. CHANGES SIN

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

JDevlieghere planned changes to this revision. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D73016#1900403 , @labath wrote: > This looks fine, but I think you'll first need to handle the lit changes to > allow skipping t

[Lldb-commits] [PATCH] D75454: [lldb] Make sure we don't drop asynchronous output when sourcing files

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM, check remote build failure to be sure! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75454/new/ https://reviews.llvm.org/D75454 ___

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. Yes please. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. Thanks for the patch. Do you need me to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 _

[Lldb-commits] [PATCH] D75454: [lldb] Make sure we don't drop asynchronous output when sourcing files

JDevlieghere added a comment. To the best of my understanding of the IOHandler this LGTM, but I'd like to have Greg look at it too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75454/new/ https://reviews.llvm.org/D75454 ___

[Lldb-commits] [PATCH] D75454: [lldb] Make sure we don't drop asynchronous output when sourcing files

labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added a project: LLDB. If a command from a sourced file produces asynchronous output, this output often does not make its way to the user. This happens because the asynchronous output machinery relies on the iohan

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 247597. unnar marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 Files: lldb/include/lldb/Utility/RangeMap.h Index: lldb/include/lldb/Utility/RangeMap.h

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. Thanks for the feedback! I addressed all of your comments in the latest patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath added a comment. I think this is looking very good now. Just a few polishing comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:604 +template +struct AugmentedRangeData : public RangeData { Add a short comment about the purpose of this class.

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

labath added a comment. This looks fine, but I think you'll first need to handle the lit changes to allow skipping tests. Otherwise all of the pdb and breakpad tests will break once you do this. I guess the reason that this hasn't happened yet is because you have a typo in your cache file. =