> On Mar 2, 2020, at 14:35, Jonas Devlieghere <jo...@devlieghere.com> wrote:
>
>
>
> On Mon, Mar 2, 2020 at 2:28 PM Davide Italiano <ditali...@apple.com
> <mailto:ditali...@apple.com>> wrote:
> You might want to consider removing it entirely instead of commenting it,
> unless you find some value in keeping something that’s already stale around
> for the future (e.g. re-enabling).
>
> If you take a look at the rest of the file you'll see it's consistent with
> other options that are disabled. I believe this is the Sphinx default. It
> also communicates that this is disabled on purpose and not just an oversight
> or option added in a later version.
>
Then you might consider setting the version to 0 or to the current version. And
adding a comment explaining this has no semantic value associated.
Leaving a stale version is confusing for somebody who opens the file, e.g. me.
—
Davide
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
