teemperor created this revision.
teemperor added a reviewer: aprantl.
Herald added subscribers: lldb-commits, JDevlieghere.
Herald added a project: LLDB.
Otherwise this code won't run on the Release+Asserts builds we have on the CI.
Fixes rdar://problem/59867885 (partly)
Repository:
rLLDB LLDB
https://reviews.llvm.org/D75493
Files:
lldb/source/Core/Section.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
Index: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
===================================================================
--- lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
+++ lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
@@ -88,9 +88,7 @@
void SetAllRegisterValid(bool b);
bool GetRegisterIsValid(uint32_t reg) const {
-#if defined(LLDB_CONFIGURATION_DEBUG)
assert(reg < m_reg_valid.size());
-#endif
if (reg < m_reg_valid.size())
return m_reg_valid[reg];
return false;
@@ -103,9 +101,7 @@
}
void SetRegisterIsValid(uint32_t reg, bool valid) {
-#if defined(LLDB_CONFIGURATION_DEBUG)
assert(reg < m_reg_valid.size());
-#endif
if (reg < m_reg_valid.size())
m_reg_valid[reg] = valid;
}
Index: lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
===================================================================
--- lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
+++ lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
@@ -77,11 +77,9 @@
}
std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);
-#ifdef LLDB_CONFIGURATION_DEBUG
// NOTE: this only works for packets that are in native endian byte order
assert(request_packet.GetSize() ==
*((const uint16_t *)(request_packet.GetData() + 2)));
-#endif
lldb::offset_t offset = 1;
const uint32_t num_retries = 3;
for (uint32_t i = 0; i < num_retries; ++i) {
Index: lldb/source/Core/Section.cpp
===================================================================
--- lldb/source/Core/Section.cpp
+++ lldb/source/Core/Section.cpp
@@ -267,11 +267,9 @@
so_addr.SetOffset(offset);
so_addr.SetSection(const_cast<Section *>(this)->shared_from_this());
-#ifdef LLDB_CONFIGURATION_DEBUG
// For debug builds, ensure that there are no orphaned (i.e., moduleless)
// sections.
assert(GetModule().get());
-#endif
return true;
}
Index: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
===================================================================
--- lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
+++ lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
@@ -88,9 +88,7 @@
void SetAllRegisterValid(bool b);
bool GetRegisterIsValid(uint32_t reg) const {
-#if defined(LLDB_CONFIGURATION_DEBUG)
assert(reg < m_reg_valid.size());
-#endif
if (reg < m_reg_valid.size())
return m_reg_valid[reg];
return false;
@@ -103,9 +101,7 @@
}
void SetRegisterIsValid(uint32_t reg, bool valid) {
-#if defined(LLDB_CONFIGURATION_DEBUG)
assert(reg < m_reg_valid.size());
-#endif
if (reg < m_reg_valid.size())
m_reg_valid[reg] = valid;
}
Index: lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
===================================================================
--- lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
+++ lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
@@ -77,11 +77,9 @@
}
std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);
-#ifdef LLDB_CONFIGURATION_DEBUG
// NOTE: this only works for packets that are in native endian byte order
assert(request_packet.GetSize() ==
*((const uint16_t *)(request_packet.GetData() + 2)));
-#endif
lldb::offset_t offset = 1;
const uint32_t num_retries = 3;
for (uint32_t i = 0; i < num_retries; ++i) {
Index: lldb/source/Core/Section.cpp
===================================================================
--- lldb/source/Core/Section.cpp
+++ lldb/source/Core/Section.cpp
@@ -267,11 +267,9 @@
so_addr.SetOffset(offset);
so_addr.SetSection(const_cast<Section *>(this)->shared_from_this());
-#ifdef LLDB_CONFIGURATION_DEBUG
// For debug builds, ensure that there are no orphaned (i.e., moduleless)
// sections.
assert(GetModule().get());
-#endif
return true;
}
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
