[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

teemperor added a comment. I'm very much in favor of making this more strict by default. My only problem is that the current error message is really cryptic: AssertionError: False is not True : 'expr --show-types -- *(StgClosure*)$r14' returns expected result, got '(StgClosure) $3 = { (St

[Lldb-commits] [lldb] 381e81a - [lldb][NFCI] Remove UserExpression::GetJITModule

Author: Alex Langford Date: 2020-01-30T23:20:19-08:00 New Revision: 381e81a048f8cd6aab6a41c87ad1b1658f052192 URL: https://github.com/llvm/llvm-project/commit/381e81a048f8cd6aab6a41c87ad1b1658f052192 DIFF: https://github.com/llvm/llvm-project/commit/381e81a048f8cd6aab6a41c87ad1b1658f052192.diff

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

JDevlieghere updated this revision to Diff 241637. JDevlieghere added a comment. Remove debug print CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73766/new/ https://reviews.llvm.org/D73766 Files: lldb/packages/Python/lldbsuite/test/functionalities/mtc/simple/TestMTCSimple.py lldb/

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. This patch is more of an RFC to change the default behavior of the `substrs` argument to `self.expect`. Currently, the elements of `substrs` are unordered and as long as the string appears in t

[Lldb-commits] [lldb] 22b0448 - [lldb][NFCI] Remove unused LanguageType parameters

Author: Alex Langford Date: 2020-01-30T21:57:23-08:00 New Revision: 22b044877d239c40c9a932d1ea47d489c507000f URL: https://github.com/llvm/llvm-project/commit/22b044877d239c40c9a932d1ea47d489c507000f DIFF: https://github.com/llvm/llvm-project/commit/22b044877d239c40c9a932d1ea47d489c507000f.diff

Re: [Lldb-commits] [lldb] e3a7c77 - [lldb/Lit] Change the lldbtest format to behave more like shell test.

On Thu, 2020-01-30 at 21:24 -0800, Jonas Devlieghere wrote: > commit 196b31f9f19d743f55fa70744ddfd2f85d6ad117 (HEAD -> master, > origin/master) > Author: Jonas Devlieghere > Date: Thu Jan 30 21:23:58 2020 -0800 > > [lldb/Lit] Fix UnboundLocalError when reaching a timeout. > > Fixes th

Re: [Lldb-commits] [lldb] e3a7c77 - [lldb/Lit] Change the lldbtest format to behave more like shell test.

commit 196b31f9f19d743f55fa70744ddfd2f85d6ad117 (HEAD -> master, origin/master) Author: Jonas Devlieghere Date: Thu Jan 30 21:23:58 2020 -0800 [lldb/Lit] Fix UnboundLocalError when reaching a timeout. Fixes the UnboundLocalError for the local variables out, err and exitCode when a

[Lldb-commits] [lldb] 196b31f - [lldb/Lit] Fix UnboundLocalError when reaching a timeout.

Author: Jonas Devlieghere Date: 2020-01-30T21:23:58-08:00 New Revision: 196b31f9f19d743f55fa70744ddfd2f85d6ad117 URL: https://github.com/llvm/llvm-project/commit/196b31f9f19d743f55fa70744ddfd2f85d6ad117 DIFF: https://github.com/llvm/llvm-project/commit/196b31f9f19d743f55fa70744ddfd2f85d6ad117.d

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4011 +void SymbolFileDWARF::GetDWARFDeclContext(const DWARFDIE &die, + DWARFDeclConte

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil updated this revision to Diff 241634. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70646/new/ https://reviews.llvm.org/D70646 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241630. jankratochvil added a comment. It needed to add the line: include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include) But then maybe it also needs: # Our current version of gtest does not properly recognize C++11 support

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Any objections from anyone else? We do have tests for this right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73594/new/ https://reviews.llvm.org/D73594

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

JDevlieghere added a comment. Awesome, thanks for doing this Alex! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] 31905c2 - [lldb][NFCI] Delete commented out code

Author: Alex Langford Date: 2020-01-30T18:02:36-08:00 New Revision: 31905c2bbb80f79366d92fc6426818fb20896659 URL: https://github.com/llvm/llvm-project/commit/31905c2bbb80f79366d92fc6426818fb20896659 DIFF: https://github.com/llvm/llvm-project/commit/31905c2bbb80f79366d92fc6426818fb20896659.diff

[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

vsk planned changes to this revision. vsk added a comment. Yikes, this version seems to break TestClassTemplateParameterPack.py (and probably other tests as well). Maybe we expect to be able to read past the end of the buffer inside of a ValueObjectChild, because the buffer for the next ValueOb

[Lldb-commits] [lldb] e1451a7 - [lldb][NFCI] Rename variable in ValueObject

Author: Alex Langford Date: 2020-01-30T16:53:01-08:00 New Revision: e1451a724de743f1634c864205b77196edbd527e URL: https://github.com/llvm/llvm-project/commit/e1451a724de743f1634c864205b77196edbd527e DIFF: https://github.com/llvm/llvm-project/commit/e1451a724de743f1634c864205b77196edbd527e.diff

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

xiaobai added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2041 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes, GetExpressionPathFormat epformat) { labath wrote: > Should we re

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG45e3f6660cf4: Auto-completion bug fix for dot operator (authored by Hector Diaz , committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [lldb] 45e3f66 - Auto-completion bug fix for dot operator

Author: Hector Diaz Date: 2020-01-30T16:02:58-08:00 New Revision: 45e3f6660cf4503a8f63ce0a22e574f6d0997914 URL: https://github.com/llvm/llvm-project/commit/45e3f6660cf4503a8f63ce0a22e574f6d0997914 DIFF: https://github.com/llvm/llvm-project/commit/45e3f6660cf4503a8f63ce0a22e574f6d0997914.diff L

[Lldb-commits] [lldb] 58c4fa2 - [lldb/Reproducers] Use LLDB_RECORD_DUMMY for GetStopDescription

Author: Jonas Devlieghere Date: 2020-01-30T15:40:58-08:00 New Revision: 58c4fa2c538a73527aeeb4c7535016d9b9a1df18 URL: https://github.com/llvm/llvm-project/commit/58c4fa2c538a73527aeeb4c7535016d9b9a1df18 DIFF: https://github.com/llvm/llvm-project/commit/58c4fa2c538a73527aeeb4c7535016d9b9a1df18.d

[Lldb-commits] [lldb] 457a6d4 - [lldb/Reproducers] Fix typo in CMake so we actually replay.

Author: Jonas Devlieghere Date: 2020-01-30T15:51:29-08:00 New Revision: 457a6d49d565075ae99f0e5a931bbed6512dce2f URL: https://github.com/llvm/llvm-project/commit/457a6d49d565075ae99f0e5a931bbed6512dce2f DIFF: https://github.com/llvm/llvm-project/commit/457a6d49d565075ae99f0e5a931bbed6512dce2f.d

[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/dw_op_piece/main.cpp:34 + //% self.filecheck("image lookup -va $pc", "main.cpp", "-check-prefix=INFO-V1") + // INFO-V1: name = "v1", type = "S1", l

[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

vsk updated this revision to Diff 241602. vsk retitled this revision from "[lldb/Value] Report size of Value as size of underlying data buffer" to "[lldb/Value] Avoid reading more data than the host has available". vsk edited the summary of this revision. vsk added a comment. Address review feed

Re: [Lldb-commits] [lldb] e3a7c77 - [lldb/Lit] Change the lldbtest format to behave more like shell test.

Yep, Michał also reported this here: https://reviews.llvm.org/D73384 I hope to take a look at that today. On Thu, Jan 30, 2020 at 1:43 PM Vedant Kumar wrote: > > > > > On Jan 24, 2020, at 4:18 PM, Jonas Devlieghere via lldb-commits > > wrote: > > > > > > Author: Jonas Devlieghere > > Date: 202

Re: [Lldb-commits] [lldb] e3a7c77 - [lldb/Lit] Change the lldbtest format to behave more like shell test.

> On Jan 24, 2020, at 4:18 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-01-24T16:17:55-08:00 > New Revision: e3a7c7713cd87e37a95a544373cd21f6f06ab94e > > URL: > https://github.com/llvm/llvm-project/commit/e3a7c7713cd87e37a95a544373cd21f6f06ab9

[Lldb-commits] [lldb] 92a42b6 - [lldb][NFC] LLDB_LOGF to LLDB_LOG conversion in ClangASTImporter

Author: Raphael Isemann Date: 2020-01-30T22:10:31+01:00 New Revision: 92a42b6a4d1544acb96f334369ea6c1c948634e3 URL: https://github.com/llvm/llvm-project/commit/92a42b6a4d1544acb96f334369ea6c1c948634e3 DIFF: https://github.com/llvm/llvm-project/commit/92a42b6a4d1544acb96f334369ea6c1c948634e3.dif

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

xiaobai added a comment. In D73661#1848750 , @labath wrote: > I think this is a big milestone. Thanks for working on this. > > The main question I have is about the new location of this code. This patch > puts it under ExpressionParser/Clang, which is no

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added a comment. > there is a problem: if I remove DynamicLoaderWasmDYLD what happens is that > `DynamicLoaderStatic` is found as a valid loader for a triple like > **"wasm32-unknown-unknown-wasm"** because the Triple::OS is > llvm::Triple::UnknownOS (I found out the hard way when I

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added a comment. In D72751#1848880 , @labath wrote: > In D72751#1847617 , @clayborg wrote: > > > Yes the current approach allows anyone to load any section at any address. > > On Darwin systems, the DYLD s

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

clayborg added a comment. I vote to make this a plug-in as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241545. jankratochvil added a comment. Herald added a subscriber: mgorny. By making the new `.cpp` file I get now this error: In file included from /home/jkratoch/redhat/llvm-monorepo/lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.cpp:9: In

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg updated this revision to Diff 241543. clayborg added a comment. Handle breakpoint events in the same way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73665/new/ https://reviews.llvm.org/D73665 Files: lldb/tools/lldb-vscode/JSONUtils.c

[Lldb-commits] [lldb] 05badc6 - [lldb/Reproducers] Fix API boundary tracking bug

Author: Jonas Devlieghere Date: 2020-01-30T11:22:12-08:00 New Revision: 05badc60b7f4dff3c1b9efd5d7eea13979e255db URL: https://github.com/llvm/llvm-project/commit/05badc60b7f4dff3c1b9efd5d7eea13979e255db DIFF: https://github.com/llvm/llvm-project/commit/05badc60b7f4dff3c1b9efd5d7eea13979e255db.d

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth updated this revision to Diff 241510. amccarth marked an inline comment as done. amccarth added a comment. - Backed out the warn-and-continue behavior change. It should be addressed later. - Changed lldb_assert to assert. - Improved comment in place of the proposed TODO. CHANGES SINCE

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth marked 3 inline comments as done. amccarth added a comment. I backed out the TODO and the warn-and-continue behavior to expedite this patch which is just supposed to be a refactor for readability. We can revisit the issue of debug symbol file names not matching the object file names in

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg added a comment. In D73665#1848755 , @labath wrote: > This is not ideal, but if that's what vscode wants, then I guess we just have > to do it. > > However, are you sure that this is all that needs to be done here. It seems > like also the handl

[Lldb-commits] [PATCH] D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test.

mgorny added a comment. I suppose you need to make the timeout branch entirely separate from the non-timeout branch, as the variable assignment does not take place then. Comment at: lldb/test/API/lldbtest.py:100 +output = """Script:\n--\n%s\n--\nExit Code: %d\n""" % (

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG727ed11b24c0: [AVR] Recognize the AVR architecture in lldb (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.ll

[Lldb-commits] [lldb] 727ed11 - [AVR] Recognize the AVR architecture in lldb

Author: Ayke van Laethem Date: 2020-01-30T13:40:31+01:00 New Revision: 727ed11b24c08c84a608886a1716b81c93640d80 URL: https://github.com/llvm/llvm-project/commit/727ed11b24c08c84a608886a1716b81c93640d80 DIFF: https://github.com/llvm/llvm-project/commit/727ed11b24c08c84a608886a1716b81c93640d80.di

[Lldb-commits] [lldb] df8a986 - [lldb][NFC] Remove TypeSystemClang::GetASTContext calls in IRForTarget

Author: Raphael Isemann Date: 2020-01-30T12:07:19+01:00 New Revision: df8a986f533d6b1726e79acfa53ba854943704c3 URL: https://github.com/llvm/llvm-project/commit/df8a986f533d6b1726e79acfa53ba854943704c3 DIFF: https://github.com/llvm/llvm-project/commit/df8a986f533d6b1726e79acfa53ba854943704c3.dif

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

teemperor added a comment. Also this doesn't compile on Linux: FAILED: tools/lldb/source/Plugins/ABI/SysV-ppc64/CMakeFiles/lldbPluginABISysV_ppc64.dir/ABISysV_ppc64.cpp.o

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, per the previous comment. A couple of additional inline comments in the test. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWa

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. In D72751#1848384 , @paolosev wrote: > Regarding: > > >> - make the base DynamicLoader class instantiatable, and use it whenever we > >> fail to find a specialized plugin > >> - same as above, but only do that for ProcessGDBRemote

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. In D72751#1847617 , @clayborg wrote: > Yes the current approach allows anyone to load any section at any address. On > Darwin systems, the DYLD shared cache will move __TEXT, __DATA, and other > sections around such that all __TEX

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

teemperor added a comment. Pretty much what Pavel said, otherwise this LGTM. Maybe also rename/move the unit test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 __

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4103 +// this point. +// TODO: Is this part worthwhile? `foo.exe` will never match `foo.pdb` +if (matching_modules.IsEmpty()) amccarth wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

labath added a comment. This is not ideal, but if that's what vscode wants, then I guess we just have to do it. However, are you sure that this is all that needs to be done here. It seems like also the handling of eBreakpointEventTypeLocationsAdded/Removed events in EventThreadFunction should

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

labath added a comment. I think this is a big milestone. Thanks for working on this. The main question I have is about the new location of this code. This patch puts it under ExpressionParser/Clang, which is not completely unreasonable, as that's where most of the clang stuff is. However, it d